From vangyzen@trillian.vangyzen.net  Wed Jan 28 08:59:46 2004
Return-Path: <vangyzen@trillian.vangyzen.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B6A5116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 28 Jan 2004 08:59:46 -0800 (PST)
Received: from trillian.vangyzen.net (trillian.client.intrex.net [209.42.213.136])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7AF7243D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 28 Jan 2004 08:59:38 -0800 (PST)
	(envelope-from vangyzen@trillian.vangyzen.net)
Received: from trillian.vangyzen.net (localhost.vangyzen.net [127.0.0.1])
	by trillian.vangyzen.net (8.12.9/8.12.9) with ESMTP id i0SGxGrl075144;
	Wed, 28 Jan 2004 11:59:17 -0500 (EST)
	(envelope-from vangyzen@trillian.vangyzen.net)
Received: (from vangyzen@localhost)
	by trillian.vangyzen.net (8.12.9/8.12.9/Submit) id i0SGx6Ig075139;
	Wed, 28 Jan 2004 11:59:06 -0500 (EST)
Message-Id: <200401281659.i0SGx6Ig075139@trillian.vangyzen.net>
Date: Wed, 28 Jan 2004 11:59:06 -0500 (EST)
From: Eric van Gyzen <vangyzen@stat.duke.edu>
Reply-To: Eric van Gyzen <vangyzen@stat.duke.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc: des@des.no
Subject: src/libexec/ftpd/ftpd.c: local pam_handle_t shadows global
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62036
>Category:       bin
>Synopsis:       src/libexec/ftpd/ftpd.c: local pam_handle_t shadows global
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 28 09:00:37 PST 2004
>Closed-Date:    Sat Oct 30 16:38:38 GMT 2004
>Last-Modified:  Sat Oct 30 16:38:38 GMT 2004
>Originator:     Eric van Gyzen
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
>Environment:
FreeBSD 5.2-RELEASE

>Description:
The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable
    pam_handle_t *pamh = NULL;
which shadows the same variable in the global scope.  This seems 
unintentional, because the global pamh is never initialized by pam_start(), 
so the other functions in ftpd.c always operate on a NULL pam_handle_t.

>How-To-Repeat:
N/A

>Fix:

Index: src/libexec/ftpd/ftpd.c
===================================================================
RCS file: /build/cvsroot/src/libexec/ftpd/ftpd.c,v
retrieving revision 1.147
diff -u -r1.147 ftpd.c
--- src/libexec/ftpd/ftpd.c	15 Nov 2003 11:08:26 -0000	1.147
+++ src/libexec/ftpd/ftpd.c	28 Jan 2004 16:54:50 -0000
@@ -1238,7 +1238,6 @@
 static int
 auth_pam(struct passwd **ppw, const char *pass)
 {
-	pam_handle_t *pamh = NULL;
 	const char *tmpl_user;
 	const void *item;
 	int rval;
>Release-Note:
>Audit-Trail:

From: "Nick Leuta" <skynick@mail.sc.ru>
To: <freebsd-gnats-submit@FreeBSD.org>, <vangyzen@stat.duke.edu>
Cc:  
Subject: Re: bin/62036: src/libexec/ftpd/ftpd.c: local pam_handle_t shadows global
Date: Fri, 6 Feb 2004 13:48:05 +0300

 This problem is already described in
 http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/59776 .
 
 
State-Changed-From-To: open->closed 
State-Changed-By: yar 
State-Changed-When: Sat Oct 30 16:37:42 GMT 2004 
State-Changed-Why:  
The problem already reported in bin/59776 in more detail. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62036 
>Unformatted:
