From delphij@frontfree.net  Mon Jan 26 21:47:58 2004
Return-Path: <delphij@frontfree.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8137D16A54F; Mon, 26 Jan 2004 21:47:57 -0800 (PST)
Received: from ftp.bjpu.edu.cn (ftp.bjpu.edu.cn [202.112.78.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1385C4408A; Mon, 26 Jan 2004 19:49:36 -0800 (PST)
	(envelope-from delphij@frontfree.net)
Received: by ftp.bjpu.edu.cn (Postfix, from userid 426)
	id DE4515358; Tue, 27 Jan 2004 10:44:26 +0800 (CST)
Received: from beastie.frontfree.net (beastie.frontfree.net [218.107.145.7])
	by ftp.bjpu.edu.cn (Postfix) with ESMTP
	id BC9565299; Tue, 27 Jan 2004 10:44:26 +0800 (CST)
Received: by beastie.frontfree.net (Postfix, from userid 1001)
	id 752F211BA4; Tue, 27 Jan 2004 10:44:25 +0800 (CST)
Message-Id: <20040127024425.752F211BA4@beastie.frontfree.net>
Date: Tue, 27 Jan 2004 10:44:25 +0800 (CST)
From: Xin LI <delphij@frontfree.net>
Reply-To: Xin LI <delphij@frontfree.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ume@FreeBSD.org
Subject: [PATCH] sync src/usr.sbin/setkey/token.l with KAME
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         61978
>Category:       bin
>Synopsis:       [patch] sync setkey(8) token.l with KAME
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 26 21:50:11 PST 2004
>Closed-Date:    
>Last-Modified:  Sat May 24 19:15:20 UTC 2008
>Originator:     Xin LI
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
The FreeBSD Simplified Chinese Project
>Environment:
System: FreeBSD beastie.frontfree.net 5.2-RELEASE FreeBSD 5.2-RELEASE #16: Sat Jan 10 15:24:09 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386

>Description:
	Merge KAME's rev. 1.44-1.45 of setkey/token.l
>How-To-Repeat:
>Fix:

	Apply the attached patch. Please note that NetBSD-specific and *BSD cross compile support was removed from this merge to reduce the diff. twofish-cbc is not implemented in FreeBSD and was not included in this patch.

--- patch begins here ---
--- token.l.orig	Wed Nov  5 17:47:54 2003
+++ token.l	Tue Jan 27 10:36:13 2004
@@ -1,5 +1,5 @@
-/*	$FreeBSD: src/usr.sbin/setkey/token.l,v 1.9 2003/11/05 09:47:54 ume Exp $	*/
-/*	$KAME: token.l,v 1.43 2003/07/25 09:35:28 itojun Exp $	*/
+/*	$FreeBSD$	*/
+/*	$KAME: token.l,v 1.45 2004/01/08 06:01:03 sakane Exp $	*/
 
 /*
  * Copyright (C) 1995, 1996, 1997, 1998, and 1999 WIDE Project.
@@ -110,7 +110,7 @@
 			/* count up for nl */
 			    {
 				char *p;
-				for (p = yytext; *p != NULL; p++)
+				for (p = yytext; *p != 0; p++)
 					if (*p == '\n')
 						lineno++;
 			    }
@@ -151,13 +151,13 @@
 <S_AUTHALG>hmac-sha2-512 { yylval.num = SADB_X_AALG_SHA2_512; BEGIN INITIAL; return(ALG_AUTH); }
 <S_AUTHALG>hmac-ripemd160 { yylval.num = SADB_X_AALG_RIPEMD160HMAC; BEGIN INITIAL; return(ALG_AUTH); }
 <S_AUTHALG>aes-xcbc-mac { yylval.num = SADB_X_AALG_AES_XCBC_MAC; BEGIN INITIAL; return(ALG_AUTH); }
-<S_AUTHALG>null { yylval.num = SADB_X_AALG_NULL; BEGIN INITIAL; return(ALG_AUTH_NOKEY); }
+<S_AUTHALG>null { yylval.num = SADB_X_AALG_NULL; BEGIN INITIAL; return(ALG_AUTH); }
 
 	/* encryption alogorithm */
 {hyphen}E	{ BEGIN S_ENCALG; return(F_ENC); }
 <S_ENCALG>des-cbc	{ yylval.num = SADB_EALG_DESCBC; BEGIN INITIAL; return(ALG_ENC); }
 <S_ENCALG>3des-cbc	{ yylval.num = SADB_EALG_3DESCBC; BEGIN INITIAL; return(ALG_ENC); }
-<S_ENCALG>null		{ yylval.num = SADB_EALG_NULL; BEGIN INITIAL; return(ALG_ENC_NOKEY); }
+<S_ENCALG>null		{ yylval.num = SADB_EALG_NULL; BEGIN INITIAL; return(ALG_ENC); }
 <S_ENCALG>simple	{ yylval.num = SADB_EALG_NULL; BEGIN INITIAL; return(ALG_ENC_OLD); }
 <S_ENCALG>blowfish-cbc	{ yylval.num = SADB_X_EALG_BLOWFISHCBC; BEGIN INITIAL; return(ALG_ENC); }
 <S_ENCALG>cast128-cbc	{ yylval.num = SADB_X_EALG_CAST128CBC; BEGIN INITIAL; return(ALG_ENC); }
@@ -219,7 +219,7 @@
 {quotedstring}	{
 			char *p = yytext;
 			while (*++p != '"') ;
-			*p = NULL;
+			*p = 0;
 			yytext++;
 			yylval.val.len = yyleng - 2;
 			yylval.val.buf = strdup(yytext);
--- patch ends here ---


>Release-Note:
>Audit-Trail:

From: Volker <volker@vwsoft.com>
To: bug-followup@FreeBSD.org, delphij@freebsd.org
Cc:  
Subject: Re: bin/61978: [PATCH] sync src/usr.sbin/setkey/token.l with KAME
Date: Mon, 11 Feb 2008 13:38:54 +0100

 file sbin/setkey/token.l has been slightly modified since this PR has
 been filed.
 
 NULL comparison / assignments have been modified, but the return
 statements for S_AUTHALG and S_ENCALG haven't been touched.
 
 Can you please check if your patch is still needed and either indicate
 if this can get closed or commit needed changes?
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Tue Feb 12 09:28:49 UTC 2008 
State-Changed-Why:  
Note that submitter has been asked for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61978 
State-Changed-From-To: feedback->open 
State-Changed-By: vwe 
State-Changed-When: Sat May 10 17:03:15 UTC 2008 
State-Changed-Why:  

Submitter has commit access ;) 
a slightly modified patch is needed or PR might be closed 


Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: vwe 
Responsible-Changed-When: Sat May 10 17:03:15 UTC 2008 
Responsible-Changed-Why:  

Submitter has commit access ;) 
a slightly modified patch is needed or PR might be closed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61978 
>Unformatted:
