From kogane@syd.odn.ne.jp  Mon Jan 19 10:16:46 2004
Return-Path: <kogane@syd.odn.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A2CCD16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 19 Jan 2004 10:16:46 -0800 (PST)
Received: from t-mta3.odn.ne.jp (mfep3.odn.ne.jp [143.90.131.181])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D296E43D55
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 19 Jan 2004 10:16:40 -0800 (PST)
	(envelope-from kogane@syd.odn.ne.jp)
Received: from kces1.koganemaru.co.jp ([218.218.116.207])
          by t-mta3.odn.ne.jp with ESMTP
          id <20040119181639855.SUPF.327156.t-mta3.odn.ne.jp@mta3.odn.ne.jp>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Tue, 20 Jan 2004 03:16:39 +0900
Received: (from kogane@localhost)
	by kces1.koganemaru.co.jp (8.8.8/3.6W) id DAA01189;
	Tue, 20 Jan 2004 03:16:40 +0900 (JST)
Message-Id: <200401191816.DAA01189@kces1.koganemaru.co.jp>
Date: Tue, 20 Jan 2004 03:16:40 +0900 (JST)
From: n-kogane@syd.odn.ne.jp
Reply-To: n-kogane@syd.odn.ne.jp
To: FreeBSD-gnats-submit@freebsd.org
Subject: installation problem, disklabel can't write boot code.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         61587
>Category:       bin
>Synopsis:       [sysinstall] [patch] installation problem, disklabel can't write boot code.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 19 10:20:16 PST 2004
>Closed-Date:    Mon Sep 29 07:42:17 UTC 2008
>Last-Modified:  Mon Sep 29 07:50:01 UTC 2008
>Originator:     Nobuyuki Koganemaru
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
KOGANEMARU Computer Engineering Service Corporation.
>Environment:
FreeBSD kcesx21.koganemaru.co.jp 5.2-RELEASE FreeBSD 5.2-RELEASE #0: Sun Jan 11 04:21:45 GMT 2004     root@wv1u.btc.adaptec.com:/usr/obj/usr/src/sys/GENERIC  i386


>Description:
	At upgrade installation, disklabel can't write boot code.
	disklabel must be specified slice name.

>How-To-Repeat:
	5.2-RELEASE upgrade installation.

>Fix:

--- sysinstall/installUpgrade.c.orig	Sat Mar  8 21:07:13 2003
+++ sysinstall/installUpgrade.c	Tue Jan 20 03:09:02 2004
@@ -345,7 +345,7 @@
     }
 
     if (extractingBin)
-	vsystem("disklabel -B `awk '$2~/\\/$/ {print substr($1, 6, 3)}' /etc/fstab`");
+	vsystem("disklabel -B `awk '$2~/\\/$/ {print substr($1, 6, 5)}' /etc/fstab`");
     msgNotify("First stage of upgrade completed successfully!\n\n"
 	       "Next comes stage 2, where we attempt to resurrect your /etc\n"
 	       "directory!");
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-qa 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Aug 29 06:05:24 GMT 2004 
Responsible-Changed-Why:  
sysinstall problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61587 
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Tue Jun 5 05:44:48 UTC 2007 
State-Changed-Why:  
Patch committed against -HEAD.  Pending MFC. 


Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Tue Jun 5 05:44:48 UTC 2007 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61587 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/61587: commit references a PR
Date: Tue,  5 Jun 2007 05:44:47 +0000 (UTC)

 delphij     2007-06-05 05:44:41 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.sbin/sysinstall  installUpgrade.c 
   Log:
   Write to slice name instead of directly to the disk device.
   This fixes writing boot code upon upgrade.
   
   PR:             bin/61587
   Submitted by:   Nobuyuki Koganemaru <n-kogane syd.odn.ne.jp>
   MFC after:      1 month
   
   Revision  Changes    Path
   1.96      +1 -1      src/usr.sbin/sysinstall/installUpgrade.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: delphij@FreeBSD.org
Subject: Re: bin/61587: [sysinstall] [patch] installation problem,
	disklabel can't write boot code.
Date: Thu, 29 May 2008 14:26:36 +0100

 This is fixed in HEAD and RELENG_7 but needs to be MFC'd to RELENG_6
 still.  delphij, is there any chance this can be done?
 
 Thanks,
 Gavin
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Mon Sep 29 07:42:00 UTC 2008 
State-Changed-Why:  
Patch applied to RELENG_6, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61587 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/61587: commit references a PR
Date: Mon, 29 Sep 2008 07:41:43 +0000 (UTC)

 delphij     2008-09-29 07:41:17 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     usr.sbin/sysinstall  installUpgrade.c 
   Log:
   SVN rev 183457 on 2008-09-29 07:41:17Z by delphij
   
   Merge revision 170320:
   
   Write to slice name instead of directly to the disk device.
   This fixes writing boot code upon upgrade.
   
   PR:             bin/61587
   Submitted by:   Nobuyuki Koganemaru <n-kogane syd.odn.ne.jp>
   Approved by:    re (blackend)
   
   Revision   Changes    Path
   1.84.12.7  +1 -1      src/usr.sbin/sysinstall/installUpgrade.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
