From eugen@db.svznov.kemerovo.su  Wed Jan 14 01:13:14 2004
Return-Path: <eugen@db.svznov.kemerovo.su>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 171D216A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jan 2004 01:13:14 -0800 (PST)
Received: from db.svznov.kemerovo.su (db.svznov.kemerovo.su [213.184.64.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AF40043D54
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jan 2004 01:13:10 -0800 (PST)
	(envelope-from eugen@db.svznov.kemerovo.su)
Received: from db.svznov.kemerovo.su (localhost [127.0.0.1])
	by db.svznov.kemerovo.su (8.12.10/8.12.10) with ESMTP id i0EGAfMd022481
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Jan 2004 16:10:41 GMT
	(envelope-from eugen@db.svznov.kemerovo.su)
Received: (from eugen@localhost)
	by db.svznov.kemerovo.su (8.12.10/8.12.10/Submit) id i0EGAeKp022480;
	Wed, 14 Jan 2004 16:10:40 GMT
	(envelope-from eugen)
Message-Id: <200401141610.i0EGAeKp022480@db.svznov.kemerovo.su>
Date: Wed, 14 Jan 2004 16:10:40 GMT
From: Eugeny Grosbein <eugen@kuzbass.ru>
Reply-To: Eugeny Grosbein <eugen@kuzbass.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: login(1) prints last login time for 'hushlogin' configuration
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         61354
>Category:       bin
>Synopsis:       login(1) prints last login time for 'hushlogin' configuration
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 14 01:20:19 PST 2004
>Closed-Date:    Mon Jan 26 12:07:51 PST 2004
>Last-Modified:  Mon Jan 26 12:07:51 PST 2004
>Originator:     Eugeny Grosbein
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD db.svznov.kemerovo.su 5.2-CURRENT FreeBSD 5.2-CURRENT #3: Mon Dec 15 10:10:19 GMT 2003 adv@db.svznov.kemerovo.su:/usr/obj/usr/src/sys/DB i386

>Description:
		
	login(1) man page says that login prints nothing when
	"hushlogin" option is used. That is true for 4.x
	and not true for 5.2-CURRENT (15 Dec 2003): it prints
	last login time. It can break non-human applications.

>How-To-Repeat:

	touch ~$USER/.hushlogin
	login $USER

>Fix:

	Unknown.

>Release-Note:
>Audit-Trail:

From: Eugene Grosbein <eugen@kuzbass.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/61354: login(1) prints last login time for 'hushlogin' 
 configuration
Date: Wed, 14 Jan 2004 16:42:39 +0700

 Hi!
 
 Here is a patch:
 
 --- login.c.orig        Wed Jan 14 16:21:58 2004
 +++ login.c     Wed Jan 14 16:37:16 2004
 @@ -356,8 +356,6 @@
         lc = login_getpwclass(pwd);
  
         quietlog = login_getcapbool(lc, "hushlogin", 0);
 -       if (!quietlog)
 -               pam_silent = 0;
  
         /*
          * Switching needed for NFS with root access disabled.
 @@ -385,6 +383,8 @@
         (void)setegid(egid);
         if (!quietlog)
                 quietlog = access(_PATH_HUSHLOGIN, F_OK) == 0;
 +       if (!quietlog)
 +               pam_silent = 0;
  
         shell = login_getcapstr(lc, "shell", pwd->pw_shell, pwd->pw_shell);
         if (*pwd->pw_shell == '\0')
 
 
 Eugene Grosbein
State-Changed-From-To: open->closed 
State-Changed-By: fjoe 
State-Changed-When: Mon Jan 26 12:06:53 PST 2004 
State-Changed-Why:  
I committed slightly modified version of this fix. Please test. 
Thanks for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61354 
>Unformatted:
