From MAILER-DAEMON  Sun Dec 28 14:06:33 2003
Return-Path: <>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BCBF616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 28 Dec 2003 14:06:33 -0800 (PST)
Received: from anchor-post-35.mail.demon.net (anchor-post-35.mail.demon.net [194.217.242.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1DF8F43D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 28 Dec 2003 14:06:30 -0800 (PST)
	(envelope-from "")
Received: from lizacnet.demon.co.uk ([80.177.208.105])
	by anchor-post-35.mail.demon.net with esmtp (Exim 3.35 #1)
	id 1Aaj3N-0006C3-0Z
	for FreeBSD-gnats-submit@freebsd.org; Sun, 28 Dec 2003 22:06:29 +0000
Message-Id: <1072649236@lizacnet.demon.co.uk>
Date: Sun, 28 Dec 2003 22:07:16 -0000
From: "Mark Dixon" <mark@markdnet.demon.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Aacontrol doesn't know about WDMA1
X-Send-Pr-Version: gtk-send-pr 0.2 
X-GNATS-Notify:

>Number:         60670
>Category:       bin
>Synopsis:       Atacontrol doesn't know about WDMA1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 28 14:10:18 PST 2003
>Closed-Date:    Mon Jan 12 11:18:45 PST 2004
>Last-Modified:  Mon Jan 12 11:18:45 PST 2004
>Originator:     Mark Dixon
>Release:        FreeBSD 5.2-RC i386
>Organization:
>Environment:


System: FreeBSD lizacnet.demon.co.uk 5.2-RC FreeBSD 5.2-RC #20: Mon Dec 22 23:47:06 GMT 2003     mark@lizacnet.demon.co.uk:/usr/obj/usr/src/sys/MARKS i386

Relevent bit of dmesg:

GEOM: create disk afd0 dp=0xc3b0626c
afd0: REMOVABLE <LS-120 VER5 00 UHD Floppy> at ata1-slave WDMA1



>Description:


The atacontrol program returns the mode of WDMA1 devices as ?????. I think it should be WDMA1.

e.g. 

abox# atacontrol mode 1
Master = BIOSPIO
Slave  = ???

should be:

abox# atacontrol mode 1
Master = BIOSPIO
Slave  = WDMA1





>How-To-Repeat:


Run atacontrol with a WDMA1 device.


>Fix:


Apply this diff to src/sbin/atacontrol/atacontrol.c

--- atacontrol.bak      Sun Dec 28 22:01:33 2003
+++ atacontrol.c        Sun Dec 28 22:02:49 2003
@@ -59,6 +59,7 @@
        case ATA_PIO2: return "PIO2";
        case ATA_PIO3: return "PIO3";
        case ATA_PIO4: return "PIO4";
+       case ATA_WDMA1: return "WDMA1";
        case ATA_WDMA2: return "WDMA2";
        case ATA_UDMA2: return "UDMA33";
        case ATA_UDMA4: return "UDMA66";



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: simon 
Responsible-Changed-When: Sun Dec 28 15:46:46 PST 2003 
Responsible-Changed-Why:  
Over to ata maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60670 
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Mon Jan 12 11:17:43 PST 2004 
State-Changed-Why:  
Actually we shouldn't allow WMDA1 mode at all, its problematic.. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60670 
>Unformatted:
