From joshe@jade.elsasser.org  Fri Nov 28 11:13:43 2003
Return-Path: <joshe@jade.elsasser.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB6EF16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Nov 2003 11:13:43 -0800 (PST)
Received: from mail.vineyard.net (k1.vineyard.net [204.17.195.90])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D718543F93
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Nov 2003 11:13:42 -0800 (PST)
	(envelope-from joshe@jade.elsasser.org)
Received: from localhost (loopback [127.0.0.1])
	by mail.vineyard.net (Postfix) with ESMTP id DF15692DF8
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Nov 2003 14:06:54 -0500 (EST)
Received: from mail.vineyard.net ([127.0.0.1])
 by localhost (king1.vineyard.net [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 60721-07 for <FreeBSD-gnats-submit@freebsd.org>;
 Fri, 28 Nov 2003 14:06:54 -0500 (EST)
Received: from jade.elsasser.org (loopback [127.0.0.1])
	by mail.vineyard.net (Postfix) with ESMTP id 632F292D8E
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Nov 2003 14:06:54 -0500 (EST)
Received: by jade.elsasser.org (Postfix, from userid 1000)
	id 75D78E4; Fri, 28 Nov 2003 14:06:53 -0500 (EST)
Message-Id: <20031128190653.75D78E4@jade.elsasser.org>
Date: Fri, 28 Nov 2003 14:06:53 -0500 (EST)
From: Josh Elsasser <jre@vineyard.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: patch: devfs_link in rc.subr creates link in wrong directory
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59768
>Category:       bin
>Synopsis:       patch: devfs_link in rc.subr creates link in wrong directory
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ceri
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 28 11:20:13 PST 2003
>Closed-Date:    Sat Dec 27 10:25:35 PST 2003
>Last-Modified:  Sat Dec 27 10:30:21 PST 2003
>Originator:     Josh Elsasser
>Release:        FreeBSD 5.2-BETA i386
>Organization:
>Environment:
System: FreeBSD jade.elsasser.org 5.2-BETA FreeBSD 5.2-BETA #5: Thu Nov 27 00:40:17 EST 2003 joshe@jade.elsasser.org:/usr/local/obj/usr/src/sys/JADE i386


	
>Description:
	The devfs_link function in /etc/rc.subr ignores it's "dir"
argument and instead creates the symlink in ${chroot}/dev.  Note that
if jail_enable="YES" and jail_foo_devfs_enable="YES" in /etc/rc.conf,
this bug will cause /etc/rc.d/jail to trash /dev/console.

>How-To-Repeat:
	Configure a jail in /etc/rc.conf and watch /dev/console disappear:
jail_enable="YES"
jail_list="foo"
jail_foo_rootdir="/foo"
jail_foo_hostname="foo"
jail_foo_ip="192.168.0.2"
jail_foo_exec="/bin/sh /etc/rc"
jail_foo_devfs_enable="YES"

>Fix:

diff -u /etc/rc.subr.orig /etc/rc.subr
--- /etc/rc.subr.orig	Fri Sep  5 16:54:29 2003
+++ /etc/rc.subr	Fri Nov 28 13:50:32 2003
@@ -1058,7 +1058,7 @@
 		warn "$_me: the directory ($dir) does not exist"
 		return 1
 	fi
-	cd ${chroot}/dev
+	cd "$dir"
 	if ! ln -sf $src $link ; then
 		warn "$_me: unable to link $link --> $src in $dir"
 		return 1
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: ceri 
State-Changed-When: Sat Dec 27 07:04:43 PST 2003 
State-Changed-Why:  
This patch no longer applies - is this still a problem in today's 
-CURRENT? 


Responsible-Changed-From-To: freebsd-bugs->ceri 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Sat Dec 27 07:04:43 PST 2003 
Responsible-Changed-Why:  
I'll handle the feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59768 
State-Changed-From-To: feedback->closed 
State-Changed-By: ceri 
State-Changed-When: Sat Dec 27 10:24:58 PST 2003 
State-Changed-Why:  
Submitter reports this was corrected in r1.17; thanks for 
the report. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59768 

From: Josh Elsasser <jre@vineyard.net>
To: Ceri Davies <ceri@FreeBSD.org>
Cc: freebsd-bugs@FreeBSD.org
Subject: Re: bin/59768: patch: devfs_link in rc.subr creates link in wrong directory
Date: Sat, 27 Dec 2003 13:19:22 -0500

 It seems to have been fixed several weeks ago by revision 1.17 of rc.subr.
 Thanks for looking into this, I had forgotten about it.
>Unformatted:
