From stefan@fafoe.narf.at  Mon Nov 10 09:53:50 2003
Return-Path: <stefan@fafoe.narf.at>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BF5A516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Nov 2003 09:53:50 -0800 (PST)
Received: from fafoe.narf.at (chello212186121237.14.vie.surfer.at [212.186.121.237])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BFD7A43F93
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Nov 2003 09:53:47 -0800 (PST)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.2.102])
	by fafoe.narf.at (Postfix) with ESMTP
	id 25E0B40B6; Mon, 10 Nov 2003 18:53:45 +0100 (CET)
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id E5E691AC; Mon, 10 Nov 2003 18:53:44 +0100 (CET)
Message-Id: <20031110175344.E5E691AC@wombat.fafoe.narf.at>
Date: Mon, 10 Nov 2003 18:53:44 +0100 (CET)
From: Stefan Farfeleder <stefan@fafoe.narf.at>
Reply-To: Stefan Farfeleder <stefan@fafoe.narf.at>
To: FreeBSD-gnats-submit@freebsd.org
Cc: stefan@fafoe.narf.at
Subject: [patch] Allow a trailing / for mount -u too
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59144
>Category:       bin
>Synopsis:       [patch] Allow a trailing / for mount -u too
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stefanf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 10 10:00:36 PST 2003
>Closed-Date:    Sun Jul 31 13:08:49 GMT 2005
>Last-Modified:  Sun Jul 31 13:08:49 GMT 2005
>Originator:     Stefan Farfeleder
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD wombat.fafoe.narf.at 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Nov 10 14:51:15 CET 2003 stefan@wombat.fafoe.narf.at:/usr/home/stefan/freebsd/obj/usr/home/stefan/freebsd/src/sys/WOMBAT i386

>Description:
In mount.c's revision 1.38 mount was patched to strip a trailing / from a
path to "[f]ix tab completion mounts (like /cdrom/)".  Annoyingly and
inconsequently this is not done for the MNT_UPDATE case (mount -u).

>How-To-Repeat:
$ sudo mount -u /usr/
mount: not currently mounted /usr/

>Fix:
--- mount.c.diff begins here ---
Index: src/sbin/mount/mount.c
===================================================================
RCS file: /usr/home/ncvs/src/sbin/mount/mount.c,v
retrieving revision 1.54
diff -u -r1.54 mount.c
--- src/sbin/mount/mount.c	7 Aug 2003 04:51:41 -0000	1.54
+++ src/sbin/mount/mount.c	10 Nov 2003 17:29:53 -0000
@@ -233,6 +233,7 @@
 		if (vfslist != NULL)
 			usage();
 
+		rmslashes(*argv, *argv);
 		if (init_flags & MNT_UPDATE) {
 			mntfromname = NULL;
 			have_fstab = 0;
@@ -271,7 +272,6 @@
 			    mntbuf->f_mntonname, init_flags, options, 0);
 			break;
 		}
-		rmslashes(*argv, *argv);
 		if ((fs = getfsfile(*argv)) == NULL &&
 		    (fs = getfsspec(*argv)) == NULL)
 			errx(1, "%s: unknown special file or file system",
--- mount.c.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: anholt 
State-Changed-When: Tue Jan 6 21:38:04 PST 2004 
State-Changed-Why:  
Committed to -current.  Thanks! 


Responsible-Changed-From-To: freebsd-bugs->anholt 
Responsible-Changed-By: anholt 
Responsible-Changed-When: Tue Jan 6 21:38:04 PST 2004 
Responsible-Changed-Why:  
Committed to -current.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59144 
Responsible-Changed-From-To: anholt->freebsd-bugs 
Responsible-Changed-By: anholt 
Responsible-Changed-When: Wed Jan 28 00:50:26 PST 2004 
Responsible-Changed-Why:  
Return this to freebsd-bugs.  I'm leaving for 3 months and won't be doing 
FreeBSD things. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59144 
Responsible-Changed-From-To: freebsd-bugs->le 
Responsible-Changed-By: le 
Responsible-Changed-When: Sun Mar 14 12:44:07 PST 2004 
Responsible-Changed-Why:  
Take this PR for eventual MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59144 
Responsible-Changed-From-To: le->stefanf 
Responsible-Changed-By: le 
Responsible-Changed-When: Thu May 13 15:02:17 PDT 2004 
Responsible-Changed-Why:  
Over to stefanf, let him do the work himself. :-) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59144 
State-Changed-From-To: patched->closed 
State-Changed-By: stefanf 
State-Changed-When: Sun Jul 31 13:08:14 GMT 2005 
State-Changed-Why:  
Not worth merging to 4.x. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59144 
>Unformatted:
