From andre.albsmeier@siemens.com  Tue Sep 30 04:02:55 2003
Return-Path: <andre.albsmeier@siemens.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2E71716A4B3
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Sep 2003 04:02:55 -0700 (PDT)
Received: from david.siemens.de (david.siemens.de [192.35.17.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C21443F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Sep 2003 04:02:51 -0700 (PDT)
	(envelope-from andre.albsmeier@siemens.com)
Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14])
	by david.siemens.de (8.11.7/8.11.7) with ESMTP id h8UB2nR02314
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Sep 2003 13:02:49 +0200 (MEST)
Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17])
	by mail3.siemens.de (8.11.7/8.11.7) with ESMTP id h8UB2nn18505
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Sep 2003 13:02:49 +0200 (MEST)
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7])
	by mars.cert.siemens.de (8.12.10/8.12.10/$SiemensCERT: mail/cert.mc,v 1.46 2003/05/28 09:28:32 ust Exp $) with ESMTP id h8UB2niR072582
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 30 Sep 2003 13:02:49 +0200 (CEST)
Received: (from localhost)
	by curry.mchp.siemens.de (8.12.9/8.12.9) id h8UB2nhE052202
	for FreeBSD-gnats-submit@freebsd.org; Tue, 30 Sep 2003 13:02:49 +0200 (CEST)
Message-Id: <200309301102.h8UB2nS7010685@curry.mchp.siemens.de>
Date: Tue, 30 Sep 2003 13:02:49 +0200 (CEST)
From: Andre Albsmeier <andre.albsmeier@siemens.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: amd sets wrong permissions on mount point for msdosfs
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         57401
>Category:       bin
>Synopsis:       amd sets wrong permissions on mount point for msdosfs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mbr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 30 04:10:20 PDT 2003
>Closed-Date:    Fri Oct 15 08:25:26 GMT 2004
>Last-Modified:  Fri Oct 15 09:00:55 GMT 2004
>Originator:     Andre Albsmeier
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:

System: FreeBSD 4.8-STABLE

>Description:

In august, the -M mask option for msdosfs was added:

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/msdosfs/Attic/msdosfsmount.h

amd doesn't know about the new mode_t dirmask which results
in the mountpoint having wrong permissions:

d---------  1 root  wheel  arch 7168 31 Dez  1979 /A/floppy/

>How-To-Repeat:

Configure amd to mount a msdos fs automatically and check
the permissions of the resulting mountpoint.

>Fix:

Quick and dirty:

--- contrib/amd/amd/ops_pcfs.c.ORI	Tue Sep 30 12:29:49 2003
+++ contrib/amd/amd/ops_pcfs.c	Tue Sep 30 12:54:14 2003
@@ -132,6 +132,7 @@
 
 #ifdef HAVE_FIELD_PCFS_ARGS_T_MASK
   pcfs_args.mask = 0777;	/* this may be the msdos file modes */
+  pcfs_args.dirmask = 0777;
 #endif /* HAVE_FIELD_PCFS_ARGS_T_MASK */
 
 #ifdef HAVE_FIELD_PCFS_ARGS_T_UID
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mbr 
Responsible-Changed-By: mbr 
Responsible-Changed-When: Sat Dec 6 01:53:43 PST 2003 
Responsible-Changed-Why:  
Take this PR 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57401 
State-Changed-From-To: open->feedback 
State-Changed-By: mbr 
State-Changed-When: Tue Jul 6 13:49:01 GMT 2004 
State-Changed-Why:  
Hi, 

I've fixed the problem in CURRENT with a slightly different fix. 
All changes and configure/autoconf changes have been submitted to 
the amd people. 

Thank you for the report. 

-- 
Martin 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57401 
State-Changed-From-To: feedback->closed 
State-Changed-By: mbr 
State-Changed-When: Fri Oct 15 08:25:08 GMT 2004 
State-Changed-Why:  
Feedback timeout. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57401 

From: Andre Albsmeier <andre.albsmeier@siemens.com>
To: Martin Blapp <mbr@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, andre.albsmeier@siemens.com
Subject: Re: bin/57401: amd sets wrong permissions on mount point for msdosfs
Date: Fri, 15 Oct 2004 10:51:22 +0200

 On Fri, 15-Oct-2004 at 08:25:25 +0000, Martin Blapp wrote:
 > Synopsis: amd sets wrong permissions on mount point for msdosfs
 > 
 > State-Changed-From-To: feedback->closed
 > State-Changed-By: mbr
 > State-Changed-When: Fri Oct 15 08:25:08 GMT 2004
 > State-Changed-Why: 
 > Feedback timeout.
 
 Hi Martin,
 
 sorry, I don't know what feedback you were expecting :-).
 
 Last time you wrote:
 
 ------------------------------ snip ------------------
 
 State-Changed-From-To: open->feedback 
 State-Changed-By: mbr 
 State-Changed-When: Tue Jul 6 13:49:01 GMT 2004 
 State-Changed-Why:  
 Hi, 
 
 I've fixed the problem in CURRENT with a slightly different fix. 
 All changes and configure/autoconf changes have been submitted to 
 the amd people. 
 
 Thank you for the report. 
 
 -- 
 Martin 
 
 ------------------------------ snap ------------------
 
 I don't run -CURRENT and neither the fix nor a newer version of
 amd has been imported into 4-STABLE so I honestly didn't know what
 I could have written at that time apart from "That's nice but this
 doesn't fix 4-STABLE" :-).
 
 Maybe you can simply commit the fix to 4-STABLE as well...
 
 	-Andre
>Unformatted:
