From james@jraynard.demon.co.uk  Thu Feb 12 15:43:32 1998
Received: from jraynard.demon.co.uk (jraynard.demon.co.uk [158.152.42.77])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA00616
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Feb 1998 15:43:15 -0800 (PST)
          (envelope-from james@jraynard.demon.co.uk)
Received: (from james@localhost) by jraynard.demon.co.uk (8.8.8/8.6.12) id XAA25819; Thu, 12 Feb 1998 23:13:25 GMT
Message-Id: <199802122313.XAA25819@jraynard.demon.co.uk>
Date: Thu, 12 Feb 1998 23:13:25 GMT
From: James Raynard <james@jraynard.demon.co.uk>
Reply-To: james@jraynard.demon.co.uk
To: FreeBSD-gnats-submit@freebsd.org
Subject: config doesn't specify which options are unknown
X-Send-Pr-Version: 3.2

>Number:         5730
>Category:       bin
>Synopsis:       config doesn't specify which options are unknown
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 12 15:50:01 PST 1998
>Closed-Date:    Sun Jun 7 06:41:27 PDT 1998
>Last-Modified:  Sun Jun  7 06:42:54 PDT 1998
>Originator:     James Raynard
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	FreeBSD-current, with version 1.24 of mkmakefile.c

>Description:

	Running config on a kernel configuration containing an
	invalid option causes a warning that an unknown option
	has been used, but doesn't specify which one.  This makes
	removing the offending option a little harder than necessary.

>How-To-Repeat:

	See above.

>Fix:
	Something like the following:	

Index: mkmakefile.c
===================================================================
RCS file: /home/cvs/src/usr.sbin/config/mkmakefile.c,v
retrieving revision 1.25
diff -u -r1.25 mkmakefile.c
--- mkmakefile.c	1998/02/09 23:59:51	1.25
+++ mkmakefile.c	1998/02/12 23:04:01
@@ -197,6 +197,7 @@
 				fprintf(ofp, " -D%s=%s", op->op_name, op->op_value);
 			else
 				fprintf(ofp, " -D%s", op->op_name);
+			printf("Unknown option: %s\n", op->op_name);
 		}
 	}
 	fprintf(ofp, "\n");
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: thepish 
State-Changed-When: Sun Jun 7 06:41:27 PDT 1998 
State-Changed-Why:  
Added -current's enhanced warning message to make config unknown option 
message display line number 
>Unformatted:
