From jau@mawit.com  Sat Sep 27 14:57:53 2003
Return-Path: <jau@mawit.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6EA2216A4B3; Sat, 27 Sep 2003 14:57:53 -0700 (PDT)
Received: from mail.mawit.com (ip212-226-165-194.adsl.kpnqwest.fi [212.226.165.194])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3FD4D44008; Sat, 27 Sep 2003 14:57:51 -0700 (PDT)
	(envelope-from jau@mawit.com)
Received: from mawit.com ([::ffff:127.0.0.1])
  by mail.mawit.com with esmtp; Sun, 28 Sep 2003 00:57:48 +0300
Received: from 62.78.135.6
        (SquirrelMail authenticated user jau)
        by office.mawit.com with HTTP;
        Sun, 28 Sep 2003 00:57:49 +0300 (EEST)
Message-Id: <3287.62.78.135.6.1064699869.squirrel@office.mawit.com>
Date: Sun, 28 Sep 2003 00:57:49 +0300 (EEST)
From: "Jukka A. Ukkonen" <jau@mawit.com>
To: FreeBSD-gnats-submit@freebsd.org, core-team@freebsd.org
Subject: Support for default passive ftp mode in fetch

>Number:         57297
>Category:       bin
>Synopsis:       Support for default passive ftp mode in fetch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 27 15:00:37 PDT 2003
>Closed-Date:    Thu Oct 02 05:39:23 PDT 2003
>Last-Modified:  Thu Oct 02 05:39:23 PDT 2003
>Originator:     Jukka A. Ukkonen
>Release:        
>Organization:
>Environment:
>Description:
 This is a MIME-formatted message.  If you see this text it means that your
 E-mail software does not support MIME-formatted messages.
 
 --=_singer-16884-1064699869-0001-2
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: 7bit
 X-Mime-Autoconverted: from 8bit to 7bit by courier 0.37
 
 Hi!
 
 The fact that fetch which is used by ports make when a distfile is not
 already around has had no means to make it use passive ftp mode
 by default has often caused me problems.
 So, I finally decided to add this feature analogous to the plain ftp client
 which uses the environment variable FTP_PASSIVE_MODE. Now my
 modified fetch also obeys this environment variable. Find the diffs
 attached. I hope everybody agrees this change would be a useful addition
 to the base distribution.
 
 -- 
         Cheers,
                 // jau
 .---  ..-  -.-  -.-  .-    .-  .-.-.-    ..-  -.-  -.-  ---  -.  .  -.
   /    Jukka A. Ukkonen,                            Mawit Ltd, Finland
  /__   M.Sc. (sw-eng & cs)                    (Phone) +358-500-606-671
    /   Internet: Jukka.Ukkonen(a)Mawit.Com      (Home) +358-9-6215-280
   /    Internet: ukkonen(a)nic.funet.fi
  v     Internet: jau(a)iki.fi
 
 + + + + My opinions are mine and mine alone, not my employers. + + + +
 
 
 
 
 
 --=_singer-16884-1064699869-0001-2
 Content-Type: application/octet-stream; name="fetch-passive.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="fetch-passive.patch"
 
 LS0tIGZldGNoLmMub3JpZwlGcmkgU2VwIDI2IDIzOjA3OjAyIDIwMDMKKysrIGZldGNoLmMJU3Vu
 IFNlcCAyOCAwMDozMjoyMiAyMDAzCkBAIC03MDMsNiArNzAzLDE1IEBACiAJY2hhciAqZW5kLCAq
 cTsKIAlpbnQgYywgZSwgcjsKIAorCXAgPSBnZXRlbnYgKCJGVFBfUEFTU0lWRV9NT0RFIik7CisK
 KwlpZiAoISBwIHx8ICEgc3RyY2FzZWNtcCAocCwgIk5PIikpIHsKKwkJcF9mbGFnID0gMDsKKwl9
 CisJZWxzZSB7CisJCXBfZmxhZyA9IDE7CisJfQorCiAJd2hpbGUgKChjID0gZ2V0b3B0KGFyZ2Ms
 IGFyZ3YsCiAJICAgICIxNDZBYUI6YmM6ZEZmOkhoOmxNbU46blBwbzpxUnJTOnNUOnRVdnc6Iikp
 ICE9IC0xKQogCQlzd2l0Y2ggKGMpIHsK
 
 --=_singer-16884-1064699869-0001-2--
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: ceri 
State-Changed-When: Wed Oct 1 13:52:01 PDT 2003 
State-Changed-Why:  
Could you please followup to this PR with either an inline patch, 
or uuencoded?  Thanks. 


Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Wed Oct 1 13:52:01 PDT 2003 
Responsible-Changed-Why:  
Reassign misfiled PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57297 
State-Changed-From-To: feedback->open 
State-Changed-By: ceri 
State-Changed-When: Thu Oct 2 02:32:21 PDT 2003 
State-Changed-Why:  
Feedback has been received. 


Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Thu Oct 2 02:32:21 PDT 2003 
Responsible-Changed-Why:  
Assign to the libfetch maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57297 

From: Ceri Davies <ceri@FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: bin/57297: Support for default passive ftp mode in fetch
Date: Thu, 2 Oct 2003 10:31:40 +0100

 --Qgof7w7UksPF5inF
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 
 Adding to audit trail
 
 
 --Qgof7w7UksPF5inF
 Content-Type: message/rfc822
 Content-Disposition: inline
 
 Return-path: <jau@mawit.com>
 Envelope-to: ceri@submonkey.net
 Delivery-date: Thu, 02 Oct 2003 10:15:58 +0100
 Received: from mx2.freebsd.org ([216.136.204.119])
 	by shrike.submonkey.net with esmtp (Exim 4.24; FreeBSD 4.9)
 	id 1A4zYl-0001ck-GP
 	for ceri@submonkey.net; Thu, 02 Oct 2003 10:15:43 +0100
 Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])
 	by mx2.freebsd.org (Postfix) with ESMTP id A4E6055CC7
 	for <ceri@submonkey.net>; Thu,  2 Oct 2003 02:15:42 -0700 (PDT)
 	(envelope-from jau@mawit.com)
 Received: by hub.freebsd.org (Postfix)
 	id A0BBE16A4BF; Thu,  2 Oct 2003 02:15:42 -0700 (PDT)
 Delivered-To: ceri@freebsd.org
 Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
 	by hub.freebsd.org (Postfix) with ESMTP
 	id 9E0A116A4B3; Thu,  2 Oct 2003 02:15:42 -0700 (PDT)
 Received: from mail.mawit.com (ip212-226-165-194.adsl.kpnqwest.fi [212.226.165.194])
 	by mx1.FreeBSD.org (Postfix) with ESMTP
 	id 1A5C443FBF; Thu,  2 Oct 2003 02:15:40 -0700 (PDT)
 	(envelope-from jau@mawit.com)
 Received: from mawit.com ([::ffff:127.0.0.1])
   by mail.mawit.com with esmtp; Thu, 02 Oct 2003 12:15:38 +0300
 Received: from 192.100.124.218
         (SquirrelMail authenticated user jau)
         by office.mawit.com with HTTP;
         Thu, 2 Oct 2003 12:15:38 +0300 (EEST)
 Message-ID: <5923.192.100.124.218.1065086138.squirrel@office.mawit.com>
 Date: Thu, 2 Oct 2003 12:15:38 +0300 (EEST)
 Subject: Re: bin/57297: Support for default passive ftp mode in fetch
 From: "Jukka A. Ukkonen" <jau@mawit.com>
 To: ceri@FreeBSD.org
 In-Reply-To: <200310012053.h91KrXMR076964@freefall.freebsd.org>
 References: <200310012053.h91KrXMR076964@freefall.freebsd.org>
 X-Priority: 3
 Importance: Normal
 X-MSMail-Priority: Normal
 Cc: jau@mawit.com, gnats-admin@FreeBSD.org, freebsd-bugs@FreeBSD.org
 X-Mailer: SquirrelMail (version 1.2.7)
 Mime-Version: 1.0
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: 7bit
 X-Mime-Autoconverted: from 8bit to 7bit by courier 0.37
 X-Spam-Level: 
 X-Spam-Checker-Version: SpamAssassin 2.60-rc3 (1.202-2003-08-29-exp) on 
 	shrike.private.submonkey.net
 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham 
 	version=2.60-rc3
 
 
 OK here is an attempt to copy the patch to X cut buffer using wxcopy,
 then via xcb to xclipboard, and then pasting it to the message body...
 
 --- fetch.c.orig	Fri Sep 26 23:07:02 2003
 +++ fetch.c	Sun Sep 28 00:32:22 2003
 @@ -703,6 +703,15 @@
  	char *end, *q;
  	int c, e, r;
 
 +	p = getenv ("FTP_PASSIVE_MODE");
 +
 +	if (! p || ! strcasecmp (p, "NO")) {
 +		p_flag = 0;
 +	}
 +	else {
 +		p_flag = 1;
 +	}
 +
  	while ((c = getopt(argc, argv,
  	    "146AaB:bc:dFf:Hh:lMmN:nPpo:qRrS:sT:tUvw:")) != -1)
  		switch (c) {
 
 I hope that all white space including tabs and simple \n line breaks
 survived the operation.
 
 -- 
         Cheers,
                 // jau
 .---  ..-  -.-  -.-  .-    .-  .-.-.-    ..-  -.-  -.-  ---  -.  .  -.
   /    Jukka A. Ukkonen,                            Mawit Ltd, Finland
  /__   M.Sc. (sw-eng & cs)                    (Phone) +358-500-606-671
    /   Internet: Jukka.Ukkonen(a)Mawit.Com      (Home) +358-9-6215-280
   /    Internet: ukkonen(a)nic.funet.fi
  v     Internet: jau(a)iki.fi
 
 + + + + My opinions are mine and mine alone, not my employers. + + + +
 
 
 Quoting Ceri Davies:
 > Synopsis: Support for default passive ftp mode in fetch
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: ceri
 > State-Changed-When: Wed Oct 1 13:52:01 PDT 2003
 > State-Changed-Why:
 > Could you please followup to this PR with either an inline patch,
 > or uuencoded?  Thanks.
 >
 >
 > Responsible-Changed-From-To: gnats-admin->freebsd-bugs
 > Responsible-Changed-By: ceri
 > Responsible-Changed-When: Wed Oct 1 13:52:01 PDT 2003
 > Responsible-Changed-Why:
 > Reassign misfiled PR.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=57297
 
 
 
 
 --Qgof7w7UksPF5inF--
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Thu Oct 2 05:39:20 PDT 2003 
State-Changed-Why:  
fetch already has this functionality, as documented in the fetch(3) man page. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57297 
>Unformatted:
