From andy@mx1.evo6.net  Sat Jul 19 22:25:00 2003
Return-Path: <andy@mx1.evo6.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F01C737B404
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Jul 2003 22:25:00 -0700 (PDT)
Received: from mx1.evo6.net (mx1.evo6.net [80.76.194.10])
	by mx1.FreeBSD.org (Postfix) with SMTP id 4FCEF43FCB
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Jul 2003 22:24:59 -0700 (PDT)
	(envelope-from andy@mx1.evo6.net)
Received: (qmail 85586 invoked by uid 1001); 20 Jul 2003 05:24:57 -0000
Message-Id: <20030720052457.68999.qmail@mx1.evo6.net>
Date: 20 Jul 2003 05:24:57 -0000
From: Andy Gilligan <andy@evo6.org>
Reply-To: Andy Gilligan <andy@evo6.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: stable@freebsd.org
Subject: [PATCH] ipfw2 fails with 'bad command' error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         54649
>Category:       bin
>Synopsis:       [PATCH] ipfw2 fails with 'bad command' error
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 19 22:30:13 PDT 2003
>Closed-Date:    Fri Jul 25 01:23:42 PDT 2003
>Last-Modified:  Fri Jul 25 01:23:42 PDT 2003
>Originator:     Andy Gilligan
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD vega 4.8-STABLE FreeBSD 4.8-STABLE #13: Sun Jul 20 01:01:07 BST 2003 root@vega:/usr/obj/usr/src/sys/VEGA i386

>Description:

	When using a program to preprocess rules, /sbin/ipfw will
	fail with a 'bad command' error if those rules contain any
	pipe or queue definitions.

	This only affects IPFW2.

>How-To-Repeat:

	Create /etc/ipfw.rules containing:

	pipe 1 config bw 500kbit/s
	add pipe 1 all from any to any

	Then execute:

	# ipfw -p cat /etc/ipfw.rules
	command is cat
	Line 2: bad command `pipe'

	Using any preprocessor that generates those rules will
	give the same error.

>Fix:

	Correctly initialise the 'do_pipe' variable in ipfw_main()

Index: sbin/ipfw/ipfw2.c
===================================================================
RCS file: /data/cvs/freebsd/src/sbin/ipfw/ipfw2.c,v
retrieving revision 1.4.2.16
diff -u -r1.4.2.16 ipfw2.c
--- sbin/ipfw/ipfw2.c	17 Jul 2003 06:03:39 -0000	1.4.2.16
+++ sbin/ipfw/ipfw2.c	20 Jul 2003 04:51:28 -0000
@@ -3591,6 +3591,7 @@
 	char **av, **save_av;
 	int do_acct = 0;		/* Show packet/byte count */
 	int do_force = 0;		/* Don't ask for confirmation */
+	do_pipe = 0;
 
 #define WHITESP		" \t\f\v\n\r"
 	if (oldac == 0)
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Mon Jul 21 02:57:11 PDT 2003 
State-Changed-Why:  
Fixed in -CURRENT, thanks! 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Mon Jul 21 02:57:11 PDT 2003 
Responsible-Changed-Why:  
I will MFC the fix in three days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54649 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Fri Jul 25 01:23:20 PDT 2003 
State-Changed-Why:  
Fixed in -STABLE too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=54649 
>Unformatted:
