From danfe@regency.nsu.ru  Tue Jul  1 10:16:56 2003
Return-Path: <danfe@regency.nsu.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E1B9737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Jul 2003 10:16:56 -0700 (PDT)
Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5DACC4400B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Jul 2003 10:16:55 -0700 (PDT)
	(envelope-from danfe@regency.nsu.ru)
Received: from mail by mx.nsu.ru with drweb-scanned (Exim 3.36 #1 (Debian))
	id 19XOtO-0005jj-00
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 02 Jul 2003 00:26:10 +0700
Received: from regency.nsu.ru ([193.124.210.26])
	by mx.nsu.ru with esmtp (Exim 3.36 #1 (Debian))
	id 19XOsp-0005b7-00
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 02 Jul 2003 00:25:35 +0700
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.8/8.12.8) with ESMTP id h61HGFBh056156
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 2 Jul 2003 00:16:15 +0700 (NOVST)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.8/8.12.8/Submit) id h61HGFjA056131;
	Wed, 2 Jul 2003 00:16:15 +0700 (NOVST)
Message-Id: <200307011716.h61HGFjA056131@regency.nsu.ru>
Date: Wed, 2 Jul 2003 00:16:15 +0700 (NOVST)
From: Alexey Dokuchaev <danfe@regency.nsu.ru>
Reply-To: Alexey Dokuchaev <danfe@regency.nsu.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [FIX] Better memory utilization in fstat(1)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         53980
>Category:       bin
>Synopsis:       [FIX] Better memory utilization in fstat(1)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 01 10:20:10 PDT 2003
>Closed-Date:    Tue Sep 23 09:46:31 PDT 2003
>Last-Modified:  Tue Sep 23 09:46:31 PDT 2003
>Originator:     Alexey Dokuchaev
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
CNIT NSU
>Environment:
System: FreeBSD cytherea.nsu.ru 5.1-CURRENT FreeBSD 5.1-CURRENT #6: Tue Jul 1 13:05:23 NOVT 2003 root@cytherea.nsu.ru:/usr/obj/usr/src/sys/CYTHEREA i386
>Description:
When stating vnode on msdosfs (insice msdosfs_filestat()), memory is
being allocated, but never released during function execution.  Thus, it
seems that when fstat(1) run on msdosfs with some huge files on it, quite
a few memory could be allocated and never free until end of fstat(1)
execution.  While this probably rather hard to reveal under normal
circumastances, freeing memory still seems like a good practice to me,
since generally one could not bother freeing memory in main() or some
other being-called-one-time function, but forgetting about free() in
repeatedly called function is not that fair anymore.
>How-To-Repeat:
N/A
>Fix:
Index: msdosfs.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/fstat/msdosfs.c,v
retrieving revision 1.7
diff -u -r1.7 msdosfs.c
--- msdosfs.c	24 Jun 2003 08:18:18 -0000	1.7
+++ msdosfs.c	1 Jul 2003 16:56:37 -0000
@@ -107,6 +107,7 @@
 			dprintf(stderr,
 			    "can't read mount info at %p for pid %d\n",
 			    (void *)denode.de_pmp, Pid);
+			free(mnt);
 			return 0;
 		}
 	}
@@ -147,5 +148,6 @@
 	}
 
 	fsp->fileid = fileid;
+	free(mnt);
 	return 1;
 }

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: fjoe 
State-Changed-When: Tue Sep 23 09:44:37 PDT 2003 
State-Changed-Why:  
Actually, dosmount entry should not be free'd on successful completion 
because it is cached. In case of errors dosmount entry should be free'd, 
and should not put to the cache. A fix is committed to the HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=53980 
>Unformatted:
