From dg@nexus.dglawrence.com  Wed May 28 02:57:06 2003
Return-Path: <dg@nexus.dglawrence.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 934CD37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 28 May 2003 02:57:06 -0700 (PDT)
Received: from dglawrence.com (12-224-163-157.client.attbi.com [12.224.163.157])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D848E43FAF
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 28 May 2003 02:57:05 -0700 (PDT)
	(envelope-from dg@nexus.dglawrence.com)
Received: from nexus.dglawrence.com (localhost [127.0.0.1])
	by dglawrence.com (8.12.9/8.12.6) with ESMTP id h4S9vLFu007842
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 28 May 2003 02:57:21 -0700 (PDT)
	(envelope-from dg@nexus.dglawrence.com)
Received: (from dg@localhost)
	by nexus.dglawrence.com (8.12.9/8.12.3/Submit) id h4S9vLjq007841;
	Wed, 28 May 2003 02:57:21 -0700 (PDT)
Message-Id: <200305280957.h4S9vLjq007841@nexus.dglawrence.com>
Date: Wed, 28 May 2003 02:57:21 -0700 (PDT)
From: David Greenman-Lawrence <dg@dglawrence.com>
Reply-To: David Greenman-Lawrence <dg@dglawrence.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: formatting of RTT wrong in traceroute6
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         52750
>Category:       bin
>Synopsis:       formatting of RTT wrong in traceroute6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 28 03:00:25 PDT 2003
>Closed-Date:    Tue Jul 29 05:26:39 PDT 2003
>Last-Modified:  Tue Jul 29 05:26:39 PDT 2003
>Originator:     David G. Lawrence
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Download Technologies, Inc.
>Environment:
System: FreeBSD nexus.dglawrence.com 4.8-STABLE FreeBSD 4.8-STABLE #0: Tue Apr 29 08:52:57 PDT 2003 dg@nexus.dglawrence.com:/a/src/sys/compile/NEXUS i386


	
>Description:
The output format specifier for the round-trip time in traceroute6 should be
changed to %.3f instead of %g since %g doesn't accurately represent the
precision of the number being output. In particular, %g truncates trailing
zeroes. 0.01 ms does not mean the same thing as 0.010 ms. Although they
are numerically identical, they do not have the same precision. This was
fixed by me in IPv4 traceroute in rev 1.2, almost 9 years ago.
See also PR 52324 for the same problem in ping6.

	
>How-To-Repeat:
Use IPv6 and traceroute6 a host. Notice occasional truncated precision when
the RTT ends in one or more zeroes.
>Fix:

Index: traceroute6.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/traceroute6/traceroute6.c,v
retrieving revision 1.4.2.4
diff -c -r1.4.2.4 traceroute6.c
*** traceroute6.c	3 Jul 2001 11:02:18 -0000	1.4.2.4
--- traceroute6.c	28 May 2003 09:45:33 -0000
***************
*** 867,873 ****
  						print(&rcvmhdr, cc);
  						lastaddr = Rcv.sin6_addr;
  					}
! 					Printf("  %g ms", deltaT(&t1, &t2));
  					switch(i - 1) {
  					case ICMP6_DST_UNREACH_NOROUTE:
  						++unreachable;
--- 867,873 ----
  						print(&rcvmhdr, cc);
  						lastaddr = Rcv.sin6_addr;
  					}
! 					Printf("  %.3f ms", deltaT(&t1, &t2));
  					switch(i - 1) {
  					case ICMP6_DST_UNREACH_NOROUTE:
  						++unreachable;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Mon Jul 21 04:24:33 PDT 2003 
State-Changed-Why:  
Fixed in -CURRENT, thanks. 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Mon Jul 21 04:24:33 PDT 2003 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52750 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Tue Jul 29 05:25:58 PDT 2003 
State-Changed-Why:  
Fixed in -STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=52750 
>Unformatted:
