From nakaji@xa12.heimat.gr.jp  Thu May  1 04:57:08 2003
Return-Path: <nakaji@xa12.heimat.gr.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D37837B401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 May 2003 04:57:08 -0700 (PDT)
Received: from pcat.heimat.gr.jp (catv-129-243.tees.ne.jp [202.216.129.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CBB1A43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 May 2003 04:57:06 -0700 (PDT)
	(envelope-from nakaji@xa12.heimat.gr.jp)
Received: from xa12.heimat.gr.jp (xa12.heimat.gr.jp [202.216.136.35])
	by pcat.heimat.gr.jp (8.12.9/8.12.9) with ESMTP id h41Bv3tV061434
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 May 2003 20:57:03 +0900 (JST)
	(envelope-from nakaji@xa12.heimat.gr.jp)
Received: from xa12.heimat.gr.jp (localhost [127.0.0.1])
	by xa12.heimat.gr.jp (8.12.9/8.12.9) with ESMTP id h41Bv1qh014313
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 May 2003 20:57:01 +0900 (JST)
	(envelope-from nakaji@xa12.heimat.gr.jp)
Received: (from nakaji@localhost)
	by xa12.heimat.gr.jp (8.12.9/8.12.9/Submit) id h41Bv1d9014312;
	Thu, 1 May 2003 20:57:01 +0900 (JST)
Message-Id: <200305011157.h41Bv1d9014312@xa12.heimat.gr.jp>
Date: Thu, 1 May 2003 20:57:01 +0900 (JST)
From: NAKAJI Hiroyuki <nakaji@jp.freebsd.org>
Reply-To: NAKAJI Hiroyuki <nakaji@jp.freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: savecore needs ${dumpdev} as an argument when it is set
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51655
>Category:       bin
>Synopsis:       savecore needs ${dumpdev} as an argument when it is set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 01 05:00:28 PDT 2003
>Closed-Date:    Thu Mar 18 07:25:00 PST 2004
>Last-Modified:  Thu Mar 18 07:25:00 PST 2004
>Originator:     NAKAJI Hiroyuki
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD xa12.heimat.gr.jp 5.0-CURRENT FreeBSD 5.0-CURRENT #19: Thu May 1 10:50:26 JST 2003 root@xa12.heimat.gr.jp:/usr/obj/usr/src/sys/NAKAJI i386


>Description:
	/etc/rc.d/savecore is executed when ${dumpdev} is set in
/etc/rc.conf. And savecore is invoked from /etc/rc.d/savecore without
${dumpdev}. But no vmcore.0 is available after panic if ${dumpdev} is
not same as the first swap partition.

>How-To-Repeat:

In /etc/rc.conf two parameters are set:
dumpdev="/dev/ad1s1e"
dumpdir="/home/crash" # my /var is short

$ sudo savecore /home/crash 
checking for kernel dump on device /dev/da2s1b
mediasize = 209715200
sectorsize = 512
magic mismatch on last dump header on /dev/da2s1b
savecore: no dumps found

where /dev/da2s1b is the first swap partition set in /etc/fstab.

>Fix:

Index: savecore
===================================================================
RCS file: /net/pcat/home/ncvs/src/etc/rc.d/savecore,v
retrieving revision 1.3
diff -u -u -r1.3 savecore
--- savecore	6 Sep 2002 16:18:05 -0000	1.3
+++ savecore	1 May 2003 11:43:23 -0000
@@ -67,7 +67,7 @@
 savecore_start()
 {
 		echo "Checking for core dump..."
-		savecore ${savecore_flags} ${DUMPDIR}
+		savecore ${savecore_flags} ${DUMPDIR} ${dumpdev}
 }
 
 load_rc_config $name
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: davidc 
State-Changed-When: Thu Mar 18 07:21:08 PST 2004 
State-Changed-Why:  
Commited a fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51655 
>Unformatted:
Applied similar patch.
