From stephen@cauchy.math.missouri.edu  Sun Mar 30 11:57:33 2003
Return-Path: <stephen@cauchy.math.missouri.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 38DCC37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2003 11:57:33 -0800 (PST)
Received: from cauchy.math.missouri.edu (cauchy.math.missouri.edu [128.206.49.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8945843FAF
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2003 11:57:32 -0800 (PST)
	(envelope-from stephen@cauchy.math.missouri.edu)
Received: from cauchy.math.missouri.edu (stephen@localhost [127.0.0.1])
	by cauchy.math.missouri.edu (8.12.8/8.12.8) with ESMTP id h2UJv7vC085335
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Mar 2003 13:57:07 -0600 (CST)
	(envelope-from stephen@cauchy.math.missouri.edu)
Received: (from stephen@localhost)
	by cauchy.math.missouri.edu (8.12.8/8.12.8/Submit) id h2UJv7rv085334;
	Sun, 30 Mar 2003 13:57:07 -0600 (CST)
	(envelope-from stephen)
Message-Id: <200303301957.h2UJv7rv085334@cauchy.math.missouri.edu>
Date: Sun, 30 Mar 2003 13:57:07 -0600 (CST)
From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
Reply-To: Stephen Montgomery-Smith <stephen@cauchy.math.missouri.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ctm cannot handle the large files currently created.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50461
>Category:       bin
>Synopsis:       ctm cannot handle the large files currently created.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 30 12:00:23 PST 2003
>Closed-Date:    Sun Feb 08 10:30:13 PST 2004
>Last-Modified:  Sun Feb 08 10:30:13 PST 2004
>Originator:     Stephen Montgomery-Smith
>Release:        FreeBSD 4.8-RC i386
>Organization:
>Environment:
System: FreeBSD cauchy 4.8-RC FreeBSD 4.8-RC #0: Fri Mar 21 10:46:19 CST 2003 stephen@cauchy:/usr/obj/usr/src/sys/cauchy i386


	
>Description:

ctm cannot handle the large files that have been recently created.

>How-To-Repeat:
Find an empty directory.

Download cvs-cur.9100xEmpty.gz from one of the FreeBSD mirrors (look in the
directory CTM).  Put this into the empty directory and cd to that directory.

ctm cvs-cur.9100xEmpty.gz

>Fix:

There is a test for MAXSIZE in ctm.h.  MAXSIZE is currently too small.  But
actually it seems that MAXSIZE really has very little purpose, so it seems
better to simply remove the test.

diff -ur /usr/src/usr.sbin/ctm/ctm/ctm.h ctm/ctm/ctm.h
--- /usr/src/usr.sbin/ctm/ctm/ctm.h	Mon Mar  3 15:32:15 2003
+++ ctm/ctm/ctm.h	Sat Mar 29 11:17:51 2003
@@ -26,7 +26,6 @@
 #include <sys/time.h>
 
 #define VERSION "2.0"
-#define MAXSIZE (1024*1024*40)
 
 #define SUBSUFF ".ctm"
 #define TMPSUFF ".ctmtmp"
diff -ur /usr/src/usr.sbin/ctm/ctm/ctm_input.c ctm/ctm/ctm_input.c
--- /usr/src/usr.sbin/ctm/ctm/ctm_input.c	Mon Mar  3 15:32:15 2003
+++ ctm/ctm/ctm_input.c	Sat Mar 29 11:18:52 2003
@@ -77,10 +77,6 @@
 	u_chars *= 10;
 	u_chars += (*q - '0');
     }
-    if(u_chars > MAXSIZE) {
-	Fatal("Bytecount too large.");
-	return -1;
-    }
     return u_chars;
 }
 


>Release-Note:
>Audit-Trail:

From: "Julian Stacey" <jhs@berklix.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc: stephen@cauchy.math.missouri.edu
Subject: Re: bin/50461: ctm cannot handle the large files currently created.
Date: Tue, 1 Apr 2003 03:59:10 +0200 (CEST)

 ] There is a test for MAXSIZE in ctm.h.  MAXSIZE is currently too small.  But
 ] actually it seems that MAXSIZE really has very little purpose, so it seems
 ] better to simply remove the test.
 
 I emailed Stephen (PR originator):
 > If anything ever breaks & goes berserk, we'll be a lot more grateful
 > with a limit of 5M 10M or whatever, rather than 1G, lots of people
 > pay money for 1G , & some /var inc. all mine would explode :-)
 
 & Stephen wrote back:
 > Point taken.  
 > Perhaps you could send a message to this effect as a follow up to my PR:
 
 Stephen generates the deltas, he'd best decide the limit, but for info:
 cvs-cur.9039.gz was 29M BTW
 
 Julian Stacey       Freelance Systems Engineer, Unix & Net Consultant, Munich.
   Ihr Rauchen => mein allergischer Kopfschmerz !   Schnupftabak probieren.

From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
To: freebsd-gnats-submit@FreeBSD.org,
	stephen@cauchy.math.missouri.edu, jhs@berklix.com
Cc:  
Subject: Re: bin/50461: ctm cannot handle the large files currently created.
Date: Mon, 31 Mar 2003 20:31:15 -0600

 The file cvs-cur.9100xEmpty.gz is about 1/2 GB right now.  I think that a good 
 value for MAXSIZE that will last for a few more years is (1024*1024*100).
 
 -- 
 Stephen Montgomery-Smith
 stephen@math.missouri.edu
 http://www.math.missouri.edu/~stephen
 

From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
To: freebsd-gnats-submit@FreeBSD.org,
	stephen@cauchy.math.missouri.edu
Cc:  
Subject: Re: bin/50461: ctm cannot handle the large files currently created.
Date: Wed, 02 Apr 2003 20:53:31 -0600

 I have had an email exchange with Julian Stacey.  It seems that we both made a 
 mistake - he thougt the MAXSIZE refered to ctm_rmail/ctm_smail, and I thought 
 that a MAXSIZE might prevent the kinds of errors he was refering to in another way.
 
 The upshot of all this is I think that the original patch I proposed (that is 
 removing all references to MAXSIZE in ctm) is the best way to proceed.
 
 -- 
 Stephen Montgomery-Smith
 stephen@math.missouri.edu
 http://www.math.missouri.edu/~stephen
 

From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
To: freebsd-gnats-submit@FreeBSD.org,
	stephen@cauchy.math.missouri.edu
Cc:  
Subject: Re: bin/50461: ctm cannot handle the large files currently created.
Date: Sun, 08 Feb 2004 10:39:45 -0600

 This PR has been committed, but it is still open.  So I guess that this PR 
 should be closed.
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Feb 8 10:29:43 PST 2004 
State-Changed-Why:  
Submitter reports that a fix has already been committed elsewhere. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50461 
>Unformatted:
