From juser@kyon.de  Wed Mar  5 17:11:28 2003
Return-Path: <juser@kyon.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E1D6C37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Mar 2003 17:11:28 -0800 (PST)
Received: from jcour.kyon.de (www.ky-on.de [213.9.98.91])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9045243FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Mar 2003 17:11:27 -0800 (PST)
	(envelope-from juser@kyon.de)
Received: from kyon.de (jcour.kyon.de [10.0.2.4])
  by jcour.kyon.de with esmtp; Thu, 06 Mar 2003 02:11:26 +0100
Received: (from root@localhost)
	by kyon.de (8.12.6/8.12.6/Submit) id h261BPcT030799;
	Thu, 6 Mar 2003 02:11:25 +0100 (CET)
	(envelope-from juser)
Message-Id: <200303060111.h261BPcT030799@kyon.de>
Date: Thu, 6 Mar 2003 02:11:25 +0100 (CET)
From: till toenges <tt@mail.isis.de>
To: FreeBSD-gnats-submit@freebsd.org
Subject: bdes.c args to err() in wrong order
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48963
>Category:       bin
>Synopsis:       bdes.c args to err() in wrong order
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 05 17:20:13 PST 2003
>Closed-Date:    Fri Mar 07 08:01:55 PST 2003
>Last-Modified:  Fri Mar 07 08:01:55 PST 2003
>Originator:     jail user
>Release:        FreeBSD 4.7-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD hoellenmaschine.kyon.de 4.7-RELEASE-p3 FreeBSD 4.7-RELEASE-p3 #2: Tue Feb 4 01:34:59 CET 2003 juser@hoellenmaschine.kyon.de:/usr/obj/usr/src/sys/MYKERNEL i386


	
>Description:
the function is defined as

err(n, s)
        int n;                  /* offending block number */
        char *s;                /* the message */
	
but is called with char *, int in some macros.

>How-To-Repeat:
look at the source. 

>Fix:


--- bdes.diff begins here ---
--- /usr/src/secure/usr.bin/bdes/bdes.c	Fri Sep 22 11:42:03 2000
+++ bdes.c	Thu Mar  6 01:42:08 2003
@@ -102,22 +102,22 @@
 #ifdef	FASTWAY
 #define	DES_KEY(buf) \
 	if (des_setkey(buf)) \
-		err("des_setkey", 0);
+		err(0, "des_setkey");
 #define	DES_XFORM(buf) \
 	if (des_cipher(buf, buf, 0L, (inverse ? -1 : 1))) \
-		err("des_cipher", 0);
+		err(0, "des_cipher");
 #else
 #define	DES_KEY(buf)	{						\
 				char bits1[64];	/* bits of key */	\
 				expand(buf, bits1);			\
 				if (setkey(bits1))			\
-					err("setkey", 0);		\
+					err(0, "setkey");		\
 			}
 #define	DES_XFORM(buf)	{						\
 				char bits1[64];	/* bits of message */	\
 				expand(buf, bits1);			\
 				if (encrypt(bits1, inverse))		\
-					err("encrypt", 0);		\
+					err(0, "encrypt");		\
 				compress(bits1, buf);			\
 			}
 #endif
--- bdes.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mtm 
State-Changed-When: Fri Mar 7 08:01:28 PST 2003 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48963 
>Unformatted:
