From stefan@fafoe.dyndns.org  Fri Feb 28 13:48:10 2003
Return-Path: <stefan@fafoe.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3669237B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Feb 2003 13:48:10 -0800 (PST)
Received: from fafoe.dyndns.org (chello212186121237.14.vie.surfer.at [212.186.121.237])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7B91643FA3
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Feb 2003 13:48:09 -0800 (PST)
	(envelope-from stefan@fafoe.dyndns.org)
Received: from frog.fafoe (frog.fafoe [192.168.2.101])
	by fafoe.dyndns.org (Postfix) with ESMTP
	id C0B354066; Fri, 28 Feb 2003 22:48:07 +0100 (CET)
Received: by frog.fafoe (Postfix, from userid 1001)
	id 3A490848; Fri, 28 Feb 2003 22:48:07 +0100 (CET)
Message-Id: <20030228214807.3A490848@frog.fafoe>
Date: Fri, 28 Feb 2003 22:48:07 +0100 (CET)
From: Stefan Farfeleder <stefan@fafoe.dyndns.org>
Reply-To: Stefan Farfeleder <stefan@fafoe.dyndns.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: stefan@fafoe.dyndns.org
Subject: [patch] small fix for apmd(8)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48793
>Category:       bin
>Synopsis:       [patch] small fix for apmd(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 28 13:50:10 PST 2003
>Closed-Date:    Mon Jun 30 05:04:53 PDT 2003
>Last-Modified:  Mon Jun 30 05:04:53 PDT 2003
>Originator:     Stefan Farfeleder
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD frog.fafoe 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Fri Feb 28 12:02:34 CET 2003 freebsd@frog.fafoe:/freebsd/frog/obj/freebsd/frog/src/sys/FROG i386


	
>Description:
The BATTTIME and BATTPERCENT tokens of apmdparse.y use the int member
'i' of the yylval union, not 'str'.  An integer is assigned to yylval.i
in apmdlex.l and non-terminal apm_battery_level has type int too.
	
>How-To-Repeat:
buildworld produces these warnings:

	===> usr.sbin/apmd
	cc -O -pipe -mcpu=pentiumpro -I. -I/freebsd/frog/src/usr.sbin/apmd    -c /freebsd/frog/src/usr.sbin/apmd/apmd.c
	gzip -cn /freebsd/frog/src/usr.sbin/apmd/apmd.8 > apmd.8.gz
	cc -O -pipe -mcpu=pentiumpro -I. -I/freebsd/frog/src/usr.sbin/apmd    -c apmdparse.c
	cc -O -pipe -mcpu=pentiumpro -I. -I/freebsd/frog/src/usr.sbin/apmd    -c apmdlex.c
	/freebsd/frog/src/usr.sbin/apmd/apmdparse.y: In function `yyparse':
	/freebsd/frog/src/usr.sbin/apmd/apmdparse.y:101: warning: assignment makes integer from pointer without a cast
	/freebsd/frog/src/usr.sbin/apmd/apmdparse.y:105: warning: assignment makes integer from pointer without a cast
	cc -O -pipe -mcpu=pentiumpro -I. -I/freebsd/frog/src/usr.sbin/apmd     -o apmd apmd.o apmdlex.o apmdparse.o -ll
	
>Fix:

	

--- apmd.diff begins here ---
Index: src/usr.sbin/apmd/apmdparse.y
===================================================================
RCS file: /usr/home/ncvs/src/usr.sbin/apmd/apmdparse.y,v
retrieving revision 1.3
diff -u -r1.3 apmdparse.y
--- src/usr.sbin/apmd/apmdparse.y	15 May 2001 05:13:45 -0000	1.3
+++ src/usr.sbin/apmd/apmdparse.y	28 Feb 2003 01:53:46 -0000
@@ -56,7 +56,7 @@
 %token APMEVENT
 %token APMBATT
 %token BATTCHARGE BATTDISCHARGE
-%token <str> BATTTIME BATTPERCENT
+%token <i> BATTTIME BATTPERCENT
 %token EXECCMD REJECTCMD
 %token <ev> EVENT
 %token <str> STRING UNKNOWN
--- apmd.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 16 07:59:03 PDT 2003 
State-Changed-Why:  
Fixed in -CURRENT, thanks! 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Mon Jun 16 07:59:03 PDT 2003 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48793 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 30 05:04:30 PDT 2003 
State-Changed-Why:  
Fixed in -STABLE as well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48793 
>Unformatted:
