From alan@agora.rdrop.com  Tue Feb 18 13:56:12 2003
Return-Path: <alan@agora.rdrop.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3C42637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Feb 2003 13:56:12 -0800 (PST)
Received: from agora.rdrop.com (agora.rdrop.com [199.26.172.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B520443F93
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Feb 2003 13:56:11 -0800 (PST)
	(envelope-from alan@agora.rdrop.com)
Received: from agora.rdrop.com (202@localhost [127.0.0.1])
	by agora.rdrop.com (8.12.7/8.12.5) with ESMTP id h1ILuBpj066190
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Feb 2003 13:56:11 -0800 (PST)
	(envelope-from alan@agora.rdrop.com)
Received: (from alan@localhost)
	by agora.rdrop.com (8.12.7/8.12.6/Submit) id h1ILuBLt066189;
	Tue, 18 Feb 2003 13:56:11 -0800 (PST)
Message-Id: <200302182156.h1ILuBLt066189@agora.rdrop.com>
Date: Tue, 18 Feb 2003 13:56:11 -0800 (PST)
From: Alan Batie <alan@agora.rdrop.com>
Reply-To: Alan Batie <alan@agora.rdrop.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: /usr/sbin/periodic executes too many files
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48443
>Category:       bin
>Synopsis:       [patch] periodic(8) executes too many files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 18 14:00:26 PST 2003
>Closed-Date:    
>Last-Modified:  Wed Jul  3 21:30:01 UTC 2013
>Originator:     Alan Batie
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
RainDrop Laboratories
>Environment:
System: FreeBSD agora.rdrop.com 4.7-STABLE FreeBSD 4.7-STABLE #0: Mon Feb 3 00:57:16 PST 2003 root@agora.rdrop.com:/usr/src/freebsd/src/sys/compile/AGORA i386


>Description:
	I was adding some functionality to the kernel message security
	check, and in the debugging process found that the extra script
	I added was getting executed independently.  Further investigation
	found that /usr/sbin/periodic runs $dir/*.  Since the file
	security_functions already exists in /etc/periodic/security as a
	file to be sourced, rather than executed standalone, this is
	apparently not correct behavior.  I believe the intention is to
	execute $dir/[0-9]*.

>How-To-Repeat:
	Create a file 'xyzzy' in /etc/periodic/security containing

	    echo xyzzy

	then run "/usr/sbin/periodic security"

>Fix:


Index: periodic.sh
===================================================================
RCS file: /home/ncvs/src/usr.sbin/periodic/periodic.sh,v
retrieving revision 1.9.2.8
diff -c -r1.9.2.8 periodic.sh
*** periodic.sh	21 May 2002 03:09:35 -0000	1.9.2.8
--- periodic.sh	18 Feb 2003 21:48:00 -0000
***************
*** 72,78 ****
          processed=0
          for dir in $dirlist
          do
!             for file in $dir/*
              do
                  if [ -x $file -a ! -d $file ]
                  then
--- 72,78 ----
          processed=0
          for dir in $dirlist
          do
!             for file in $dir/[0-9]*
              do
                  if [ -x $file -a ! -d $file ]
                  then

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mtm 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Sat Dec 27 09:23:50 PST 2003 
Responsible-Changed-Why:  
Assign to Mike; this patch looks correct. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48443 
State-Changed-From-To: open->open 
State-Changed-By: linimon 
State-Changed-When: Wed Jul 3 00:50:32 UTC 2013 
State-Changed-Why:  
commit bit has been taken in for safekeeping. 


Responsible-Changed-From-To: mtm->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jul 3 00:50:32 UTC 2013 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=48443 

From: Jason Unovitch <jason.unovitch@gmail.com>
To: bug-followup@FreeBSD.org, alan@agora.rdrop.com
Cc:  
Subject: Re: bin/48443: [patch] periodic(8) executes too many files
Date: Wed, 03 Jul 2013 17:20:13 -0400

 This is a cryptographically signed message in MIME format.
 
 --------------ms010702060706060604000000
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: quoted-printable
 
 Per `man periodic`, the current behaviour today still matches matches=20
 the behaviour of /usr/sbin/periodic when this PR was submitted.  While=20
 it does appear to be convention, not all periodic scripts have prefixed=20
 numbers.  An example port impacted would be sysutils/smartmontools,=20
 which installs /usr/local/etc/periodic/daily/smart for it's daily runs.  =
 
 Making this change would affect that programs periodic runs.
 
 man periodic
       The periodic utility will run each executable file in the directory=
  or
       directories specified.  If a file does not have the executable bit =
 
 set,
       it is silently ignored.
 
 Respectfully,
 Jason Unovitch
 
 
 --------------ms010702060706060604000000
 Content-Type: application/pkcs7-signature; name="smime.p7s"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="smime.p7s"
 Content-Description: S/MIME Cryptographic Signature
 
 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKVDCC
 BRowggQCoAMCAQICEG0Z6qcZT2ozIuYiMnqqcd4wDQYJKoZIhvcNAQEFBQAwga4xCzAJBgNV
 BAYTAlVTMQswCQYDVQQIEwJVVDEXMBUGA1UEBxMOU2FsdCBMYWtlIENpdHkxHjAcBgNVBAoT
 FVRoZSBVU0VSVFJVU1QgTmV0d29yazEhMB8GA1UECxMYaHR0cDovL3d3dy51c2VydHJ1c3Qu
 Y29tMTYwNAYDVQQDEy1VVE4tVVNFUkZpcnN0LUNsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQg
 RW1haWwwHhcNMTEwNDI4MDAwMDAwWhcNMjAwNTMwMTA0ODM4WjCBkzELMAkGA1UEBhMCR0Ix
 GzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UE
 ChMRQ09NT0RPIENBIExpbWl0ZWQxOTA3BgNVBAMTMENPTU9ETyBDbGllbnQgQXV0aGVudGlj
 YXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC
 ggEBAJKEhFtLV5jUXi+LpOFAyKNTWF9mZfEyTvefMn1V0HhMVbdClOD5J3EHxcZppLkyxPFA
 GpDMJ1Zifxe1cWmu5SAb5MtjXmDKokH2auGj/7jfH0htZUOMKi4rYzh337EXrMLaggLW1DJq
 1GdvIBOPXDX65VSAr9hxCh03CgJQU2yVHakQFLSZlVkSMf8JotJM3FLb3uJAAVtIaN3FSrTg
 7SQfOq9xXwfjrL8UO7AlcWg99A/WF1hGFYE8aIuLgw9teiFX5jSw2zJ+40rhpVJyZCaRTqWS
 D//gsWD9Gm9oUZljjRqLpcxCm5t9ImPTqaD8zp6Q30QZ9FxbNboW86eb/8ECAwEAAaOCAUsw
 ggFHMB8GA1UdIwQYMBaAFImCZ33EnSZwAEu0UEh83j2uBG59MB0GA1UdDgQWBBR6E04AdFvG
 eGNkJ8Ev4qBbvHnFezAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB/wIBADARBgNV
 HSAECjAIMAYGBFUdIAAwWAYDVR0fBFEwTzBNoEugSYZHaHR0cDovL2NybC51c2VydHJ1c3Qu
 Y29tL1VUTi1VU0VSRmlyc3QtQ2xpZW50QXV0aGVudGljYXRpb25hbmRFbWFpbC5jcmwwdAYI
 KwYBBQUHAQEEaDBmMD0GCCsGAQUFBzAChjFodHRwOi8vY3J0LnVzZXJ0cnVzdC5jb20vVVRO
 QWRkVHJ1c3RDbGllbnRfQ0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1
 c3QuY29tMA0GCSqGSIb3DQEBBQUAA4IBAQCF1r54V1VtM39EUv5C1QaoAQOAivsNsv1Kv/av
 QUn1G1rF0q0bc24+6SZ85kyYwTAo38v7QjyhJT4KddbQPTmGZtGhm7VNm2+vKGwdr+XqdFqo
 2rHA8XV6L566k3nK/uKRHlZ0sviN0+BDchvtj/1gOSBH+4uvOmVIPJg9pSW/ve9g4EnlFsjr
 P0OD8ODuDcHTzTNfm9C9YGqzO/761Mk6PB/tm/+bSTO+Qik5g+4zaS6CnUVNqGnagBsePdIa
 XXxHmaWbCG0SmYbWXVcHG6cwvktJRLiQfsrReTjrtDP6oDpdJlieYVUYtCHVmdXgQ0BCML7q
 peeU0rD+83X5f27nMIIFMjCCBBqgAwIBAgIRANpYFAa4K3v/RFGj7CcJ1kowDQYJKoZIhvcN
 AQEFBQAwgZMxCzAJBgNVBAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAO
 BgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMTkwNwYDVQQDEzBD
 T01PRE8gQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0EwHhcNMTMw
 NTI4MDAwMDAwWhcNMTQwNTI4MjM1OTU5WjApMScwJQYJKoZIhvcNAQkBFhhqYXNvbi51bm92
 aXRjaEBnbWFpbC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCyPmlErSTr
 hOKET4lTn5vhwjPW3yF8UdzLFZC1GJNB2kz3D43AehkoWniMxJPdWeZJPvlswX7j7GJEIlB7
 x+HjlmFRF9khFMNWOuz2KbBsv2J7EjMepI9XKtLStJ2L4KNS37xM9hConf5gowPG5fJUk4+b
 Et2cZTXi8h3FkPr8kS6aFNN7JOaVnbOdTFicMIzN8B65lOrE1nk393x5975R1quaVM/lopgZ
 ukGW768uwb/hnc3inIshgJ2KSvVe+L7jTa0TfcHeoLsAebZzN0MDO5s9fgHfv33TMk+hMxf3
 NwRJVGdVq/wNixL9VsFzJ+dPifQ8ENWDqsbxy6aggwwhAgMBAAGjggHoMIIB5DAfBgNVHSME
 GDAWgBR6E04AdFvGeGNkJ8Ev4qBbvHnFezAdBgNVHQ4EFgQU7MgMQO0VsBYBsYVXsVKy4bhx
 +2UwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwIAYDVR0lBBkwFwYIKwYBBQUHAwQG
 CysGAQQBsjEBAwUCMBEGCWCGSAGG+EIBAQQEAwIFIDBGBgNVHSAEPzA9MDsGDCsGAQQBsjEB
 AgEBATArMCkGCCsGAQUFBwIBFh1odHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBXBgNV
 HR8EUDBOMEygSqBIhkZodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9DbGllbnRBdXRo
 ZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3JsMIGIBggrBgEFBQcBAQR8MHowUgYIKwYB
 BQUHMAKGRmh0dHA6Ly9jcnQuY29tb2RvY2EuY29tL0NPTU9ET0NsaWVudEF1dGhlbnRpY2F0
 aW9uYW5kU2VjdXJlRW1haWxDQS5jcnQwJAYIKwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9k
 b2NhLmNvbTAjBgNVHREEHDAagRhqYXNvbi51bm92aXRjaEBnbWFpbC5jb20wDQYJKoZIhvcN
 AQEFBQADggEBAHkDqUErHcIxgm2GQtFY7ccGNwG4DmqisSfsEdA/E8LSPRGLVrDek40TiCfR
 2Sz9C/j+y+RIUFPySQGEspkFdmTJaVlMCDoOnZvVLUKcQmq3Ju3zpn6ODt/y+wBnKFDGqEtx
 60QGUt5RZN/Yk/xopoOh2COybLu+aM/ZdAof/BYR4xywhKo9YzV/+3QK0sN6YBZkh7K6H/GD
 q+eayU1D5YyLPw0LkGPnMb1nsxJ4fAZtMgvzg2RAfbxTmWfe6MpR6V4vZzuSev0evtCV/8zi
 STS5LUqaEhYdzdDNwdk44VaF7kYNKLg44xO6aWO1iGp5TqCcJ0tw/Aq4/zLNWI8cVJ0xggQc
 MIIEGAIBATCBqTCBkzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3Rl
 cjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQxOTA3BgNV
 BAMTMENPTU9ETyBDbGllbnQgQXV0aGVudGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIR
 ANpYFAa4K3v/RFGj7CcJ1kowCQYFKw4DAhoFAKCCAkcwGAYJKoZIhvcNAQkDMQsGCSqGSIb3
 DQEHATAcBgkqhkiG9w0BCQUxDxcNMTMwNzAzMjEyMDEzWjAjBgkqhkiG9w0BCQQxFgQU4AgA
 ZDrBtGxbvPjczsxPyGV06pkwbAYJKoZIhvcNAQkPMV8wXTALBglghkgBZQMEASowCwYJYIZI
 AWUDBAECMAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMCAgIAgDANBggqhkiG9w0DAgIBQDAHBgUr
 DgMCBzANBggqhkiG9w0DAgIBKDCBugYJKwYBBAGCNxAEMYGsMIGpMIGTMQswCQYDVQQGEwJH
 QjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRowGAYD
 VQQKExFDT01PRE8gQ0EgTGltaXRlZDE5MDcGA1UEAxMwQ09NT0RPIENsaWVudCBBdXRoZW50
 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA2lgUBrgre/9EUaPsJwnWSjCBvAYLKoZI
 hvcNAQkQAgsxgayggakwgZMxCzAJBgNVBAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNo
 ZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMTkw
 NwYDVQQDEzBDT01PRE8gQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwg
 Q0ECEQDaWBQGuCt7/0RRo+wnCdZKMA0GCSqGSIb3DQEBAQUABIIBAHg3AVc/0ETIAwhTmDGz
 Zd6/D+E8NASj/1hGg0qKr5O7/g44u7N+f1obfQ3YfNfxgC6Hz/3SnXYUEfWebzivSgDjAHad
 cHocKZGwSyBrylk7rCAkLLtOStb7yyQmRlgn53NI9CljQfN7q7+LU8+Rjk/YfYvKIFLkEUWm
 zULvayUicYvgRSulMBhdGelSaYin6myv0wYvmog8LCzBtAi8Dl9EsrXRQdOBhZd3yUIVEC9C
 0rDDplnmoqW00Y6ige+dsz8WjCXs7OKGFrMy/283ZnWaezV35mWVh4rg7SvG3WPIBwEsFvI3
 v5wAdWCgpXXBwbzrczCY+Utgw0dureb3MDwAAAAAAAA=
 --------------ms010702060706060604000000--
>Unformatted:
