From simon@arthur.nitro.dk  Sun Jan  5 08:13:36 2003
Return-Path: <simon@arthur.nitro.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3A30337B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  5 Jan 2003 08:13:36 -0800 (PST)
Received: from arthur.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5E10C43EC5
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  5 Jan 2003 08:13:35 -0800 (PST)
	(envelope-from simon@arthur.nitro.dk)
Received: by arthur.nitro.dk (Postfix, from userid 1000)
	id 7CE2610BF87; Sun,  5 Jan 2003 17:13:32 +0100 (CET)
Message-Id: <20030105161332.7CE2610BF87@arthur.nitro.dk>
Date: Sun,  5 Jan 2003 17:13:32 +0100 (CET)
From: Simon L.Nielsen <simon@nitro.dk>
Reply-To: Simon L.Nielsen <simon@nitro.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] add sets information to ipfw2 -h
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         46785
>Category:       bin
>Synopsis:       [patch] add sets information to ipfw2 -h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ipfw
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 05 08:20:02 PST 2003
>Closed-Date:    Tue Jul 08 01:52:38 PDT 2003
>Last-Modified:  Tue Jul 08 01:52:38 PDT 2003
>Originator:     Simon L. Nielsen
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
>Environment:
System: FreeBSD arthur.nitro.dk 4.7-STABLE FreeBSD 4.7-STABLE #4: Sun Jan 5 15:47:07 CET 2003 root@arthur.nitro.dk:/usr/obj/usr/src/sys/ARTHUR i386

>Description:
ipfw2 has the 'sets' feature but ipfw -h does not document this.
>How-To-Repeat:
N/A
>Fix:
Note: the help (-h) function is in general somewhat inconsistent with
the man page. Perhaps a more general update to bring ipfw -h and the
man page in sync should be done?

--- ipfw2-help.patch begins here ---
Index: ipfw2.c
===================================================================
RCS file: /home/mirror/freebsd/ncvs/src/sbin/ipfw/ipfw2.c,v
retrieving revision 1.20
diff -u -d -u -r1.20 ipfw2.c
--- ipfw2.c	1 Jan 2003 18:48:45 -0000	1.20
+++ ipfw2.c	5 Jan 2003 15:50:56 -0000
@@ -1672,12 +1672,13 @@
 {
 
 	fprintf(stderr, "ipfw syntax summary:\n"
-"ipfw add [N] [prob {0..1}] ACTION [log [logamount N]] ADDR OPTIONS\n"
+"ipfw add [N] [set N] [prob {0..1}] ACTION [log [logamount N]] ADDR OPTIONS\n"
 "ipfw {pipe|queue} N config BODY\n"
 "ipfw [pipe] {zero|delete|show} [N{,N}]\n"
 "\n"
 "RULE:		[1..] [PROB] BODY\n"
 "RULENUM:	INTEGER(1..65534)\n"
+"SETNUM:		INTEGER(0..31)\n"
 "PROB:		prob REAL(0..1)\n"
 "BODY:		check-state [LOG] (no body) |\n"
 "		ACTION [LOG] MATCH_ADDR [OPTION_LIST]\n"
--- ipfw2-help.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->ipfw 
Responsible-Changed-By: johan 
Responsible-Changed-When: Mon Feb 3 12:58:44 PST 2003 
Responsible-Changed-Why:  
Over to ipfw maintainer group. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=46785 
State-Changed-From-To: open->closed 
State-Changed-By: luigi 
State-Changed-When: Tue Jul 8 01:52:24 PDT 2003 
State-Changed-Why:  
committed a fix, thanks 


http://www.freebsd.org/cgi/query-pr.cgi?pr=46785 
>Unformatted:
