From hogsett@csl.sri.com  Wed Dec  4 09:27:49 2002
Return-Path: <hogsett@csl.sri.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4E57637B401
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Dec 2002 09:27:49 -0800 (PST)
Received: from casper.sri.com (casper.SRI.COM [128.18.243.12])
	by mx1.FreeBSD.org (Postfix) with SMTP id 7241C43EC2
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Dec 2002 09:27:48 -0800 (PST)
	(envelope-from hogsett@csl.sri.com)
Received: (qmail 1606 invoked from network); 4 Dec 2002 17:27:43 -0000
Received: from localhost (HELO casper.SRI.COM) (127.0.0.1)
  by casper.sri.com with SMTP; 4 Dec 2002 17:27:43 -0000
Received: from quarter.csl.sri.com ([130.107.1.30])
 by casper.SRI.COM (NAVGW 2.5.2.17) with SMTP id M2002120409274228063
 ; Wed, 04 Dec 2002 09:27:42 -0800
Received: from beast.csl.sri.com (beast.csl.sri.com [130.107.2.57])
	by quarter.csl.sri.com (8.12.4/8.12.4) with ESMTP id gB4HRgnr014283;
	Wed, 4 Dec 2002 09:27:42 -0800
Received: from beast.csl.sri.com (localhost [127.0.0.1])
	by beast.csl.sri.com (8.12.6/8.12.6) with ESMTP id gB4HRerp004518;
	Wed, 4 Dec 2002 09:27:40 -0800 (PST)
	(envelope-from hogsett@beast.csl.sri.com)
Received: (from hogsett@localhost)
	by beast.csl.sri.com (8.12.6/8.12.6/Submit) id gB4HReCs004517;
	Wed, 4 Dec 2002 09:27:40 -0800 (PST)
	(envelope-from hogsett)
Message-Id: <200212041727.gB4HReCs004517@beast.csl.sri.com>
Date: Wed, 4 Dec 2002 09:27:40 -0800 (PST)
From: Mike Hogsett <hogsett@csl.sri.com>
Reply-To: Mike Hogsett <hogsett@csl.sri.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: freebsd-questions@freebsd.org
Subject: top dumps core if specific errors in password file
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45990
>Category:       bin
>Synopsis:       top(1) dumps core if specific errors in password file
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 04 09:30:00 PST 2002
>Closed-Date:    
>Last-Modified:  Tue Jul 10 03:41:52 UTC 2012
>Originator:     Mike Hogsett
>Release:        FreeBSD 4.7-RELEASE-p2 i386
>Organization:
SRI International Computer Science Laboratory
>Environment:
System: FreeBSD beast.csl.sri.com 4.7-RELEASE-p2 FreeBSD 4.7-RELEASE-p2 #2: Tue Nov 26 16:48:30 PST 2002 hogsett@beast.csl.sri.com:/usr/obj/usr/src/sys/BEAST i386

>Description:

If there is an incorrect entry in a NIS netgroup file & this netgroup file
is used to append specific NIS password database entries to the local
password database top will dump core at startup.

In gdb it shows top failed inside endpwent(3)

(gdb) where
#0  0x2810cbd8 in endpwent () from /usr/lib/libc.so.4
#1  0x2810d421 in endpwent () from /usr/lib/libc.so.4
#2  0x2810c1da in getpwent () from /usr/lib/libc.so.4
#3  0x804b28e in free ()
#4  0x804cb94 in clear ()
#5  0x8049389 in free ()

Since this error is appears to be within endpwent(3) I presume that
programs using this function may also be unstable.

>How-To-Repeat:

NIS netgroup file [NOTE: user3 entry incorrect] :

somegroup (,user2,),(,user2,),(user3)

master.password contains :

+@somegroup::::::::/tmp:/usr/bin/false

>Fix:

Well obviously fix the netgroup file error, but endpwent(3) should not
fail so severely.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Sat Dec 21 07:33:49 PST 2002 
Responsible-Changed-Why:  
Ahhh - was looking at a top PR which suggested there was a bug like 
this in the NIS stuff. I'll take this PR too, in the hope it will 
help me track it down. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45990 
Responsible-Changed-From-To: dwmalone->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Jul 10 03:41:51 UTC 2012 
Responsible-Changed-Why:  
over to the pool (approved by bugmeister) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45990 
>Unformatted:
