From mat@cnd184.cnd.mcgill.ca  Fri Nov 29 08:52:36 2002
Return-Path: <mat@cnd184.cnd.mcgill.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 168DF37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Nov 2002 08:52:36 -0800 (PST)
Received: from hak.cnd.mcgill.ca (hak.cnd.mcgill.ca [132.216.11.133])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5856943E4A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Nov 2002 08:52:35 -0800 (PST)
	(envelope-from mat@cnd184.cnd.mcgill.ca)
Received: from cnd184.cnd.mcgill.ca (cnd184.cnd.mcgill.ca [132.216.11.184])
	by hak.cnd.mcgill.ca (8.12.3/8.12.3) with ESMTP id gATGrLQr012287
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Nov 2002 11:53:21 -0500 (EST)
	(envelope-from mat@cnd184.cnd.mcgill.ca)
Received: from cnd184.cnd.mcgill.ca (localhost [127.0.0.1])
	by cnd184.cnd.mcgill.ca (8.12.6/8.12.6) with ESMTP id gATGrUSQ060174
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Nov 2002 11:53:30 -0500 (EST)
	(envelope-from mat@cnd184.cnd.mcgill.ca)
Received: (from mat@localhost)
	by cnd184.cnd.mcgill.ca (8.12.6/8.12.6/Submit) id gATGrRp3060173;
	Fri, 29 Nov 2002 11:53:27 -0500 (EST)
	(envelope-from mat)
Message-Id: <200211291653.gATGrRp3060173@cnd184.cnd.mcgill.ca>
Date: Fri, 29 Nov 2002 11:53:27 -0500 (EST)
From: Mathew Kanner <mat@cnd.mcgill.ca>
Reply-To: Mathew Kanner <mat@cnd.mcgill.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: libusbhid needs small patch to report name right
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45838
>Category:       bin
>Synopsis:       libusbhid needs small patch to report name right
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 29 09:00:02 PST 2002
>Closed-Date:    Tue Apr 08 14:37:41 PDT 2003
>Last-Modified:  Tue Apr 08 14:37:41 PDT 2003
>Originator:     Mathew Kanner
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
The Centre for Nonlinear Dynamics in Physiology and Medicine 
>Environment:
System: FreeBSD cnd184.cnd.mcgill.ca 4.7-RELEASE FreeBSD 4.7-RELEASE #0: Thu Nov 7 13:08:56 EST 2002 mat@cnd184.cnd.mcgill.ca:/usr/src/sys/compile/CND47 i386


	
>Description:
	Small patch taken from NetBSD so that libusbhid can report and find
buttons and so forth that need formating in the name.  usbhidctl reports things
like ...Button_%d 1, without it, and Button_1 with the patch.  This is needed
so that I can use usbaction from NetBSD and control my sound card from
my usb wignman :)
	
>How-To-Repeat:
	Don't do anything and use usbhictl -a on a Joystick
	
>Fix:

--- /home/mat/usage.c	Fri Nov 29 11:42:36 2002
+++ lib/libusbhid/usage.c	Fri Nov 29 11:44:12 2002
@@ -185,8 +185,9 @@
 	for (j = 0; j < pages[k].pagesize; j++) {
 		us = pages[k].page_contents[j].usage;
 		if (us == -1) {
-			sprintf(b, "%s %d",
-			    pages[k].page_contents[j].name, i);
+			sprintf(b,
+				fmtcheck(pages[k].page_contents[j].name, "%d"),
+					i);
 			return b;
 		}
 		if (us == i)
	


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ceri 
State-Changed-When: Tue Apr 8 14:36:16 PDT 2003 
State-Changed-Why:  
Committed in r1.7 of src/lib/libusbhid/usage.c. 
Thanks for your submission. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45838 
>Unformatted:
