From alo@alo.louko.com  Sun Nov 17 13:54:07 2002
Return-Path: <alo@alo.louko.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7188A37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 17 Nov 2002 13:54:07 -0800 (PST)
Received: from alo.louko.com (x1.louko.com [195.218.71.106])
	by mx1.FreeBSD.org (Postfix) with SMTP id ECD2143E3B
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 17 Nov 2002 13:54:05 -0800 (PST)
	(envelope-from alo@alo.louko.com)
Received: (qmail 28053 invoked by uid 406); 17 Nov 2002 21:54:03 -0000
Message-Id: <20021117215403.28052.qmail@alo.louko.com>
Date: 17 Nov 2002 21:54:03 -0000
From: Antti Louko <alo@iki.fi>
Reply-To: Antti Louko <alo@iki.fi>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Coding error in /usr/src/contrib/bind/bin/dig/dig.c
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45376
>Category:       bin
>Synopsis:       Coding error in /usr/src/contrib/bind/bin/dig/dig.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 17 14:00:12 PST 2002
>Closed-Date:    Sun Nov 17 21:15:48 PST 2002
>Last-Modified:  Sun Nov 17 21:15:48 PST 2002
>Originator:     Antti Louko
>Release:        FreeBSD 4.6.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD xxxx.louko.com 4.6.2-RELEASE FreeBSD 4.6.2-RELEASE #4: Tue Oct 22 21:29:10 EEST 2002 root@alo.louko.com:/u9/src/sys/compile/ALO i386

>Description:

Coding error in /usr/src/contrib/bind/bin/dig/dig.c:

static void
reverse6(char *domain, struct in6_addr *in6) {
	sprintf(domain, "%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.%x.ip6.arpa",
		in6->s6_addr[15] & 0x0f, (in6->s6_addr[15] >> 4) & 0x0f,
		in6->s6_addr[14] & 0x0f, (in6->s6_addr[14] >> 4) & 0x0f,
		in6->s6_addr[13] & 0x0f, (in6->s6_addr[13] >> 4) & 0x0f,
		in6->s6_addr[12] & 0x0f, (in6->s6_addr[12] >> 4) & 0x0f,
		in6->s6_addr[11] & 0x0f, (in6->s6_addr[11] >> 4) & 0x0f,
		in6->s6_addr[10] & 0x0f, (in6->s6_addr[10] >> 4) & 0x0f,
		in6->s6_addr[9] & 0x0f, (in6->s6_addr[9] >> 4) & 0x0f,
		in6->s6_addr[8] & 0x0f, (in6->s6_addr[8] >> 4) & 0x0f,
		in6->s6_addr[7] & 0x0f, (in6->s6_addr[7] >> 4) & 0x0f,
		in6->s6_addr[6] & 0x0f, (in6->s6_addr[6] >> 4) & 0x0f,
		in6->s6_addr[5] & 0x0f, (in6->s6_addr[5] >> 4) & 0x0f,
		in6->s6_addr[4] & 0x0f, (in6->s6_addr[4] >> 4) & 0x0f,
		in6->s6_addr[6] & 0x0f, (in6->s6_addr[3] >> 4) & 0x0f,
		in6->s6_addr[2] & 0x0f, (in6->s6_addr[2] >> 4) & 0x0f,
		in6->s6_addr[1] & 0x0f, (in6->s6_addr[1] >> 4) & 0x0f,
		in6->s6_addr[0] & 0x0f, (in6->s6_addr[0] >> 4) & 0x0f);
}

dig doesn't work with -x option and IPv6 aadresses.

>How-To-Repeat:

See wrong ip6.arpa address in ;; QUERY SECTION:

% dig -x 2001:638:a00::2 any

; <<>> DiG 8.3 <<>> -x any 
;; res options: init recurs defnam dnsrch
;; got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 2
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 0
;; QUERY SECTION:
;;      2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.0.0.3.6.0.1.0.0.2.ip6.arpa, type = ANY, class = IN


>Fix:

Change line 

		in6->s6_addr[6] & 0x0f, (in6->s6_addr[3] >> 4) & 0x0f,

into

		in6->s6_addr[3] & 0x0f, (in6->s6_addr[3] >> 4) & 0x0f,

Report the bug to ISC, too, as it is still in the latest BIND 8 release.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Sun Nov 17 21:13:45 PST 2002 
State-Changed-Why:  

Duplicate of bin/41388. Please take a look at that PR for 
the solution. 


Responsible-Changed-From-To: freebsd-bugs->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sun Nov 17 21:13:45 PST 2002 
Responsible-Changed-Why:  

I closed bin/41388 too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45376 
>Unformatted:
