From logix@foobar.franken.de  Fri Nov 15 09:17:20 2002
Return-Path: <logix@foobar.franken.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E04D037B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Nov 2002 09:17:20 -0800 (PST)
Received: from mailout05.sul.t-online.com (mailout05.sul.t-online.com [194.25.134.82])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B459F43E75
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Nov 2002 09:17:19 -0800 (PST)
	(envelope-from logix@foobar.franken.de)
Received: from fwd03.sul.t-online.de 
	by mailout05.sul.t-online.com with smtp 
	id 18Ck5n-0000Hu-00; Fri, 15 Nov 2002 18:17:19 +0100
Received: from foobar.franken.de (520066542279-0001@[217.235.74.212]) by fmrl03.sul.t-online.com
	with esmtp id 18Ck5c-0wTMnIC; Fri, 15 Nov 2002 18:17:08 +0100
Received: from foobar.franken.de (localhost [127.0.0.1])
	by foobar.franken.de (8.12.6/8.12.5) with ESMTP id gAFHH7JH016394
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Nov 2002 18:17:07 +0100 (CET)
	(envelope-from logix@foobar.franken.de)
Received: (from logix@localhost)
	by foobar.franken.de (8.12.6/8.12.6/Submit) id gAFHH4q9016393;
	Fri, 15 Nov 2002 18:17:04 +0100 (CET)
Message-Id: <200211151717.gAFHH4q9016393@foobar.franken.de>
Date: Fri, 15 Nov 2002 18:17:04 +0100 (CET)
From: Harold Gutch <logix@foobar.franken.de>
Reply-To: Harold Gutch <logix@foobar.franken.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] traceroute(8) manpage does not mention "-P icmp"
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         45317
>Category:       bin
>Synopsis:       [PATCH] traceroute(8) manpage does not mention "-P icmp"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    fenner
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 15 09:20:01 PST 2002
>Closed-Date:    Wed Nov 27 09:09:24 PST 2002
>Last-Modified:  Wed Nov 27 09:09:24 PST 2002
>Originator:     Harold Gutch
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
>Environment:
System: FreeBSD foobar.franken.de 4.7-STABLE FreeBSD 4.7-STABLE #8: Fri Nov 15 03:08:15 CET 2002 logix@foobar.franken.de:/usr/obj/usr/src/sys/FOOBAR i386


>Description:
	The traceroute(8) manpage does not document the possibility to send
	out ICMP packets, it only mentions UDP, TCP and GRE as supported
	protocols.
	
>How-To-Repeat:
	man traceroute, search for "-P".
>Fix:
	Apply attached patch.

--- src/contrib/traceroute/traceroute.8.orig	Fri Sep 25 17:54:13 2001
+++ src/contrib/traceroute/traceroute.8	Fri Nov 15 18:11:59 2002
@@ -109,7 +109,7 @@
 .TP
 .B \-P
 Send packets of specified IP protocol. The currently supported protocols
-are: UDP, TCP and GRE. Other protocols may also be specified (either by
+are: UDP, TCP, GRE and ICMP. Other protocols may also be specified (either by
 name or by number), though
 .I traceroute
 does not implement any special knowledge of their packet formats. This
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: roam 
State-Changed-When: Fri Nov 15 10:10:09 PST 2002 
State-Changed-Why:  

Thank you for your patch! 

Unfortunately, the traceroute package used in FreeBSD is contributed 
software, maintained independently by the folks at LBL.  FreeBSD does 
not make local changes to the traceroute source or documentation, unless 
sorely needed; the preferred way of introducing changes into the 
traceroute package is submitting them to the LBL developers via e-mail 
at traceroute@ee.lbl.gov, as noted in the 
src/contrib/traceroute/FREEBSD-upgrade file.  Would it be possible for 
you to contact them and offer them your patch?  If they accept it, and 
it makes its way into a next release of the traceroute package, it will 
be imported into FreeBSD soon thereafter, as part of the next upgrade of 
FreeBSD's contributed traceroute package. 

Thanks for your efforts to make FreeBSD better! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45317 

From: Ruslan Ermilov <ru@FreeBSD.ORG>
To: Peter Pentchev <roam@FreeBSD.ORG>,
	Bill Fenner <fenner@FreeBSD.ORG>
Cc: logix@foobar.franken.de, bug-followup@FreeBSD.ORG
Subject: Re: bin/45317: [PATCH] traceroute(8) manpage does not mention "-P icmp"
Date: Fri, 15 Nov 2002 21:00:42 +0200

 On Fri, Nov 15, 2002 at 10:14:38AM -0800, Peter Pentchev wrote:
 > Synopsis: [PATCH] traceroute(8) manpage does not mention "-P icmp"
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: roam
 > State-Changed-When: Fri Nov 15 10:10:09 PST 2002
 > State-Changed-Why: 
 > 
 > Thank you for your patch!
 > 
 > Unfortunately, the traceroute package used in FreeBSD is contributed
 > software, maintained independently by the folks at LBL.
 > 
 No, it's not, in its current state; it's highly modified by us, and
 ICMP is the local extension.  Contact fenner@ instead.  :-)
 
 > FreeBSD does
 > not make local changes to the traceroute source or documentation, unless
 > sorely needed; the preferred way of introducing changes into the
 > traceroute package is submitting them to the LBL developers via e-mail
 > at traceroute@ee.lbl.gov, as noted in the
 > src/contrib/traceroute/FREEBSD-upgrade file.  Would it be possible for
 > you to contact them and offer them your patch?  If they accept it, and
 > it makes its way into a next release of the traceroute package, it will
 > be imported into FreeBSD soon thereafter, as part of the next upgrade of
 > FreeBSD's contributed traceroute package.
 > 
 > Thanks for your efforts to make FreeBSD better!
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=45317
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-bugs" in the body of the message
 
 -- 
 Ruslan Ermilov		Sysadmin and DBA,
 ru@sunbay.com		Sunbay Software AG,
 ru@FreeBSD.org		FreeBSD committer,
 +380.652.512.251	Simferopol, Ukraine
 
 http://www.FreeBSD.org	The Power To Serve
 http://www.oracle.com	Enabling The Information Age
State-Changed-From-To: feedback->open 
State-Changed-By: roam 
State-Changed-When: Mon Nov 18 01:04:34 PST 2002 
State-Changed-Why:  
Oops; it turns out that this fix concerns a FreeBSD local addition 
to the traceroute package.  Guess I should have looked closer :) 


Responsible-Changed-From-To: freebsd-bugs->fenner 
Responsible-Changed-By: roam 
Responsible-Changed-When: Mon Nov 18 01:04:34 PST 2002 
Responsible-Changed-Why:  
Over to the traceroute packate maintainer in the FreeBSD tree. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45317 
State-Changed-From-To: open->closed 
State-Changed-By: fenner 
State-Changed-When: Wed Nov 27 09:09:14 PST 2002 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=45317 
>Unformatted:
