From girgen@smtp.chello.se  Sat Oct 12 07:13:30 2002
Return-Path: <girgen@smtp.chello.se>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD07737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2002 07:13:30 -0700 (PDT)
Received: from webedge2.chello.se (webedge2.chello.se [193.150.195.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 18D0443EB3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2002 07:13:30 -0700 (PDT)
	(envelope-from girgen@smtp.chello.se)
Received: from palle.girgensohn.se (c213-89-136-93.cm-upc.chello.se [213.89.136.93])
	by webedge2.chello.se (Postfix) with ESMTP id 7D2B426651
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2002 16:12:56 +0200 (MEST)
Received: from palle.girgensohn.se (localhost [127.0.0.1])
	by palle.girgensohn.se (8.12.6/8.12.6) with ESMTP id g9CEDS3i041612
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Oct 2002 16:13:28 +0200 (CEST)
	(envelope-from girgen@palle.girgensohn.se)
Received: (from girgen@localhost)
	by palle.girgensohn.se (8.12.6/8.12.6/Submit) id g9CEDRFK041611;
	Sat, 12 Oct 2002 16:13:27 +0200 (CEST)
Message-Id: <200210121413.g9CEDRFK041611@palle.girgensohn.se>
Date: Sat, 12 Oct 2002 16:13:27 +0200 (CEST)
From: Palle Girgensohn <girgen@pingpong.net>
Reply-To: Palle Girgensohn <girgen@pingpong.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         43975
>Category:       bin
>Synopsis:       share/sendmail/Makefile uses ${INSTALL} -d, breaks with -C
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gshapiro
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 12 07:20:01 PDT 2002
>Closed-Date:    Sat Feb 08 13:18:01 PST 2003
>Last-Modified:  Sat Feb 08 13:18:01 PST 2003
>Originator:     Palle Girgensohn <girgen@pingpong.net>
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
PING PONG
>Environment:
System: FreeBSD palle.girgensohn.se 4.7-RC FreeBSD 4.7-RC #0: Sun Sep 29 17:21:22 CEST 2002     root@palle.girgensohn.se:/usr/local/obj/usr/src/sys/STORDATAN  i386

also applies to CURRENT, afaik.
	
>Description:
src/share/sendmail/Makefile uses ${INSTALL} ... -d
src/etc/default/make.conf recommends setting INSTALL/install -C ,
which I find a good thing.

Now, since fbsd-4.5.something (?), install -C -d ... fails (previously
it silently ignored the `-C'). So, using ${INSTALL} -d in src and
ports cannot be allowed anymore; instead we must either not use the
INSTALL var, i.e. `install -C', or do the mkdir; chmod; chown troika.

>How-To-Repeat:
# echo 'INSTALL=install -C' >> /etc/make.conf
# cd /usr/src
# make installworld

the only thing that fails is share/sendmail
>Fix:
This patch would be much appreciated:

Index: Makefile
===================================================================
RCS file: /usr/local/ncvs/src/share/sendmail/Makefile,v
retrieving revision 1.1.2.6
diff -u -u -r1.1.2.6 Makefile
--- Makefile	7 Aug 2002 16:31:51 -0000	1.1.2.6
+++ Makefile	12 Oct 2002 13:57:40 -0000
@@ -23,7 +23,9 @@
 
 copies::
 .for dir in ${CFDIRS}
-	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 755 -d ${DDIR}/${dir}
+	${MKDIR} ${DDIR}/${dir}
+	${CHMOD} 755 ${DDIR}/${dir}
+	${CHOWN} ${BINOWN}:${BINGRP} ${DDIR}/${dir}
 .endfor
 .for file in ${CFFILES}
 	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 ${SENDMAIL_DIR}/${file} ${DDIR}/${file}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->gshapiro 
Responsible-Changed-By: schweikh 
Responsible-Changed-When: Sat Oct 12 10:29:10 PDT 2002 
Responsible-Changed-Why:  
Let our sendmail liaison Gregory have a look at this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43975 
State-Changed-From-To: open->closed 
State-Changed-By: gshapiro 
State-Changed-When: Sat Feb 8 13:17:00 PST 2003 
State-Changed-Why:  
install was fixed to properly handle -d and -C together in this set of 
commits: 

Revision 1.38.2.8, Wed Aug 7 16:29:48 2002 UTC (6 months ago) by ru 
Branch: RELENG_4 
CVS Tags: RELENG_4_7_BP, RELENG_4_7_0_RELEASE, RELENG_4_7 

MFC. 

Ignore -C, -p, and -S options of install(1) when used with the -d 
option.  Warn about COPY being phased out.  Restore the old method 
of always comparing before installing: INSTALL="install -C". 

Revision 1.56, Mon Jul 29 08:51:04 2002 UTC (6 months, 1 week ago) by ru 
Branch: MAIN 

Ignore -C, -p, and -S options of install(1) when used with the -d 
option.  Warn about COPY being phased out.  Restore the old method 
of always comparing before installing: INSTALL="install -C". 

Requested by:	bde 


http://www.freebsd.org/cgi/query-pr.cgi?pr=43975 
>Unformatted:
