From mistral@imasy.or.jp  Sun Sep  8 19:20:30 2002
Return-Path: <mistral@imasy.or.jp>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB90D37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Sep 2002 19:20:30 -0700 (PDT)
Received: from ns5.sony.co.jp (NS5.Sony.CO.JP [146.215.0.45])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CCCB143E3B
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Sep 2002 19:20:29 -0700 (PDT)
	(envelope-from mistral@imasy.or.jp)
Received: from mail3.sony.co.jp (mail3.sony.co.jp [43.0.1.203])
	by ns5.sony.co.jp (R8/Sony) with ESMTP id g892KML00412
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Sep 2002 11:20:22 +0900 (JST)
Received: from mail3.sony.co.jp (localhost [127.0.0.1])
	by mail3.sony.co.jp (R8/Sony) with ESMTP id g892KMn29587
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Sep 2002 11:20:22 +0900 (JST)
Received: from mistral.imasy.or.jp ([43.2.7.82])
	by mail3.sony.co.jp (R8/Sony) with ESMTP id g892KLB29572
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Sep 2002 11:20:21 +0900 (JST)
Received: from mistral.imasy.or.jp (localhost [IPv6:::1])
	by mistral.imasy.or.jp (8.12.5/8.12.5/mistral) with ESMTP id g892KIIA019218
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Sep 2002 11:20:18 +0900 (JST)
	(envelope-from mistral@imasy.or.jp)
Received: (from sarumaru@localhost)
	by mistral.imasy.or.jp (8.12.5/8.12.5/Submit) id g892KHgB019217;
	Mon, 9 Sep 2002 11:20:17 +0900 (JST)
	(envelope-from sarumaru)
Message-Id: <200209090220.g892KHgB019217@mistral.imasy.or.jp>
Date: Mon, 9 Sep 2002 11:20:17 +0900 (JST)
From: Yoshihiko Sarumaru <mistral@imasy.or.jp>
Reply-To: Yoshihiko Sarumaru <mistral@imasy.or.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: YAMAHA RTW65b router coudn't be connected by umodem driver
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         42574
>Category:       bin
>Synopsis:       YAMAHA RTW65b router coudn't be connected by umodem driver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 08 19:30:02 PDT 2002
>Closed-Date:    Wed Feb 12 05:23:52 PST 2003
>Last-Modified:  Wed Feb 12 05:23:52 PST 2003
>Originator:     Yoshihiko Sarumaru
>Release:        FreeBSD 4.7-PRERELEASE i386
>Organization:
Internet Mutual Aid Society Yokohama
>Environment:
System: FreeBSD mistral.imasy.or.jp 4.7-PRERELEASE FreeBSD 4.7-PRERELEASE #6: Sun Sep 8 02:24:00 JST 2002 root@mistral.imasy.or.jp:/usr/obj/usr/src/sys/Z505VRK i386


	
>Description:
	YAMAHA RTW65b broadband router has USB interface and it is expected
	to be able to use with umodem driver.
	But this device needs 'UQ_ASSUME_CM_OVER_DATA' quirk to attach.
>How-To-Repeat:
	Plug it.
>Fix:
	This patch worked for 4.7-PRERELEASE. I don't know with -current...
	NetBSD usb_quirks.c also has not have this entry yet.

--- usbdevs.orig	Sat Aug 31 20:22:42 2002
+++ usbdevs	Sun Sep  8 23:16:47 2002
@@ -1099,6 +1099,7 @@
 /* Yamaha products */
 product YAMAHA UX256		0x1000	UX256 MIDI I/F
 product	YAMAHA UX96		0x1008	UX96 MIDI I/F
+product YAMAHA RTW65B		0x4001  Net Voranti RTW65B Broadband Router
 
 /* Yano products */
 product YANO U640MO		0x0101	U640MO-03

--- usb_quirks.c.orig	Sat Aug 24 17:00:32 2002
+++ usb_quirks.c	Sun Sep  8 23:10:31 2002
@@ -77,6 +77,7 @@
  	0x100, { UQ_ASSUME_CM_OVER_DATA | UQ_NO_STRINGS }},
  { USB_VENDOR_ACERP, USB_PRODUCT_ACERP_ACERSCAN_320U,
  						    0x000, { UQ_NO_STRINGS }},
+ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTW65B,    0x5311,   { UQ_ASSUME_CM_OVER_DATA }},
  /* XXX These should have a revision number, but I don't know what they are. */
  { USB_VENDOR_HP, USB_PRODUCT_HP_895C,		    ANY,   { UQ_BROKEN_BIDIR }},
  { USB_VENDOR_HP, USB_PRODUCT_HP_880C,		    ANY,   { UQ_BROKEN_BIDIR }},
>Release-Note:
>Audit-Trail:

From: mistral@imasy.or.jp (Yoshihiko SARUMARU)
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/42574: YAMAHA RTW65b router coudn't be connected by umodem
	 driver
Date: Mon, 9 Sep 2002 13:15:25 +0900

 Sorry, please give me a chance to fix a typo.
 
 s/Voranti/Volante/;
 
 Submitted by: matusita
 --
 Yoshihiko SARUMARU
 mail: mistral@imasy.or.jp       web: http://www.imasy.or.jp/~mistral/

From: mistral@imasy.or.jp (Yoshihiko Sarumaru)
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/42574: YAMAHA RTW65b router coudn't be connected by umodem
	 driver
Date: Tue, 11 Feb 2003 23:10:33 +0900

 It was coming out that bcdDevice of this product is depend on
 the version of firmware, and my previous patch will loose its effect
 when we upload the other firmware. So we must not use exact
 bcdDevice but ANY keyword.
 
 Also I had contacted with YAMAHA person and get three more models that
 support USB serial and require the same approach to use with FreeBSD.
 
 BTW, current implementation of usbd_find_quirk() seems does not
 care `ANY' keyword although ANY keyword is already used, so my
 new patch includes modification for usbd_find_quirk() too.
 
 I wonder idProduct also should be ANY since new YAMAHA product
 likely to require the same quirk, but it propagate this quirk to
 not only umodem driver but also any USB drivers. I think this
 quirk is not harmful for other USB products, but for the safety
 I don't propose this way, now.
 
 --- usbdevs.orig	Tue Aug 27 22:46:28 2002
 +++ usbdevs	Sun Sep 15 20:45:05 2002
 @@ -1099,6 +1099,10 @@
  /* Yamaha products */
  product YAMAHA UX256		0x1000	UX256 MIDI I/F
  product	YAMAHA UX96		0x1008	UX96 MIDI I/F
 +product YAMAHA RTA54I		0x4000	NetVolante RTA54i Broadband&ISDN Router
 +product YAMAHA RTA55I		0x4004	NetVolante RTA55i Broadband VoIP Router
 +product YAMAHA RTW65B		0x4001	NetVolante RTW65b Broadband Wireless Router
 +product YAMAHA RTW65I		0x4002	NetVolante RTW65i Broadband&ISDN Wireless Router
  
  /* Yano products */
  product YANO U640MO		0x0101	U640MO-03
 --- usb_quirks.c.orig	Sat Aug 24 17:00:32 2002
 +++ usb_quirks.c	Sun Sep 15 21:31:52 2002
 @@ -77,6 +77,12 @@
   	0x100, { UQ_ASSUME_CM_OVER_DATA | UQ_NO_STRINGS }},
   { USB_VENDOR_ACERP, USB_PRODUCT_ACERP_ACERSCAN_320U,
   						    0x000, { UQ_NO_STRINGS }},
 + /* YAMAHA router's ucdDevice is the version of farmware and often changes. */
 + { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTA54I,    ANY,   { UQ_ASSUME_CM_OVER_DATA }},
 + { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTA55I,    ANY,   { UQ_ASSUME_CM_OVER_DATA }},
 + { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTW65B,    ANY,   { UQ_ASSUME_CM_OVER_DATA }},
 + { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTW65I,    ANY,   { UQ_ASSUME_CM_OVER_DATA }},
 +
   /* XXX These should have a revision number, but I don't know what they are. */
   { USB_VENDOR_HP, USB_PRODUCT_HP_895C,		    ANY,   { UQ_BROKEN_BIDIR }},
   { USB_VENDOR_HP, USB_PRODUCT_HP_880C,		    ANY,   { UQ_BROKEN_BIDIR }},
 @@ -97,7 +103,7 @@
  	for (t = usb_quirks; t->idVendor != 0; t++) {
  		if (t->idVendor  == UGETW(d->idVendor) &&
  		    t->idProduct == UGETW(d->idProduct) &&
 -		    t->bcdDevice == UGETW(d->bcdDevice))
 +		    (t->bcdDevice == ANY || t->bcdDevice == UGETW(d->bcdDevice)))
  			break;
  	}
  #ifdef USB_DEBUG
 
 --
 Yoshihiko Sarumaru
 mail: mistral@imasy.or.jp       web: http://www.imasy.or.jp/~mistral/
State-Changed-From-To: open->closed 
State-Changed-By: sanpei 
State-Changed-When: Wed Feb 12 05:23:10 PST 2003 
State-Changed-Why:  
Commited rev. 1.113 of usbdevs and 1.32 of usb_quirks.c 

http://www.freebsd.org/cgi/query-pr.cgi?pr=42574 
>Unformatted:
