From nobody  Thu Jul 24 02:44:12 1997
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id CAA19936;
          Thu, 24 Jul 1997 02:44:12 -0700 (PDT)
Message-Id: <199707240944.CAA19936@hub.freebsd.org>
Date: Thu, 24 Jul 1997 02:44:12 -0700 (PDT)
From: denny1@home.com
To: freebsd-gnats-submit@freebsd.org
Subject: netstat atalk output should print symbolic names for port #s
X-Send-Pr-Version: www-1.0

>Number:         4157
>Category:       bin
>Synopsis:       [PATCH] netstat atalk output should print symbolic names for port #s
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    imp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 24 02:50:00 PDT 1997
>Closed-Date:    Fri Jun 15 14:47:35 MDT 2001
>Last-Modified:  Fri Jun 15 14:47:50 MDT 2001
>Originator:     Denny Gentry
>Release:        N/A
>Organization:
>Environment:
Identified while bringing up netatalk on OpenBSD, relied
heavily on the FreeBSD code. Trying to contribute changes back.
>Description:
/usr/bin/netstat -a always prints appletalk ports numerically.
Would like it to getservbyname and print the symbolic name.

>How-To-Repeat:

>Fix:
  At line 118 of atalk.c, replace:
                sprintf(mybuf,"%d",(unsigned int)sat->sat_port);

with:
                if (nflag)
                        (void) snprintf(mybuf, sizeof(mybuf), "%d",
                            (unsigned int) sat->sat_port);
                else {
                        serv = getservbyport(sat->sat_port, "ddp");
                        if (serv == NULL)
                                (void) snprintf(mybuf, sizeof(mybuf), "%d",
                                    (unsigned int) sat->sat_port);
                        else
                                (void) snprintf(mybuf, sizeof(mybuf), "%s",
                                    serv->s_name);
                }

                return mybuf;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: phk 
State-Changed-When: Mon May 4 04:06:04 PDT 1998 
State-Changed-Why:  
ready to be picked up by somebody. 

From: Christoph Sold <so@server.i-clue.de>
To: freebsd-gnats-submit@FreeBSD.org, denny1@home.com
Cc:  
Subject: Re: bin/4157: [PATCH] netstat atalk output should print symbolic names 
 for port #s
Date: Wed, 13 Jun 2001 15:18:46 +0200

 This PR can be closed
 
 ..because it prints symbolic names:
 
 # netstat atalk
 Active Internet connections
 Proto Recv-Q Send-Q  Local Address          Foreign Address       
 (state)
 tcp4       0      4  informatix.telnet      automatix.1130        
 ESTABLISHED
 
 HTH
 -Christoph Sold
State-Changed-From-To: suspended->closed 
State-Changed-By: imp 
State-Changed-When: Fri Jun 15 14:40:42 MDT 2001 
State-Changed-Why:  
This has been updated in the tree now, it would seem. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=4157 
State-Changed-From-To: closed->open 
State-Changed-By: imp 
State-Changed-When: Fri Jun 15 14:47:07 MDT 2001 
State-Changed-Why:  
No, it isn't fixed. 


Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: imp 
Responsible-Changed-When: Fri Jun 15 14:47:07 MDT 2001 
Responsible-Changed-Why:  
I'll fix it. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=4157 
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Fri Jun 15 14:47:35 MDT 2001 
State-Changed-Why:  
I just fixed it. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=4157 
>Unformatted:
