From thz@Lennartz-electronic.de  Tue Jul 16 06:58:42 2002
Return-Path: <thz@Lennartz-electronic.de>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BEFDF37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Jul 2002 06:58:42 -0700 (PDT)
Received: from smtp.www-service.de (smtp.www-service.de [212.77.161.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 61AC443E31
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Jul 2002 06:58:41 -0700 (PDT)
	(envelope-from thz@Lennartz-electronic.de)
Received: from swd2.tue.le (pD95033C1.dip.t-dialin.net [217.80.51.193])
	by smtp.www-service.de (8.11.6/8.11.6) with ESMTP id g6GFHjX19483
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Jul 2002 17:17:45 +0200
Received: from mezcal.tue.le (mezcal.tue.le [192.168.201.20])
	by swd2.tue.le (8.12.3/8.12.3) with ESMTP id g6GDgNXj049653
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Jul 2002 15:42:23 +0200 (CEST)
	(envelope-from thz@mezcal.tue.le)
Received: from mezcal.tue.le (localhost [127.0.0.1])
	by mezcal.tue.le (8.12.3/8.12.3) with ESMTP id g6GDgNUM072666
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Jul 2002 15:42:23 +0200 (CEST)
	(envelope-from thz@mezcal.tue.le)
Received: (from thz@localhost)
	by mezcal.tue.le (8.12.3/8.12.3/Submit) id g6GDgNf9072665;
	Tue, 16 Jul 2002 15:42:23 +0200 (CEST)
	(envelope-from thz)
Message-Id: <200207161342.g6GDgNf9072665@mezcal.tue.le>
Date: Tue, 16 Jul 2002 15:42:23 +0200 (CEST)
From: Thomas Zenker <thz@Lennartz-electronic.de>
Reply-To: Thomas Zenker <thz@Lennartz-electronic.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: patch: sysinstall: infinite loop
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40654
>Category:       bin
>Synopsis:       patch: sysinstall: infinite loop
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jhb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 16 07:00:03 PDT 2002
>Closed-Date:    Thu Dec 11 12:26:26 PST 2003
>Last-Modified:  Thu Dec 11 12:26:26 PST 2003
>Originator:     Thomas Zenker
>Release:        FreeBSD 4.6-RELEASE i386
>Organization:
>Environment:
System: FreeBSD mezcal.tue.le 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Mon Jun 10 11:22:51 CEST 2002 thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL i386


	all versions of sysinstall
>Description:
	some errors during scripted partitioning (partionEditor) get
	sysinstall looping infinitely, because of use of continue vs.
	break in case of error.
>How-To-Repeat:
	
>Fix:
	the following patch applies to current and stable.

Index: label.c
===================================================================
RCS file: /usr/cvs/FreeBSD/src/usr.sbin/sysinstall/label.c,v
retrieving revision 1.118
diff -u -r1.118 label.c
--- label.c	7 Jun 2002 15:32:05 -0000	1.118
+++ label.c	16 Jul 2002 13:27:06 -0000
@@ -1401,7 +1401,7 @@
 		    if (sscanf(cp, "%s %d %s %d", typ, &sz, mpoint, &soft) < 3) {
 			msgConfirm("For slice entry %s, got an invalid detail entry of: %s",  c1->name, cp);
 			status = DITEM_FAILURE;
-			continue;
+			break;
 		    }
 		    else {
 			Chunk *tmp;
@@ -1422,7 +1422,7 @@
 			if (sz > space_free(c1)) {
 			    msgConfirm("Not enough free space to create partition: %s", mpoint);
 			    status = DITEM_FAILURE;
-			    continue;
+			    break;
 			}
 			if (!(tmp = Create_Chunk_DWIM(d, c1, sz, part,
 						      (type == PART_SWAP) ? FS_SWAP : FS_BSDFFS, flags))) {

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->re 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Wed Jul 17 09:33:43 PDT 2002 
Responsible-Changed-Why:  
Sysinstall is being looked after by the release engineers at the moment. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40654 
Responsible-Changed-From-To: re->qa 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Fri Jul 19 04:09:29 PDT 2002 
Responsible-Changed-Why:  
re@ feel that qa@ is a better list to assign sysinstall PRs to. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40654 
State-Changed-From-To: open->analyzed 
State-Changed-By: jhb 
State-Changed-When: Tue Nov 12 13:15:31 PST 2002 
State-Changed-Why:  
Fixed in current, needs to be MFC'd for 4.8. 


Responsible-Changed-From-To: qa->jhb 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Tue Nov 12 13:15:31 PST 2002 
Responsible-Changed-Why:  
Fixed in current, needs to be MFC'd for 4.8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40654 
State-Changed-From-To: analyzed->closed 
State-Changed-By: jhb 
State-Changed-When: Thu Dec 11 12:26:08 PST 2003 
State-Changed-Why:  
Fixes finally committed to 4.x. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40654 
>Unformatted:
