From nick@milla.ask33.net  Fri Jul 12 11:29:12 2002
Return-Path: <nick@milla.ask33.net>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 03C3137B400
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 11:29:12 -0700 (PDT)
Received: from milla.ask33.net (milla.ask33.net [217.197.166.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CA80E43E6A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 11:29:10 -0700 (PDT)
	(envelope-from nick@milla.ask33.net)
Received: by milla.ask33.net (Postfix, from userid 1001)
	id 889C93ABB4E; Fri, 12 Jul 2002 20:30:03 +0200 (CEST)
Message-Id: <20020712183003.889C93ABB4E@milla.ask33.net>
Date: Fri, 12 Jul 2002 20:30:03 +0200 (CEST)
From: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
Reply-To: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
To: FreeBSD-gnats-submit@freebsd.org
Cc: nick@garage.freebsd.pl, venglin@freebsd.lublin.pl
Subject: Buffer overflow in /usr/src/usr.sbin/vipw/pw_util.c [changed servity to critical]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40492
>Category:       bin
>Synopsis:       Buffer overflow in /usr/src/usr.sbin/vipw/pw_util.c [changed servity to critical]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 12 11:30:01 PDT 2002
>Closed-Date:    Sun Jul 14 06:12:17 PDT 2002
>Last-Modified:  Sun Jul 14 06:12:17 PDT 2002
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 	Many set-uid-root applications use this function:
 	/usr/bin/passwd
 	/usr/bin/chsh
 	/usr/bin/chpass
 	/usr/bin/chfn
 
>How-To-Repeat:
>Fix:
	Here You got a little patch:


12 Lip 12:07 2002 diff -lu pw_util.c.orig pw_util.c Page 1


--- pw_util.c.orig	Fri Jul 12 12:06:45 2002
+++ pw_util.c	Fri Jul 12 12:07:25 2002
@@ -149,7 +149,7 @@
 	char *p;
 
 	strncpy(path, masterpasswd, MAXPATHLEN - 1);
-	path[MAXPATHLEN] = '\0';
+	path[MAXPATHLEN - 1] = '\0';
 
 	if ((p = strrchr(path, '/')))
 		++p;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Sat Jul 13 14:44:05 PDT 2002 
Responsible-Changed-Why:  
This belongs to freebsd-bugs. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40492 
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: des 
Responsible-Changed-When: Sat Jul 13 14:47:06 PDT 2002 
Responsible-Changed-Why:  
My rutf. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40492 

From: Dag-Erling Smorgrav <des@ofug.org>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: bin/40492
Date: 14 Jul 2002 15:00:23 +0200

 It's not a buffer overflow, and it's not exploitable, but thanks
 anyway for bringing this to our attention.  I'll commit a similar
 patch to -STABLE later today.
 
 DES
 -- 
 Dag-Erling Smorgrav - des@ofug.org
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Sun Jul 14 06:12:13 PDT 2002 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40492 
>Unformatted:
