From dan@kolej.mff.cuni.cz  Mon Jul  8 06:39:48 2002
Return-Path: <dan@kolej.mff.cuni.cz>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7708B37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Jul 2002 06:39:48 -0700 (PDT)
Received: from smtp.kolej.mff.cuni.cz (smtp.kolej.mff.cuni.cz [195.113.25.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AFDA643E42
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Jul 2002 06:39:46 -0700 (PDT)
	(envelope-from dan@kolej.mff.cuni.cz)
Received: from dan.kolej.mff.cuni.cz (dan.kolej.mff.cuni.cz [195.113.21.110])
	by smtp.kolej.mff.cuni.cz (8.11.6/8.11.6) with ESMTP id g68Ddmh50997
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 8 Jul 2002 15:39:48 +0200 (CEST)
	(envelope-from dan@kolej.mff.cuni.cz)
Received: from kolej.mff.cuni.cz (localhost [127.0.0.1])
	by dan.kolej.mff.cuni.cz (8.12.4/8.12.4) with ESMTP id g68DdibI086225
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 8 Jul 2002 15:39:44 +0200 (CEST)
	(envelope-from dan@kolej.mff.cuni.cz)
Received: (from root@localhost)
	by kolej.mff.cuni.cz (8.12.4/8.12.5/Submit) id g68Ddivo086224;
	Mon, 8 Jul 2002 15:39:44 +0200 (CEST)
Message-Id: <200207081339.g68Ddivo086224@kolej.mff.cuni.cz>
Date: Mon, 8 Jul 2002 15:39:44 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] share/sendmail/Makefile doesn't honor the $COPY
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40340
>Category:       bin
>Synopsis:       [PATCH] share/sendmail/Makefile doesn't honor the $COPY
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 08 06:40:03 PDT 2002
>Closed-Date:    Fri Jul 19 01:15:51 PDT 2002
>Last-Modified:  Fri Jul 19 01:15:51 PDT 2002
>Originator:     Dan Lukes
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
Obludarium
>Environment:
src/share/sendmail/Makefile,v 1.1.2.4 2001/06/04 18:24:05 
src/etc/defaults/make.conf,v 1.97.2.68 2002/07/02 05:07:23


>Description:
	The defaults/make.conf contain following:
# Compare before install
#INSTALL=install -C

	Uncommenting it broke those Makefiles that use ${INSTALL} -d to
create directories - for example share/sendmail/Makefile 

	The COPY=-C should be suggested in make.conf instead.

	sendmail's Makefile doesn't honor the COPY value, so we should
correct it also.
		
>How-To-Repeat:
	N/A
>Fix:
*** etc/defaults/make.conf.ORIG	Sun Jul  7 10:21:10 2002
--- etc/defaults/make.conf	Mon Jul  8 15:33:54 2002
***************
*** 75,81 ****
  #COPTFLAGS= -O -pipe
  #
  # Compare before install
! #INSTALL=install -C
  #
  # To enable installing suidperl with the setuid bit turned on
  #ENABLE_SUIDPERL=	true
--- 75,81 ----
  #COPTFLAGS= -O -pipe
  #
  # Compare before install
! #COPY=-C
  #
  # To enable installing suidperl with the setuid bit turned on
  #ENABLE_SUIDPERL=	true
*** share/sendmail/Makefile.ORIG	Tue Jun  5 09:49:22 2001
--- share/sendmail/Makefile	Mon Jul  8 15:19:52 2002
***************
*** 26,32 ****
  	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 755 -d ${DDIR}/${dir}
  .endfor
  .for file in ${CFFILES}
! 	${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 444 ${SENDMAIL_DIR}/${file} ${DDIR}/${file}
  .endfor
  
  symlinks::
--- 26,32 ----
  	${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 755 -d ${DDIR}/${dir}
  .endfor
  .for file in ${CFFILES}
! 	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m 444 ${SENDMAIL_DIR}/${file} ${DDIR}/${file}
  .endfor
  
  symlinks::


>Release-Note:
>Audit-Trail:

From: Dan Lukes <dan@obluda.cz>
To: freebsd-gnats-submit@FreeBSD.org, dan@obluda.cz
Cc:  
Subject: Re: bin/40340: [PATCH] share/sendmail/Makefile doesn't honor the
 $COPY
Date: Thu, 18 Jul 2002 18:50:05 +0200

 	Suggested PATCHes are applied already, so you can close this PR.
 
 							Dan
 
 
 -- 
 Dan Lukes      tel: +420 2 21914205, fax: +420 2 21914206
 root  of FIONet,  KolejNET,  webmaster  of www.freebsd.cz
 AKA: dan@obluda.cz, dan@freebsd.cz, dan@kolej.mff.cuni.cz
 
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Fri Jul 19 01:13:29 PDT 2002 
State-Changed-Why:  
ru committed the patch, thanks for the submission. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40340 
>Unformatted:
