From dan@obluda.cz  Mon Jun 24 19:05:44 2002
Return-Path: <dan@obluda.cz>
Received: from xkulesh.vol.cz (xkulesh.vol.cz [195.250.154.106])
	by hub.freebsd.org (Postfix) with ESMTP id 736CA37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2002 19:05:39 -0700 (PDT)
Received: from obluda.cz (localhost [127.0.0.1])
	by xkulesh.vol.cz (8.12.3/8.12.3) with ESMTP id g5P25aTv054187
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Jun 2002 04:05:37 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by xkulesh.vol.cz (8.12.4/8.12.4/Submit) id g5P1WlwR053123;
	Tue, 25 Jun 2002 03:32:47 +0200 (CEST)
Message-Id: <200206250132.g5P1WlwR053123@xkulesh.vol.cz>
Date: Tue, 25 Jun 2002 03:32:47 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: cleaning bin/sh code from warnings
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39818
>Category:       bin
>Synopsis:       cleaning sbin/atm code from warnings
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    harti
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 19:10:02 PDT 2002
>Closed-Date:    Wed Jul 30 08:56:10 PDT 2003
>Last-Modified:  Wed Jul 30 08:56:10 PDT 2003
>Originator:     Dan Lukes
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD xkulesh.vol.cz 4.6-STABLE FreeBSD
sbin/atm/fore_dnld/fore_dnld.c,v 1.6.2.2 2000/12/11 01:03:24

>Description:
I want to clean some warnings from code.

sbin/atm/fore_dnld/fore_dnld.c: In function `loadmicrocode':
689: warning: unused variable `cnt'
688: warning: unused variable `n'

'cnt' is really unused, 'n' is used in sun's part of code only
----
/usr/src/sbin/atm/fore_dnld/fore_dnld.c: In function `main':
1341: warning: unsigned int format, u_long arg (arg 2)
1349: warning: unsigned int format, u_long arg (arg 2)
1349: warning: unsigned int format, u_long arg (arg 3)

unsigned LONG's hb1,hb2,hb3 printf'ed as %x

>How-To-Repeat:
	N/A
>Fix:

--- fore_dnld/fore_dnld.c.ORIG  Sat Dec 16 23:44:09 2000
+++ fore_dnld/fore_dnld.c       Tue Jun 25 03:08:51 2002
@@ -684,9 +684,8 @@
                u_long  w;
                char    c[4];
        } w1, w2;
-#endif
        int     n;
-       int     cnt = 0;
+#endif
        u_char  *bufp;
        u_long  *lp;
@@ -1338,7 +1337,7 @@
                                hb3 = CP_READ(Mon->mon_bstat);
                                if (hb3 != BOOT_RUNNING) {
                                        if (verbose)
-                                               printf("bstat %x\n", hb3);
+                                               printf("bstat %lx\n", hb3);
                                        continue;
                                }
@@ -1346,7 +1345,7 @@
                                delay(1);
                                hb2 = CP_READ(aap->aali_heartbeat);
                                if (verbose)
-                                       printf("hb %x %x\n", hb1, hb2);
+                                       printf("hb %lx %lx\n", hb1, hb2);
                                if (hb1 < hb2)
                                        break;
                             }
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->johan 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sun Apr 13 09:20:38 PDT 2003 
Responsible-Changed-Why:  
I'll take a look at this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39818 
Responsible-Changed-From-To: johan->harti 
Responsible-Changed-By: johan 
Responsible-Changed-When: Wed Jul 30 02:44:10 PDT 2003 
Responsible-Changed-Why:  
Over to atm maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39818 
State-Changed-From-To: open->closed 
State-Changed-By: harti 
State-Changed-When: Wed Jul 30 08:55:47 PDT 2003 
State-Changed-Why:  
Patch comitted to -current. MFC will follow. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39818 
>Unformatted:
