From redpixel@lockdown.spectrum.fearmuffs.net  Fri Jun 14 14:42:12 2002
Return-Path: <redpixel@lockdown.spectrum.fearmuffs.net>
Received: from lockdown.spectrum.fearmuffs.net (c164-147.pro.thalamus.se [212.31.164.147])
	by hub.freebsd.org (Postfix) with ESMTP id 745C637B485
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Jun 2002 14:41:15 -0700 (PDT)
Received: from lockdown.spectrum.fearmuffs.net (localhost.spectrum.fearmuffs.net [127.0.0.1])
	by lockdown.spectrum.fearmuffs.net (8.12.3/8.12.3) with ESMTP id g5ELFpdu002844
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Jun 2002 23:15:51 +0200 (CEST)
	(envelope-from redpixel@lockdown.spectrum.fearmuffs.net)
Received: (from redpixel@localhost)
	by lockdown.spectrum.fearmuffs.net (8.12.3/8.12.3/Submit) id g5ELFo47002843;
	Fri, 14 Jun 2002 23:15:50 +0200 (CEST)
	(envelope-from redpixel)
Message-Id: <200206142115.g5ELFo47002843@lockdown.spectrum.fearmuffs.net>
Date: Fri, 14 Jun 2002 23:15:50 +0200 (CEST)
From: Martin Faxer <gmh003532@brfmasthugget.se>
Reply-To: Martin Faxer <gmh003532@brfmasthugget.se>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: you can't enable inetd in sysinstall without editing inetd.conf 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39311
>Category:       bin
>Synopsis:       you can't enable inetd in sysinstall without editing inetd.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rwatson
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 14 14:50:01 PDT 2002
>Closed-Date:    Sun Aug 17 15:03:22 PDT 2003
>Last-Modified:  Sun Aug 17 15:03:22 PDT 2003
>Originator:     Martin Faxer
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
none 
>Environment:
System: FreeBSD lockdown.spectrum.fearmuffs.net 5.0-CURRENT FreeBSD 5.0-CURRENT #11: Fri Jun 14 14:02:42 CEST 2002 redpixel@lockdown.spectrum.fearmuffs.net:/usr/obj/usr/src/sys/LOCKDOWN i386


	
>Description:
in sysinstall, if you try to enable inetd you are faced with a dialog box
asking you whether you want to edit inetd.conf or use the standard settings.
if you choose to use the standard settings (ie. press [no]) inetd will not
be enabled due to a misplaced variable_set2() call.

	
>How-To-Repeat:
try to enable inetd without first editing inetd.conf

	
>Fix:
apply the patch below:
	

--- sysinstall.diff begins here ---
Index: config.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/sysinstall/config.c,v
retrieving revision 1.202
diff -u -r1.202 config.c
--- config.c	10 Jun 2002 04:47:26 -0000	1.202
+++ config.c	14 Jun 2002 21:12:08 -0000
@@ -933,6 +933,7 @@
     } else {
         /* If inetd is enabled, we'll need an inetd.conf */
 
+	variable_set2("inetd_enable", "YES", 1);
 	if (!msgYesNo("inetd(8) relies on its configuration file, /etc/inetd.conf, to determine\n"
                    "which of its Internet services will be available.  The default FreeBSD\n"
                    "inetd.conf(5) leaves all services disabled by default, so they must be\n"
@@ -944,7 +945,6 @@
             sprintf(cmd, "%s /etc/inetd.conf", variable_get(VAR_EDITOR));
             dialog_clear();
             systemExecute(cmd);
-            variable_set2("inetd_enable", "YES", 1);
 	}
     }
     restorescr(w);
--- sysinstall.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->re 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Fri Jun 14 16:01:49 PDT 2002 
Responsible-Changed-Why:  

Sounds like something that might want to be addressed before the 
release, if possible. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39311 
Responsible-Changed-From-To: re->qa 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Fri Jul 19 04:07:56 PDT 2002 
Responsible-Changed-Why:  
re@freebsd.org feel that qa@freebsd.org is a better person to assign 
sysinstall PRs to. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39311 
Responsible-Changed-From-To: qa->rwatson 
Responsible-Changed-By: rwatson 
Responsible-Changed-When: Wed Feb 5 15:29:55 PST 2003 
Responsible-Changed-Why:  
Claimed, testing patch and will commit shortly. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=39311 
State-Changed-From-To: open->closed 
State-Changed-By: rwatson 
State-Changed-When: Sun Aug 17 14:37:40 PDT 2003 
State-Changed-Why:  
Original fix to -CURRENT was merged on 2003/02/06 as 
src/usr.sbin/sysinstall/config.c:1.209.  Just MFC'd fix to RELENG_4 as 
src/release/sysinstall/config.c:1.156.2.33. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=39311 
>Unformatted:
