From joes@joes.users.spiritone.com  Mon Jun  9 13:41:18 1997
Received: from ridge.spiritone.com (ridge.spiritone.com [205.139.108.2])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id NAA13569
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Jun 1997 13:41:16 -0700 (PDT)
Received: from joes.users.spiritone.com (joes.users.spiritone.com [205.139.111.224])
	by ridge.spiritone.com (8.8.5/8.8.5) with ESMTP id NAA00781
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Jun 1997 13:40:44 -0700 (PDT)
Received: (from joes@localhost)
	by joes.users.spiritone.com (8.8.5/8.8.6.Beta4) id NAA11811;
	Mon, 9 Jun 1997 13:20:54 -0700 (PDT)
Message-Id: <199706092020.NAA11811@joes.users.spiritone.com>
Date: Mon, 9 Jun 1997 13:20:54 -0700 (PDT)
From: Joseph Stein <joes@spiritone.com>
Reply-To: joes@spiritone.com
To: FreeBSD-gnats-submit@freebsd.org, joes@joes.users.spiritone.com
Subject: login_cap.c (libutil) doesn't recognize [Yy][Ww] for years/weeks
X-Send-Pr-Version: 3.2

>Number:         3820
>Category:       bin
>Synopsis:       login_cap.c (libutil) doesn't recognize [Yy][Ww] for years/weeks
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun  9 13:50:01 PDT 1997
>Closed-Date:    Sat Jun 14 08:28:32 EST 1997
>Last-Modified:  Sat Jun 14 08:32:13 EST 1997
>Originator:     Joseph Stein
>Release:        FreeBSD 2.2-STABLE i386
>Organization:
>Environment:

FreeBSD joes.users.spiritone.com 2.2-STABLE FreeBSD 2.2-STABLE #0: Sun Jun  8 12:04:26 PDT 1997     joes@joes.users.spiritone.com:/usr/src/sys/compile/S_ISDN  i386

Sources CVSup'd Jun 7 circa 19:00 hrs.

>Description:


The login capabilities database returns the following error:
Jun  9 12:53:00 joes passwd: login_getcaptime: class 'subshell' bad value passwordperiod=4w

when passwords are changed.  man 5 login.conf specifies that you should be
able to specify weeks with [w] and years with [y]; login_cap.c specifies
that you can use either [Ww] or [Yy] safely (at least right now :)

>How-To-Repeat:

Make your login.conf database have a 'passwordperiod' equal to a certain
number of days, or years.  (passwordperiod=4w).
Change your password.
You'll get the above error message (and your password will not expire).

>Fix:

The code that scans for the 'y' or 'w' falls through to the next case because
it is lacking break; statements.
(Is that intentional?)

Index: src/lib/libutil/login_cap.c
===================================================================
RCS file: /usr/cvs/src/lib/libutil/login_cap.c,v
retrieving revision 1.12.2.1
diff -r1.12.2.1 login_cap.c
559a560
> 	    break;
561a563
> 	    break;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: davidn 
State-Changed-When: Sat Jun 14 08:28:32 EST 1997 
State-Changed-Why:  
Patch applied to -current and 2.2 branches: 
/home/ncvs/src/lib/libutil/login_cap.c,v  <--  login_cap.c  
new revision: 1.14; previous revision: 1.13                 
/home/ncvs/src/lib/libutil/login_cap.c,v  <--  login_cap.c  
new revision: 1.12.2.2; previous revision: 1.12.2.1         
>Unformatted:
