From dgilbert@velocet.ca  Mon Apr 29 05:50:10 2002
Return-Path: <dgilbert@velocet.ca>
Received: from sabre.velocet.net (sabre.velocet.net [216.138.209.205])
	by hub.freebsd.org (Postfix) with ESMTP id 3A79137B404
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 29 Apr 2002 05:50:07 -0700 (PDT)
Received: from trooper.velocet.ca (trooper.velocet.net [216.138.242.2])
	by sabre.velocet.net (Postfix) with ESMTP id 4D5B413805F
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 29 Apr 2002 08:50:06 -0400 (EDT)
Received: by trooper.velocet.ca (Postfix, from userid 101)
	id 22311239C; Mon, 29 Apr 2002 08:50:06 -0400 (EDT)
Message-Id: <20020429125006.22311239C@trooper.velocet.ca>
Date: Mon, 29 Apr 2002 08:50:06 -0400 (EDT)
From: David Gilbert <dgilbert@velocet.ca>
Reply-To: David Gilbert <dgilbert@velocet.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         37566
>Category:       bin
>Synopsis:       src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 29 06:00:03 PDT 2002
>Closed-Date:    Sat May 18 21:13:22 PDT 2002
>Last-Modified:  Sat May 18 21:13:22 PDT 2002
>Originator:     David Gilbert
>Release:        FreeBSD 4.5-RELEASE-p4
>Organization:
Velocet Communications
>Environment:
System: FreeBSD canoe.velocet.net 4.5-RELEASE-p4 FreeBSD 4.5-RELEASE-p4 #1: Tue Apr 23 16:11:40 EDT 2002     dgilbert@canoe.velocet.net:/usr/src/sys/compile/CANOE  i386

I'm following the RELENG_4_5 branch
>Description:
In only RELENG_4_5, the file nl_langinfo.c is missing.  It prevents
/usr/ports/x11-toolkits/gal from compiling ... which, in turn,
prevents many other ports from compiling.
>How-To-Repeat:
cvsup to RELENG_4_5
make world
then try to make in /usr/ports/x11-toolkits/gal
>Fix:

Apply the same patch as 1.13.2.3 to the RELENG_4_5 branch


>Release-Note:
>Audit-Trail:

From: Alexey Zelkin <phantom@FreeBSD.ORG>
To: David Gilbert <dgilbert@velocet.ca>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
Date: Mon, 29 Apr 2002 20:55:15 +0300

 hi,
 
 On Mon, Apr 29, 2002 at 08:50:06AM -0400, David Gilbert wrote:
 > 
 > >Number:         37566
 > >Category:       bin
 > >Synopsis:       src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
 
 > >Description:
 > In only RELENG_4_5, the file nl_langinfo.c is missing.  It prevents
 > /usr/ports/x11-toolkits/gal from compiling ... which, in turn,
 > prevents many other ports from compiling.
 > >How-To-Repeat:
 > cvsup to RELENG_4_5
 > make world
 > then try to make in /usr/ports/x11-toolkits/gal
 > >Fix:
 > 
 > Apply the same patch as 1.13.2.3 to the RELENG_4_5 branch
 
 It's not possible to just merge this revision since adding this function
 require many locale specific merges as well. I think port itself should
 be fixed. BTW, how it compiles for 4.5 and more earlies releases which
 also not have nl_langinfo() ?
 
 PS: Actually since it's not a security fix, I doubt that security officer
 will approve this addition :-(
 

From: David Gilbert <dgilbert@velocet.ca>
To: Alexey Zelkin <phantom@FreeBSD.ORG>
Cc: David Gilbert <dgilbert@velocet.ca>,
	FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
Date: Mon, 29 Apr 2002 17:30:20 -0400

 >>>>> "Alexey" == Alexey Zelkin <phantom@FreeBSD.ORG> writes:
 
 Alexey> hi, On Mon, Apr 29, 2002 at 08:50:06AM -0400, David Gilbert
 Alexey> wrote:
 >>  >Number: 37566 >Category: bin >Synopsis:
 >> src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
 
 >> >Description: In only RELENG_4_5, the file nl_langinfo.c is
 >> missing.  It prevents /usr/ports/x11-toolkits/gal from compiling
 >> ... which, in turn, prevents many other ports from compiling.
 >> >How-To-Repeat: cvsup to RELENG_4_5 make world then try to make in
 >> /usr/ports/x11-toolkits/gal >Fix:
 >> 
 >> Apply the same patch as 1.13.2.3 to the RELENG_4_5 branch
 
 Alexey> It's not possible to just merge this revision since adding
 Alexey> this function require many locale specific merges as well. I
 Alexey> think port itself should be fixed. BTW, how it compiles for
 Alexey> 4.5 and more earlies releases which also not have
 Alexey> nl_langinfo() ?
 
 Alexey> PS: Actually since it's not a security fix, I doubt that
 Alexey> security officer will approve this addition :-(
 
 Well... you could also back out 1.13.2.1 ...
 
 Problem is: 1.13 works, 1.13.2.1 doesn't work (4.5-RELEASE), 1.13.2.2
 works.
 
 it would appear that the null function is sufficient, but it was
 removed.  Without even the null function, gal fails to compile.
 
 Dave.
 
 -- 
 ============================================================================
 |David Gilbert, Velocet Communications.       | Two things can only be     |
 |Mail:       dgilbert@velocet.net             |  equal if and only if they |
 |http://daveg.ca                              |   are precisely opposite.  |
 =========================================================GLO================

From: Alexey Zelkin <phantom@FreeBSD.ORG>
To: David Gilbert <dgilbert@velocet.ca>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
Date: Tue, 30 Apr 2002 14:04:09 +0300

 hi,
 
 On Mon, Apr 29, 2002 at 05:30:20PM -0400, David Gilbert wrote:
 
 > Alexey> It's not possible to just merge this revision since adding
 > Alexey> this function require many locale specific merges as well. I
 > Alexey> think port itself should be fixed. BTW, how it compiles for
 > Alexey> 4.5 and more earlies releases which also not have
 > Alexey> nl_langinfo() ?
 > 
 > Alexey> PS: Actually since it's not a security fix, I doubt that
 > Alexey> security officer will approve this addition :-(
 > 
 > Well... you could also back out 1.13.2.1 ...
 > 
 > Problem is: 1.13 works, 1.13.2.1 doesn't work (4.5-RELEASE), 1.13.2.2
 > works.
 I not sure in exact problem you have, but looking for dates
 1.13.2.2 (2001/11/02) was committed two months before 4.5-RELEASE.
 
 > it would appear that the null function is sufficient, but it was
 > removed.  Without even the null function, gal fails to compile.
 
 : $ cvs log nl_langinfo.c
 [dd]
 :        RELENG_4_5_0_RELEASE: 1.13.2.2
 :        RELENG_4_5: 1.13.2.2.0.2
 :        RELENG_4_5_BP: 1.13.2.2
 :        RELENG_4: 1.13.0.2
 [dd]
 : revision 1.13.2.2
 : date: 2001/11/07 04:50:32;  author: ache;  state: dead;  lines: +1 -1
 : Back out fake nl_langinfo() stub addition, it breaks configure for ports
 : programs badly. Better way is to merge its full variant and as result
 : full locale from -current.
 : ----------------------------
 : revision 1.13.2.1
 : date: 2001/11/02 19:42:07;  author: obrien;  state: Exp;  lines: +5 -166
 : Add a NOP nl_langinfo().  The purpose is to get an "nl_langinfo" symbol
 : into libc for some minor compatibility with 5-CURRENT binaries.  Its
 : external exposure is kept down to a minium.
 : If one ln's libc.so.4 to libc.so.5 a surprising number of 5-CURRENT binaries
 : will run on RELENG_4.
 
 From this log you can see why NOP nl_langinfo() was added and why was backed
 out. Also you can see that nl_langinfo.c file should not be present
 at RELENG_4_5 branch.
 

From: David Gilbert <dgilbert@velocet.ca>
To: Alexey Zelkin <phantom@FreeBSD.ORG>
Cc: David Gilbert <dgilbert@velocet.ca>,
	FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
Date: Tue, 30 Apr 2002 10:22:09 -0400

 >>>>> "Alexey" == Alexey Zelkin <phantom@FreeBSD.ORG> writes:
 
 >> From this log you can see why NOP nl_langinfo() was added and why
 >> was backed
 Alexey> out. Also you can see that nl_langinfo.c file should not be
 Alexey> present at RELENG_4_5 branch.
 
 I'm quite capable of grovelling trough cvs logs and have become quite
 familliar with this little portion of the tree as of late.
 
 Maybe this needs to be drawn to the attention of the x11-toolkits/gal
 portmaster, then.  It won't build without it... meaning (that AFAICT)
 gnome (and associated applications) won't build under 4.5-RELEASE.
 
 Now this could also be that someone on the cvsup upgrade path is what
 causes it and the virgin install doesn't, but if this is the case,
 someone needs to fix it too.  I've been all over the include files
 looking for clues and references to nl_langinfo ... and there don't
 appear to be any.
 
 I don't think this problem is easily dismissed.
 
 Dave.
 
 -- 
 ============================================================================
 |David Gilbert, Velocet Communications.       | Two things can only be     |
 |Mail:       dgilbert@velocet.net             |  equal if and only if they |
 |http://daveg.ca                              |   are precisely opposite.  |
 =========================================================GLO================

From: Alexey Zelkin <phantom@FreeBSD.ORG>
To: David Gilbert <dgilbert@velocet.ca>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in 4.5.x
Date: Tue, 30 Apr 2002 18:06:03 +0300

 hi,
 
 On Tue, Apr 30, 2002 at 10:22:09AM -0400, David Gilbert wrote:
 
 > >> From this log you can see why NOP nl_langinfo() was added and why
 > >> was backed
 > Alexey> out. Also you can see that nl_langinfo.c file should not be
 > Alexey> present at RELENG_4_5 branch.
 > 
 > I'm quite capable of grovelling trough cvs logs and have become quite
 > familliar with this little portion of the tree as of late.
 > 
 > Maybe this needs to be drawn to the attention of the x11-toolkits/gal
 > portmaster, then.  It won't build without it... meaning (that AFAICT)
 > gnome (and associated applications) won't build under 4.5-RELEASE.
 Can you check -- will it build for 4.4 or earlier release ?
 
 > Now this could also be that someone on the cvsup upgrade path is what
 > causes it and the virgin install doesn't, but if this is the case,
 > someone needs to fix it too.  I've been all over the include files
 > looking for clues and references to nl_langinfo ... and there don't
 > appear to be any.
 src/include/langinfo.h
 
 > I don't think this problem is easily dismissed.
 
 I'd suggest you to contact gal port maintainer. You only person who has
 reported such kind of breakage and I can't realize way how this breakage
 appear to you :-(
 
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports 
Responsible-Changed-By: johan 
Responsible-Changed-When: Wed May 1 17:06:42 PDT 2002 
Responsible-Changed-Why:  
Bounce this via ports on the way to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37566 
Responsible-Changed-From-To: freebsd-ports->gnome 
Responsible-Changed-By: johan 
Responsible-Changed-When: Wed May 1 17:07:31 PDT 2002 
Responsible-Changed-Why:  
Over to gal maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37566 

From: Joe Marcus Clarke <marcus@marcuscom.com>
To: freebsd-gnats-submit@FreeBSD.org, dgilbert@velocet.ca
Cc:  
Subject: Re: bin/37566: src/lib/libc/locale/nl_langinfo.c removed only in
	4.5.x
Date: 02 May 2002 02:50:01 -0300

 --=-O1U9Hs0D7MWItk898WQR
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 I'm not seeing this problem with -stable and the latest version of gal
 (gal-0.19.1).  Can you send the output of the build?  Thanks.
 
 Joe
 
 
 
 --=-O1U9Hs0D7MWItk898WQR
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (FreeBSD)
 Comment: For info see http://www.gnupg.org
 
 iEYEABECAAYFAjzQ04kACgkQb2iPiv4Uz4dnlwCdEgaDhaBA+3bRW8B7kdDqLjkG
 usgAoIjbD297FYCehFOLPFeNAcFRYSOy
 =5vLq
 -----END PGP SIGNATURE-----
 
 --=-O1U9Hs0D7MWItk898WQR--
 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat May 18 21:11:55 PDT 2002 
State-Changed-Why:  
Timeout from submitter, and gal 0.19.2 is compiling just fine on 4.6-RC.  There 
has not been any langinfo.h related failures reported for gal, either. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37566 
>Unformatted:
