From skyhawk@00-50-ba-d8-55-9a.bconnected.net  Sun Apr 28 22:54:59 2002
Return-Path: <skyhawk@00-50-ba-d8-55-9a.bconnected.net>
Received: from 00-50-ba-d8-55-9a.bconnected.net (00-50-ba-d8-55-9a.bconnected.net [209.53.37.24])
	by hub.freebsd.org (Postfix) with SMTP id 65A9837B405
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 28 Apr 2002 22:54:58 -0700 (PDT)
Received: (qmail 38039 invoked by uid 1000); 29 Apr 2002 06:00:14 -0000
Message-Id: <20020429060014.38038.qmail@00-50-ba-d8-55-9a.bconnected.net>
Date: 29 Apr 2002 06:00:14 -0000
From: Andrew Fremantle <skyhawk@skyhawk.ca>
Reply-To: Andrew Fremantle <skyhawk@skyhawk.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Segfault in /usr/bin/ee
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         37552
>Category:       bin
>Synopsis:       Segfault in /usr/bin/ee
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 28 23:00:03 PDT 2002
>Closed-Date:    Sun May 05 17:31:16 PDT 2002
>Last-Modified:  Sun May 05 17:31:16 PDT 2002
>Originator:     Andrew Fremantle
>Release:        FreeBSD 4.5-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD 00-50-ba-d8-55-9a.bconnected.net 4.5-RELEASE-p2 FreeBSD 4.5-RELEASE-p2 #1: Tue Mar 26 23:23:21 PST 2002 skyhawk@00-50-ba-d8-55-9a.bconnected.net:/usr/obj/usr/src/sys/INCOM i386


	
>Description:
	When ee is started with certain settings, going into the menu and turning on "Display Menu"
	results in a segfault.
>How-To-Repeat:
	Start with a clean ee (get rid of ~/.init.ee)
	Set the following options in ee's menu : emacs-bindings off, info window off.
	Save the configuration. Quit ee and fire it up again.
	Now, go into the menu and turn on "Info Window", press ESC and look at the pretty segfault.
>Fix:
	Unfortunately, I can't code to save my life, so all I can do is point you
	developer type people at the problem. Please let me know if I can be of more assistance.



>Release-Note:
>Audit-Trail:

From: Andrew Fremantle <skyhawk@skyhawk.ca>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: bin/37552: Segfault in /usr/bin/ee
Date: 29 Apr 2002 06:00:14 -0000

 >Number:         37552
 >Category:       bin
 >Synopsis:       Segfault in /usr/bin/ee
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Sun Apr 28 23:00:03 PDT 2002
 >Closed-Date:
 >Last-Modified:
 >Originator:     Andrew Fremantle
 >Release:        FreeBSD 4.5-RELEASE-p2 i386
 >Organization:
 >Environment:
 System: FreeBSD 00-50-ba-d8-55-9a.bconnected.net 4.5-RELEASE-p2 FreeBSD 4.5-RELEASE-p2 #1: Tue Mar 26 23:23:21 PST 2002 skyhawk@00-50-ba-d8-55-9a.bconnected.net:/usr/obj/usr/src/sys/INCOM i386
 
 
 	
 >Description:
 	When ee is started with certain settings, going into the menu and turning on "Display Menu"
 	results in a segfault.
 >How-To-Repeat:
 	Start with a clean ee (get rid of ~/.init.ee)
 	Set the following options in ee's menu : emacs-bindings off, info window off.
 	Save the configuration. Quit ee and fire it up again.
 	Now, go into the menu and turn on "Info Window", press ESC and look at the pretty segfault.
 >Fix:
 	Unfortunately, I can't code to save my life, so all I can do is point you
 	developer type people at the problem. Please let me know if I can be of more assistance.
 
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message
 

From: Mark Valentine <mark@thuvia.demon.co.uk>
To: skyhawk@skyhawk.ca (Andrew Fremantle),
	freebsd-gnats-submit@freebsd.org
Cc: sobomax@freebsd.org
Subject: Re: bin/37552: Segfault in /usr/bin/ee
Date: Tue, 30 Apr 2002 05:08:20 +0100 (BST)

 The following patch seems to fix it on my FreeBSD 4.5-STABLE system.
 
 count_win was only ever being set up with info_win at startup, and not
 when info_win is re-created from the menu options.
 
 count_win doesn't seem to exist in the vendor's latest version (1.4.5a).
 
 		Cheers,
 
 		Mark.
 
 Index: ee.c
 ===================================================================
 RCS file: /usr/cvs/src/usr.bin/ee/ee.c,v
 retrieving revision 1.16.2.5
 diff -u -r1.16.2.5 ee.c
 --- ee.c	1 Sep 2001 16:35:45 -0000	1.16.2.5
 +++ ee.c	30 Apr 2002 03:53:10 -0000
 @@ -3692,6 +3692,9 @@
  	midscreen(min(scr_vert, last_line), point);
  	clearok(info_win, TRUE);
  	paint_info_win();
 +	count_win = newwin(1, COLS, 5, 0);
 +	leaveok(count_win, TRUE);
 +	wrefresh(count_win);
  	wrefresh(text_win);
  	clear_com_win = TRUE;
  }
 
 -- 
 Mark Valentine, Thuvia Labs <mark@thuvia.co.uk>       <http://www.thuvia.co.uk>
 "Tigers will do ANYTHING for a tuna fish sandwich."       Mark Valentine uses
 "We're kind of stupid that way."   *munch* *munch*        and endorses FreeBSD
   -- <http://www.calvinandhobbes.com>                  <http://www.freebsd.org>
Responsible-Changed-From-To: freebsd-bugs->mp 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Mon Apr 29 21:15:26 PDT 2002 
Responsible-Changed-Why:  

Nail the last person foolish enough to commit to ee.c. :) 
If you don't want this pr, feel free to give it to someone 
else, or set it back to freebsd-bugs. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37552 
State-Changed-From-To: open->closed 
State-Changed-By: mp 
State-Changed-When: Sun May 5 17:29:50 PDT 2002 
State-Changed-Why:  
Thanks for the patch. Applied to -current and awaiting MFC approval from re. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37552 
>Unformatted:
