From nobody@FreeBSD.org  Fri Dec 28 01:16:51 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id D693337B416
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Dec 2001 01:16:50 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fBS9Go592203;
	Fri, 28 Dec 2001 01:16:50 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200112280916.fBS9Go592203@freefall.freebsd.org>
Date: Fri, 28 Dec 2001 01:16:50 -0800 (PST)
From: Hiroyuki YAMAMORI <h-yamamo@db3.so-net.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ftpd: memory leak at EPRT
X-Send-Pr-Version: www-1.0

>Number:         33268
>Category:       bin
>Synopsis:       ftpd: memory leak at EPRT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dwmalone
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 28 01:20:01 PST 2001
>Closed-Date:    Sat Feb 16 06:02:16 PST 2002
>Last-Modified:  Sat Feb 16 06:02:42 PST 2002
>Originator:     Hiroyuki YAMAMORI
>Release:        
>Organization:
>Environment:
>Description:
Not free EPRT arg.
>How-To-Repeat:

>Fix:
--- src/libexec/ftpd/ftpcmd.y_1.28      Fri Dec 28 17:53:10 2001
+++ src/libexec/ftpd/ftpcmd.y   Fri Dec 28 17:56:02 2001
@@ -313,7 +313,9 @@
                        if (port_check_v6("EPRT") == 1)
                                goto eprt_done;
 #endif
-               eprt_done:;
+               eprt_done:
+                       if ($4 != NULL)
+                               free($4);
                }
        | PASV check_login CRLF
                {

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Sat Dec 29 07:56:55 PST 2001 
Responsible-Changed-Why:  
I'll have a look at this - there seem to be several memory leaks like this. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33268 
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Sat Feb 16 06:02:16 PST 2002 
State-Changed-Why:  
Should now be fixed in -current and -stable. Thanks for sending the 
patch. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33268 
>Unformatted:
