From charnier@xp11.frmug.org  Wed Apr  9 14:32:51 1997
Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id OAA19377
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 9 Apr 1997 14:31:21 -0700 (PDT)
Received: (from uucp@localhost)
	by frmug.org (8.8.5/8.8.5/frmug-2.0) with UUCP id XAA05359
	for FreeBSD-gnats-submit@freebsd.org; Wed, 9 Apr 1997 23:30:51 +0200 (MET DST)
Received: (from charnier@localhost)
	by xp11.frmug.org (8.8.5/8.8.5/xp11-uucp-1.1) id VAA13887;
	Wed, 9 Apr 1997 21:54:34 +0200 (CEST)
Message-Id: <199704091954.VAA13887@xp11.frmug.org>
Date: Wed, 9 Apr 1997 21:54:34 +0200 (CEST)
From: Philippe Charnier <charnier@xp11.frmug.org>
Reply-To: charnier@xp11.frmug.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: incorrect prototype for initgroups
X-Send-Pr-Version: 3.2

>Number:         3242
>Category:       bin
>Synopsis:       incorrect prototype for initgroups
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr  9 14:40:01 PDT 1997
>Closed-Date:    Tue Jan 22 09:43:50 PST 2002
>Last-Modified:  Tue Jan 22 09:47:01 PST 2002
>Originator:     Philippe Charnier
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	

>Description:

1)
     #include <unistd.h>

     int
     initgroups(const char *name, int basegid)

                                  ^^^ what about gid_t here?
                                    and in the function definition.
2)
     there is a typo in the man page: search for initgorups in BUGS section.

>How-To-Repeat:

>Fix:
	
>Release-Note:
>Audit-Trail:

From: David Nugent <davidn@unique.usn.blaze.net.au>
To: charnier@xp11.frmug.org
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/3242: incorrect prototype for initgroups
Date: Sun, 13 Apr 1997 10:32:44 +1000

 On Wed Apr  9 21:54:34 EST 1997, Philippe Charnier writes:
 > 1)
 >      #include <unistd.h>
 > 
 >      int
 >      initgroups(const char *name, int basegid)
 > 
 >                                   ^^^ what about gid_t here?
 >                                     and in the function definition.
 
 It should be the same type that is used in pwd.h for
 pwd.pw_gid which, currently, is 'int'.
 
 I believe that Bruce was looking into this one, since it
 had to do with the self-sufficiency of headers, but I've
 just noticed that both files now include sys/types.h
 unconditionally. Of course the type of pw_uid is also part
 of the question.
 
 Bruce?
 
 Regards,
 
 David Nugent - Unique Computing Pty Ltd - Melbourne, Australia
 Voice +61-3-9791-9547  Data/BBS +61-3-9792-3507  3:632/348@fidonet
 davidn@freebsd.org davidn@blaze.net.au http://www.blaze.net.au/~davidn/

From: Guy Helmer <ghelmer@cs.iastate.edu>
To: freebsd-gnats-submit@freebsd.org, charnier@xp11.frmug.org,
	bde@freebsd.org, davidn@freebsd.org
Cc:  
Subject: Re: bin/3242: incorrect prototype for initgroups
Date: Thu, 03 Jun 1999 21:37:18 -0500

 Should the type be changed to gid_t for the group ID?  pwd.h now defines
 the pw_gid field as a gid_t.
 
 Guy Helmer
 ghelmer@freebsd.org
 

From: Bruce Evans <bde@zeta.org.au>
To: bde@freebsd.org, charnier@xp11.frmug.org, davidn@freebsd.org,
	freebsd-gnats-submit@freebsd.org, ghelmer@cs.iastate.edu
Cc:  
Subject: Re: bin/3242: incorrect prototype for initgroups
Date: Fri, 4 Jun 1999 20:50:16 +1000

 >Should the type be changed to gid_t for the group ID?  pwd.h now defines
 >the pw_gid field as a gid_t.
 
 It should be changed.  Just be careful not to break anything due to the
 type becoming unsigned.  The implementation of initgroups() has some more
 type botches.  These bugs all seem to be fixed in NetBSD.
 
 Bruce
 
State-Changed-From-To: open->closed 
State-Changed-By: markm 
State-Changed-When: Tue Jan 22 09:43:50 PST 2002 
State-Changed-Why:  
Fixed, thanks! 



Responsible-Changed-From-To: freebsd-bugs->markm 
Responsible-Changed-By: markm 
Responsible-Changed-When: Tue Jan 22 09:43:50 PST 2002 
Responsible-Changed-Why:  
I (markm) committed the fix. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3242 
>Unformatted:
