From charnier@xp11.frmug.org  Sat Mar 15 15:09:25 1997
Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA14685
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Mar 1997 15:06:57 -0800 (PST)
Received: (from uucp@localhost)
	by frmug.org (8.8.5/8.8.5/frmug-2.0) with UUCP id AAA23591
	for FreeBSD-gnats-submit@freebsd.org; Sun, 16 Mar 1997 00:06:33 +0100 (MET)
Received: (from charnier@localhost)
	by xp11.frmug.org (8.8.5/8.8.5/xp11-uucp-1.1) id XAA05444;
	Sat, 15 Mar 1997 23:51:03 +0100 (CET)
Message-Id: <199703152251.XAA05444@xp11.frmug.org>
Date: Sat, 15 Mar 1997 23:51:03 +0100 (CET)
From: Philippe Charnier <charnier@xp11.frmug.org>
Reply-To: charnier@xp11.frmug.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: unterminated string after strncpy
X-Send-Pr-Version: 3.2

>Number:         2997
>Category:       bin
>Synopsis:       unterminated string after strncpy
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 15 15:10:04 PST 1997
>Closed-Date:    Fri May 9 18:01:31 MEST 1997
>Last-Modified:  Fri May  9 18:01:57 MEST 1997
>Originator:     Philippe Charnier
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	

>Description:

	

>How-To-Repeat:

	

>Fix:
	
Index: bin/rcp/rcp.c
===================================================================
RCS file: /home2h/FreeBSD.cvsroot/src/bin/rcp/rcp.c,v
retrieving revision 1.11
diff -u -r1.11 rcp.c
--- rcp.c	1997/02/22 14:05:22	1.11
+++ rcp.c	1997/03/12 22:11:13
@@ -131,7 +131,8 @@
 #ifdef	KERBEROS
 		case 'k':
 			dest_realm = dst_realm_buf;
-			(void)strncpy(dst_realm_buf, optarg, REALM_SZ);
+			(void)strncpy(dst_realm_buf, optarg, REALM_SZ - 1);
+			dst_realm_buf[REALM_SZ - 1] = '\0';
 			break;
 #ifdef CRYPT
 		case 'x':

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Fri May 9 18:01:31 MEST 1997 
State-Changed-Why:  
Suggested fix applied in rev 1.13 of rcp.c. 
Thanks for the fix! 
>Unformatted:
