From nobody@FreeBSD.org  Tue Jul  3 22:19:08 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4C2F037B405
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  3 Jul 2001 22:18:54 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f645Isv69420;
	Tue, 3 Jul 2001 22:18:54 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200107040518.f645Isv69420@freefall.freebsd.org>
Date: Tue, 3 Jul 2001 22:18:54 -0700 (PDT)
From: David Xu <davidx@viasoft.com.cn>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dead loop in vi
X-Send-Pr-Version: www-1.0

>Number:         28687
>Category:       bin
>Synopsis:       dead loop in vi
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    dd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 03 22:20:01 PDT 2001
>Closed-Date:    Mon Jul 30 17:03:46 PDT 2001
>Last-Modified:  Mon Jul 30 17:03:53 PDT 2001
>Originator:     David Xu
>Release:        FreeBSD 4.3-stable
>Organization:
Viasoft
>Environment:
FreeBSD cvs.viasoft.com.cn 4.3-STABLE FreeBSD 4.3-STABLE #0: Wed Jun 20 13:25:45
 CST 2001     root@cvs.viasoft.com.cn:/usr/obj/usr/src/sys/xu  i386
>Description:
start vi, set option leftright and number on, vi will be in dead loop,
uses 100% cpu time.

>How-To-Repeat:
$vi
:set leftright
:set number

blah, blah, ......

>Fix:
don't know
>Release-Note:
>Audit-Trail:

From: Dima Dorfman <dima@unixfreak.org>
To: David Xu <davidx@viasoft.com.cn>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/28687: dead loop in vi 
Date: Tue, 03 Jul 2001 23:01:35 -0700

 David Xu <davidx@viasoft.com.cn> writes:
 > >How-To-Repeat:
 > $vi
 > :set leftright
 > :set number
 
 Try this patch please:
 
 Index: vs_refresh.c
 ===================================================================
 RCS file: /stl/src/FreeBSD/src/contrib/nvi/vi/vs_refresh.c,v
 retrieving revision 1.2
 diff -u -r1.2 vs_refresh.c
 --- vs_refresh.c	1998/08/02 15:18:44	1.2
 +++ vs_refresh.c	2001/07/04 05:59:57
 @@ -595,7 +595,7 @@
  		 * for the number option offset.
  		 */
  		cnt = vs_columns(sp, NULL, LNO, &CNO, NULL);
 -		if (O_ISSET(sp, O_NUMBER))
 +		if (O_ISSET(sp, O_NUMBER) && cnt >= O_NUMBER_LENGTH)
  			cnt -= O_NUMBER_LENGTH;
  
  		/* Adjust the window towards the beginning of the line. */
State-Changed-From-To: open->analyzed 
State-Changed-By: dd 
State-Changed-When: Thu Jul 19 04:02:22 PDT 2001 
State-Changed-Why:  
fixed in -current, thanks for the report 


Responsible-Changed-From-To: freebsd-bugs->dd 
Responsible-Changed-By: dd 
Responsible-Changed-When: Thu Jul 19 04:02:22 PDT 2001 
Responsible-Changed-Why:  
My MFC reminder. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28687 
State-Changed-From-To: analyzed->closed 
State-Changed-By: dd 
State-Changed-When: Mon Jul 30 17:03:46 PDT 2001 
State-Changed-Why:  
MFC'd 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28687 
>Unformatted:
