From nobody@FreeBSD.org  Wed Jun 27 23:33:49 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id D964A37B401
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 27 Jun 2001 23:33:48 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f5S6XmE60108;
	Wed, 27 Jun 2001 23:33:48 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200106280633.f5S6XmE60108@freefall.freebsd.org>
Date: Wed, 27 Jun 2001 23:33:48 -0700 (PDT)
From: David Xu <davidx@viasoft.com.cn>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dirname.c basename.c not correctly return ENAMETOOLONG
X-Send-Pr-Version: www-1.0

>Number:         28472
>Category:       bin
>Synopsis:       dirname.c basename.c not correctly return ENAMETOOLONG
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    dd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 27 23:40:01 PDT 2001
>Closed-Date:    Mon Jul 23 03:13:05 PDT 2001
>Last-Modified:  Mon Jul 23 03:13:20 PDT 2001
>Originator:     David Xu
>Release:        FreeBSD 4.3-stable
>Organization:
Viasoft
>Environment:
FreeBSD cvs.viasoft.com.cn 4.3-STABLE FreeBSD 4.3-STABLE #0: Wed Jun 20 13:25:45
 CST 2001     root@cvs.viasoft.com.cn:/usr/obj/usr/src/sys/xu  i386
>Description:
libc function basename and dirname missing a condition to return
ENAMETOOLONG

>How-To-Repeat:

>Fix:
--- dirname.c   Thu Jun 28 14:28:37 2001
+++ dirname.c.orig      Thu Jun 28 14:28:25 2001
@@ -69,7 +69,7 @@
                } while (endp > path && *endp == '/');
        }

-       if (endp - path + 1 >= sizeof(bname)) {
+       if (endp - path + 1 > sizeof(bname)) {
                errno = ENAMETOOLONG;
                return(NULL);
        }


--- basename.c  Thu Jun 28 14:24:45 2001
+++ basename.c.orig     Thu Jun 28 14:24:34 2001
@@ -66,7 +66,7 @@
        while (startp > path && *(startp - 1) != '/')
                startp--;

-       if (endp - startp + 1 >= sizeof(bname)) {
+       if (endp - startp + 1 > sizeof(bname)) {
                errno = ENAMETOOLONG;
                return(NULL);
        }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: dd 
State-Changed-When: Thu Jun 28 14:50:57 PDT 2001 
State-Changed-Why:  
Fixed but slightly differently, thanks! 


Responsible-Changed-From-To: freebsd-bugs->dd 
Responsible-Changed-By: dd 
Responsible-Changed-When: Thu Jun 28 14:50:57 PDT 2001 
Responsible-Changed-Why:  
My MFC reminder. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28472 
State-Changed-From-To: analyzed->closed 
State-Changed-By: dd 
State-Changed-When: Mon Jul 23 03:13:05 PDT 2001 
State-Changed-Why:  
MFC'd, thanks. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28472 
>Unformatted:
