From starkhome!gene@sbstark.cs.sunysb.edu  Thu Nov 24 17:27:15 1994
Received: from sbstark.cs.sunysb.edu (sbstark.cs.sunysb.edu [130.245.1.47]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id RAA15888 for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 Nov 1994 17:27:14 -0800
Received: from starkhome.UUCP (root@localhost) by sbstark.cs.sunysb.edu (8.6.9/8.6.9) with UUCP id UAA09586 for FreeBSD-gnats-submit@freebsd.org; Thu, 24 Nov 1994 20:24:56 -0500
Received: by starkhome.cs.sunysb.edu (8.6.9/1.34)
	id UAA10190; Thu, 24 Nov 1994 20:26:38 -0500
Message-Id: <199411250126.UAA10190@starkhome.cs.sunysb.edu>
Date: Thu, 24 Nov 1994 20:26:38 -0500
From: starkhome!gene@sbstark.cs.sunysb.edu (Gene Stark)
Reply-To: starkhome!gene@sbstark.cs.sunysb.edu
To: FreeBSD-gnats-submit@freebsd.org
Subject: uucpd supplies wrong arguments to uucico
X-Send-Pr-Version: 3.2

>Number:         28
>Category:       bin
>Synopsis:       uucpd supplies wrong arguments to uucico
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    core (FreeBSD core team)
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 24 17:30:01 1994
>Closed-Date:    Fri Nov 25 13:00:47 PST 1994
>Last-Modified:
>Originator:     Gene Stark
>Release:        FreeBSD 2.1.0-Development i386
>Organization:
>Environment:

>Description:

	uucpd execl()'s uucico with a "-u" argument, which Taylor uucico
	does not understand.  This makes uucico exit immediately without
	doing anything.

>How-To-Repeat:

	Try using uucp over TCP.

>Fix:
	
	The following diff simply changes the execl() line to remove
	the bogus argument.  I left in the dead code that actually builds
	up the argument string.  There already was dead code writing
	the "Username" array, so what the heck.

*** uucpd.c.orig	Thu Nov 24 20:22:34 1994
--- uucpd.c	Thu Nov 24 20:22:21 1994
***************
*** 181,187 ****
  		initgroups(pw->pw_name, pw->pw_gid);
  		chdir(pw->pw_dir);
  		setuid(pw->pw_uid);
! 		execl(pw->pw_shell, "uucico", ubuf, NULL);
  		syslog(LOG_ERR, "execl: %m");
  	}
  	_exit(1);
--- 181,187 ----
  		initgroups(pw->pw_name, pw->pw_gid);
  		chdir(pw->pw_dir);
  		setuid(pw->pw_uid);
! 		execl(pw->pw_shell, "uucico", NULL);
  		syslog(LOG_ERR, "execl: %m");
  	}
  	_exit(1);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: wollman 
State-Changed-When: Fri Nov 25 13:00:47 PST 1994 
State-Changed-Why:  
Ache claims to have fixed the bug, and I'm closing this as an example 
of using edit-pr to close a PR. 
>Unformatted:



