From mpp  Thu Feb 20 15:22:06 1997
Received: (from mpp@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id PAA14789;
          Thu, 20 Feb 1997 15:22:06 -0800 (PST)
Message-Id: <199702202322.PAA14789@freefall.freebsd.org>
Date: Thu, 20 Feb 1997 15:22:06 -0800 (PST)
From: mpp@freebsd.org
Reply-To: mpp@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: callbootd uses an unitialized variable
X-Send-Pr-Version: 3.2

>Number:         2785
>Category:       bin
>Synopsis:       callbootd uses an unitialized variable
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    wpaul
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 20 15:30:01 PST 1997
>Closed-Date:    Thu Jun 19 21:56:16 PDT 2003
>Last-Modified:  Thu Jun 19 21:56:16 PDT 2003
>Originator:     Mike Pritchard
>Release:        FreeBSD 3.0-current
>Organization:
Mike Pritchard
>Environment:

>Description:

	While apply another coesmetic patch to bootparamd/callbootd,
	I noticed that callbootd uses an unitialized variable.

>How-To-Repeat:

	Compile bootparamd with COPTS=-Wall

>Fix:
	
	I think the following patch should fix the problem, but someone who
	actually knows something about how bootparamd works should review it.

Index: callbootd/callbootd.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/bootparamd/callbootd/callbootd.c,v
retrieving revision 1.4
diff -u -r1.4 callbootd.c
--- callbootd.c	1997/01/14 07:10:38	1.4
+++ callbootd.c	1997/02/20 23:16:30
@@ -88,12 +88,11 @@
 
   if ( ! broadcast ) {
     clnt = clnt_create(server,BOOTPARAMPROG, BOOTPARAMVERS, "udp");
-  }
-
-  if ( clnt == NULL ) {
-     fprintf (stderr, "%s: could not contact bootparam server on host %s\n",
+    if ( clnt == NULL ) {
+     	fprintf (stderr, "%s: could not contact bootparam server on host %s\n",
 			argv[0], server);
-     exit (1);
+     	exit (1);
+    }
   }
 
   switch (argc) {
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->wpaul 
Responsible-Changed-By: mpp 
Responsible-Changed-When: Thu Feb 20 15:31:04 PST 1997 
Responsible-Changed-Why:  
Bill imported bootparamd. 

From: Joseph Holland King <gte743n@cad.gatech.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: bin/2785: callbootd uses an unitialized variable
Date: Tue, 19 Nov 2002 01:57:34 -0500

 last modifide in 1997, and there was a patch included, 
 can this be closed?
 
 -- 
 Holland King        
 gte743n@cad.gatech.edu

From: Joseph Holland King <gte743n@cad.gatech.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: bin/2785: callbootd uses an unitialized variable
Date: Mon, 17 Feb 2003 00:12:05 -0500

 This PR can be closed
 -- 
 Holland King        
 gte743n@cad.gatech.edu

From: Joseph Holland King <gte743n@cad.gatech.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: bin/2785: callbootd uses an unitialized variable
Date: Thu, 6 Mar 2003 01:45:21 -0500

 this pr can be closed
 
 -- 
 Holland King        
 gte743n@cad.gatech.edu

From: insane@wreck.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: bin/2785: callbootd uses an unitialized variable
Date: Tue, 29 Apr 2003 19:02:53 -0400

 This PR can be closed
 
 -- 
 Holland King        
 gte743n@cad.gatech.edu
State-Changed-From-To: open->closed 
State-Changed-By: jmg 
State-Changed-When: Thu Jun 19 21:55:37 PDT 2003 
State-Changed-Why:  
fixed in rev 1.10 of src/usr.sbin/bootparamd/callbootd 

http://www.freebsd.org/cgi/query-pr.cgi?pr=2785 
>Unformatted:
