From leres@hot.ee.lbl.gov  Wed May 30 15:02:50 2001
Return-Path: <leres@hot.ee.lbl.gov>
Received: from hot.ee.lbl.gov (hot.ee.lbl.gov [131.243.1.42])
	by hub.freebsd.org (Postfix) with ESMTP id 9FF6B37B424
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 May 2001 15:02:49 -0700 (PDT)
	(envelope-from leres@hot.ee.lbl.gov)
Received: (from leres@localhost)
	by hot.ee.lbl.gov (8.11.0/8.11.0) id f4UM2nj27962;
	Wed, 30 May 2001 15:02:49 -0700 (PDT)
Message-Id: <200105302202.f4UM2nj27962@hot.ee.lbl.gov>
Date: Wed, 30 May 2001 15:02:49 PDT
From: Craig Leres <leres@ee.lbl.gov>
To: FreeBSD-gnats-submit@freebsd.org
Cc: leres@ee.lbl.gov (Craig Leres), jef@ee.lbl.gov (Jef Poskanzer)
Subject: [PATCH] fetch(1): don't divide by zero when fetching an empty file
X-Send-Pr-Version: 3.2

>Number:         27780
>Category:       bin
>Synopsis:       [PATCH] fetch(1): don't divide by zero when fetching an empty file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 30 15:10:01 PDT 2001
>Closed-Date:    Mon Jun 11 11:06:37 PDT 2001
>Last-Modified:  Mon Jun 11 11:06:47 PDT 2001
>Originator:     Craig Leres
>Release:        FreeBSD 4.3-RELEASE i386
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
>Description:

	If you try to grab a zero length file, fetch(1) prints garbage
	for the "percent done."

>How-To-Repeat:

	% fetch http://www-nrg.ee.lbl.gov/leres/a
	Receiving a (0 bytes): -2147483648%
	0 bytes transferred in 0.0 seconds (0.00 Bps)

>Fix:

	The appended context diff checks for zero length size.

===================================================================
*** fetch.c	2001/05/30 21:54:09	1.1
--- fetch.c	2001/05/30 21:54:54
***************
*** 126,132 ****
      xs->last = now;
      
      fprintf(stderr, "\rReceiving %s", xs->name);
!     if (xs->size == -1)
  	fprintf(stderr, ": %lld bytes", xs->rcvd);
      else
  	fprintf(stderr, " (%lld bytes): %d%%", xs->size,
--- 126,132 ----
      xs->last = now;
      
      fprintf(stderr, "\rReceiving %s", xs->name);
!     if (xs->size <= 0)
  	fprintf(stderr, ": %lld bytes", xs->rcvd);
      else
  	fprintf(stderr, " (%lld bytes): %d%%", xs->size,
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: dd 
Responsible-Changed-When: Thu May 31 20:59:27 PDT 2001 
Responsible-Changed-Why:  
Over to fetch maintainer. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27780 
State-Changed-From-To: open->feedback 
State-Changed-By: des 
State-Changed-When: Fri Jun 1 03:25:36 PDT 2001 
State-Changed-Why:  
Fixed in -CURRENT, awaiting MFC. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27780 
State-Changed-From-To: feedback->closed 
State-Changed-By: des 
State-Changed-When: Mon Jun 11 11:06:37 PDT 2001 
State-Changed-Why:  
MFCed. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27780 
>Unformatted:
