From root@gits.dyndns.org  Sun May 20 19:08:21 2001
Return-Path: <root@gits.dyndns.org>
Received: from mail.noos.fr (lafontaine.noos.net [212.198.2.72])
	by hub.freebsd.org (Postfix) with ESMTP id 226AA37B43C
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 20 May 2001 19:08:17 -0700 (PDT)
	(envelope-from root@gits.dyndns.org)
Received: (qmail 10890614 invoked by uid 0); 21 May 2001 02:08:15 -0000
Received: from d165.dhcp212-198-231.noos.fr (HELO gits.dyndns.org) ([212.198.231.165]) (envelope-sender <root@gits.dyndns.org>)
          by lafontaine.noos.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <FreeBSD-gnats-submit@freebsd.org>; 21 May 2001 02:08:15 -0000
Received: (from root@localhost)
	by gits.dyndns.org (8.11.3/8.11.3) id f4L28EN13215;
	Mon, 21 May 2001 04:08:14 +0200 (CEST)
	(envelope-from root)
Message-Id: <200105210208.f4L28EN13215@gits.dyndns.org>
Date: Mon, 21 May 2001 04:08:14 +0200 (CEST)
From: Cyrille Lefevre <clefevre@poboxes.com>
Reply-To: clefevre@poboxes.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: make sysinstall ask for the keymap at installation time
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         27483
>Category:       bin
>Synopsis:       [sysinstall] [patch] make sysinstall ask for the keymap at installation time
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-qa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 20 19:10:01 PDT 2001
>Closed-Date:    Wed May 10 14:00:21 GMT 2006
>Last-Modified:  Wed May 10 14:00:21 GMT 2006
>Originator:     Cyrille Lefevre
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
ACME
>Environment:

System: FreeBSD gits 4.3-STABLE FreeBSD 4.3-STABLE #21: Sun Apr 22 22:20:03 CEST 2001 root@gits:/disk2/4.x-stable/src/sys/compile/CUSTOM i386

>Description:
	
	at installation time, you may (often) forgot to change the
	keymap.  this may cause a problem when leaving fdisk if
	you're using an AZERTY keyboard. A and Q are inverted. so,
	you could think leaving fdisk while you're allocating all
	space for FreeBSD. of course, there is a warning, but think
	about unexperienced users.

>How-To-Repeat:
	install FreeBSD :)
>Fix:

Index: main.c
===================================================================
RCS file: /home/ncvs/src/release/sysinstall/Attic/main.c,v
retrieving revision 1.57.2.5
diff -u -r1.57.2.5 main.c
--- main.c	2001/03/29 19:56:34	1.57.2.5
+++ main.c	2001/05/21 01:57:00
@@ -144,6 +144,8 @@
 
     /* Begin user dialog at outer menu */
     dialog_clear();
+    if (getpid() == 1)
+	dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
     while (1) {
 	choice = scroll = curr = max = 0;
 	dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: murray 
State-Changed-When: Wed Sep 5 00:50:18 PDT 2001 
State-Changed-Why:  
I think that this will unnecessarily confuse new users.  I don't recall 
other systems forcing users into a keymap selection menu. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27483 

From: murray@stokely.org
To: freebsd-gnats-submit@FreeBSD.org, clefevre@poboxes.com
Cc:  
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Wed, 5 Sep 2001 00:53:25 -0700

 --W/nzBZO5zC0uMSeA
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
   Are you sure this is really necessary?  What do other systems do?  I
 don't think they are this "in your face" about selecting a keymap, are
 they?  I'm thinking in particular of Solaris and the last couple Linux
 distros I tried (I must admit its been a while).
 
   I think this may do more harm than good, in that it adds another
 potentially confusing menu for new users to go through.
 
 	- Murray
 
 --W/nzBZO5zC0uMSeA
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (SunOS)
 Comment: For info see http://www.gnupg.org
 
 iD8DBQE7ldn0tNcQog5FH30RAuJ3AJ9ZrLuAp8wi7dTagemp2bSx9204fACguD8i
 kzGwaaJ6JQiUAXzkKl5+veo=
 =WKfZ
 -----END PGP SIGNATURE-----
 
 --W/nzBZO5zC0uMSeA--

From: Cyrille Lefevre <clefevre@citeweb.net>
To: murray@FreeBSD.org
Cc: freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Wed, 5 Sep 2001 11:55:24 +0200 (CEST)

 murray@FreeBSD.org wrote:
 
 > Synopsis: make sysinstall ask for the keymap at installation time
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: murray
 > State-Changed-When: Wed Sep 5 00:50:18 PDT 2001
 > State-Changed-Why: 
 > I think that this will unnecessarily confuse new users.  I don't recall
 > other systems forcing users into a keymap selection menu.
 
 are you sure ? how about windows, linux, solaris, hp-ux, etc. distributions ?
 they are all asking for keyboard language at the beginning of the installation
 process.
 
 > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27483
 
 I've looked up the PR and  my poboxes address seems to be dead. sorry.
 
 PS : teka care, freebsd-gnats-submit@FreeBSD.org is CCed.
 
 Cyrille.
 -- 
 mailto:clefevre@citeweb.net
State-Changed-From-To: feedback->closed 
State-Changed-By: sheldonh 
State-Changed-When: Wed Jan 30 01:20:33 PST 2002 
State-Changed-Why:  
Automatic feedback timeout.  This PR remained unchanged in the feedback 
state for more than 4 months. 

If additional feedback that warrants the re-opening of this PR is 
available but not included in the audit trail, please include the 
feedback in a reply to this message (preserving the Subject line) and 
ask that the PR be re-opened. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=27483 
State-Changed-From-To: closed->open 
State-Changed-By: johan 
State-Changed-When: Wed Jun 5 16:06:18 PDT 2002 
State-Changed-Why:  
Feedback did actually arrive before it was closed. 
Submitter asks that this is reopened. 



Responsible-Changed-From-To: freebsd-bugs->freebsd-qa 
Responsible-Changed-By: johan 
Responsible-Changed-When: Wed Jun 5 16:06:18 PDT 2002 
Responsible-Changed-Why:  
Over to maintainer group. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=27483 
Responsible-Changed-From-To: freebsd-qa->qa 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sat Aug 24 19:19:37 PDT 2002 
Responsible-Changed-Why:  
Use short names for mailing list to make searches    
using the web query form work with the shown responsible. 

This also makes open PRs show up in the summery mail. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=27483 

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: freebsd gnats <freebsd-gnats-submit@freebsd.org>,
	freebsd qa <freebsd-qa@freebsd.org>
Cc:  
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Thu, 4 Mar 2004 16:28:09 +0100

 cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET 2004)
 anyone to commit this PR ?
 thanks in advance.
 
 Index: main.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/main.c,v
 retrieving revision 1.71
 diff -u -I$Id.*$ -I$.+BSD.*$ -r1.71 main.c
 --- main.c	20 Aug 2003 06:27:21 -0000	1.71
 +++ main.c	3 Dec 2003 11:44:06 -0000
 @@ -166,6 +166,8 @@
  
      /* Begin user dialog at outer menu */
      dialog_clear();
 +    if (getpid() == 1)
 +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
      while (1) {
  	choice = scroll = curr = max = 0;
  	dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
 
 Cyrille Lefevre
 -- 
 mailto:cyrille.lefevre@laposte.net

From: Peter Pentchev <roam@ringlet.net>
To: cyrille.lefevre@laposte.net
Cc: bug-followup@FreeBSD.org, freebsd-qa@FreeBSD.org
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Thu, 4 Mar 2004 17:46:21 +0200

 --9amGYk9869ThD9tj
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
 > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CE=
 T 2004)
 > anyone to commit this PR ?
 > thanks in advance.
 > =20
 [snip]
 >      /* Begin user dialog at outer menu */
 >      dialog_clear();
 > +    if (getpid() =3D=3D 1)
 > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FAL=
 SE);
 >      while (1) {
 
 Just a minor comment: shouldn't RunningAsInit be used here instead of
 a getpid() invocation? :)
 
 G'luck,
 Peter
 
 --=20
 Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 This sentence contains exactly threee erors.
 
 --9amGYk9869ThD9tj
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAR09N7Ri2jRYZRVMRAlqKAKCTcAmVGc3Rc6afzhZmrg/Go4Y8OQCeN/ap
 Rfl6hZllFD+ZxsXqxlOhHFk=
 =qPre
 -----END PGP SIGNATURE-----
 
 --9amGYk9869ThD9tj--

From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
To: "Peter Pentchev" <roam@ringlet.net>
Cc: <bug-followup@FreeBSD.org>, <freebsd-qa@FreeBSD.org>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Sat, 6 Mar 2004 02:29:47 +0100

 > On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
 > > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET
 2004)
 > > anyone to commit this PR ?
 > > thanks in advance.
 > >
 > [snip]
 > >      /* Begin user dialog at outer menu */
 > >      dialog_clear();
 > > +    if (getpid() == 1)
 > > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max,
 FALSE);
 > >      while (1) {
 >
 > Just a minor comment: shouldn't RunningAsInit be used here instead of
 > a getpid() invocation? :)
 
 maybe, don't know in fact ?
 
 Cyrille Lefevre.
 -- 
 home: mailto:cyrille.lefevre@laposte.net
 

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: freebsd gnats <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Thu, 15 Apr 2004 23:06:34 +0200

 well, RunningAsInit is effectively more appropriate than getpid() == 1.
 
 Index: main.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/main.c,v
 retrieving revision 1.71
 diff -u -I$Id.*$ -I$.+BSD.*$ -r1.71 main.c
 --- main.c	20 Aug 2003 06:27:21 -0000	1.71
 +++ main.c	15 Apr 2004 21:03:33 -0000
 @@ -166,6 +166,8 @@
  
      /* Begin user dialog at outer menu */
      dialog_clear();
 +    if (RunningAsInit)
 +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
      while (1) {
  	choice = scroll = curr = max = 0;
  	dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
 
 Cyrille Lefevre
 -- 
 mailto:cyrille.lefevre@laposte.net
State-Changed-From-To: open->closed 
State-Changed-By: ceri 
State-Changed-When: Wed May 10 13:59:52 UTC 2006 
State-Changed-Why:  
sysinstall has this functionality now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=27483 
>Unformatted:
