From thomas@cuivre.fr.eu.org  Tue May  1 14:05:41 2001
Return-Path: <thomas@cuivre.fr.eu.org>
Received: from melusine.cuivre.fr.eu.org (ppp60-net1-idf3-bas1.isdnet.net [195.154.52.60])
	by hub.freebsd.org (Postfix) with ESMTP id D2F5A37B424
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 May 2001 14:05:40 -0700 (PDT)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 3209E24D02; Tue,  1 May 2001 23:05:39 +0200 (CEST)
Message-Id: <20010501210539.3209E24D02@melusine.cuivre.fr.eu.org>
Date: Tue,  1 May 2001 23:05:39 +0200 (CEST)
From: thomas@cuivre.fr.eu.org
Reply-To: thomas@cuivre.fr.eu.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ipnat should not require existence of ipfilter rules file.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         27016
>Category:       bin
>Synopsis:       ipnat should not require existence of ipfilter rules file.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    darrenr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 01 14:10:01 PDT 2001
>Closed-Date:    Wed Nov 14 14:21:23 MET 2001
>Last-Modified:  Wed Nov 14 14:22:00 MET 2001
>Originator:     Thomas Quinot
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD melusine.cuivre.fr.eu.org 4.3-STABLE FreeBSD 4.3-STABLE #2: Tue May 1 20:28:53 CEST 2001 thomas@melusine.cuivre.fr.eu.org:/usr/obj/usr/src/sys/MELUSINE i386


	
>Description:
	rc.network does not examine ipnat_enable and possibly
	launch ipnat if ipfilter_enable is not set to YES
	*and* and ipfilter rules file exists.

	This seems to be an unnecessary restrictions, because
	in some situations one may want to use ipnat without
	ipfilter rules.
>How-To-Repeat:
	
>Fix:

--- /etc/rc.network	Tue May  1 22:42:57 2001
+++ /tmp/rc.network	Tue May  1 23:00:19 2001
@@ -60,20 +60,20 @@
 				${ipmon_program:-/sbin/ipmon} ${ipmon_flags}
 				;;
 			esac
-			case "${ipnat_enable}" in
-			[Yy][Ee][Ss])
-				if [ -r "${ipnat_rules}" ]; then
-					echo -n ' ipnat';
-				eval ${ipnat_program:-/sbin/ipnat -CF -f} \
-					"${ipnat_rules}" ${ipnat_flags}
-				else
-					echo -n ' NO IPNAT RULES'
-				fi
-				;;
-			esac
 		else
 			ipfilter_enable="NO"
 			echo -n ' NO IPF RULES'
+		fi
+		;;
+	esac
+	case "${ipnat_enable}" in
+	[Yy][Ee][Ss])
+		if [ -r "${ipnat_rules}" ]; then
+			echo -n ' ipnat';
+		eval ${ipnat_program:-/sbin/ipnat -CF -f} \
+			"${ipnat_rules}" ${ipnat_flags}
+		else
+			echo -n ' NO IPNAT RULES'
 		fi
 		;;
 	esac
>Release-Note:
>Audit-Trail:

From: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/27016: ipnat should not require existence of ipfilter rules 
 file.
Date: Sun, 21 Oct 2001 01:58:53 +0200

 See also conf/25223.
 
 --
     Thomas.Quinot@Cuivre.FR.EU.ORG
 
 
 
State-Changed-From-To: open->feedback 
State-Changed-By: darrenr 
State-Changed-When: Sun Oct 21 08:09:54 PDT 2001 
State-Changed-Why:  
there's another gnats with the same problem.  this has been addressed in 
-current 


Responsible-Changed-From-To: freebsd-bugs->darrenr 
Responsible-Changed-By: darrenr 
Responsible-Changed-When: Sun Oct 21 08:09:54 PDT 2001 
Responsible-Changed-Why:  

darrenr is responsible 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27016 

From: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/27016: ipnat should not require existence of ipfilter rules 
 file.
Date: Mon, 22 Oct 2001 13:52:46 +0200

 The fix from conf/25223 has been committed by Darren in rc.netowk 1.108:
 
 This PR can be closed.
 
 Thanks!
 Thomas.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: guido 
State-Changed-When: Wed Nov 14 14:21:23 MET 2001 
State-Changed-Why:  
User has told the PR can be closed 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27016 
>Unformatted:
