From nobody@FreeBSD.org  Mon Apr  9 14:23:35 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id BB26A37B422
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  9 Apr 2001 14:23:35 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f39LNZt43968;
	Mon, 9 Apr 2001 14:23:35 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200104092123.f39LNZt43968@freefall.freebsd.org>
Date: Mon, 9 Apr 2001 14:23:35 -0700 (PDT)
From: sburke@corp.namesafe.com
To: freebsd-gnats-submit@FreeBSD.org
Subject: pkg_delete clears dependencies after running post-deinstall script.
X-Send-Pr-Version: www-1.0

>Number:         26468
>Category:       bin
>Synopsis:       pkg_delete clears dependencies after running post-deinstall script.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    eik
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 09 14:30:01 PDT 2001
>Closed-Date:    Fri Aug 13 17:09:42 GMT 2004
>Last-Modified:  Fri Aug 13 17:09:42 GMT 2004
>Originator:     SEan Burke
>Release:        4.3 BETA
>Organization:
NameSafe, Inc.
>Environment:
FreeBSD zardoz.corp.namesafe.com 4.3-BETA FreeBSD 4.3-BETA #1: Thu Apr  5 18:09:04 PDT 2001     root@dev1.corp.namesafe.com:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
pkg_delete does not clear the +REQUIRED_BY entries in the deleted 
package's dependencies until after running the post-deinstall script.
As a result, if the post-deinstall script attempts to delete other
packages that are required by the package being deleted, those packages
cannot be deleted because they appear to still be required.
>How-To-Repeat:
Create a package Foo-1.0, with "@pkgdep Bar-1.0" in the pkg-plist.
Next, in Foo's post-deinstall script, do "pkg_delete Bar-1.0".
Deleting the package Foo-1.0 generates the error:
pkg_delete: package `Bar-1.0' is required by these other packages
and may not be deinstalled 
Foo-1.0
>Fix:
In /usr/src/usr.sbin/pkg_install/delete/perform.c,
move the loop beginning at line 258:

    for (p = Plist.head; p ; p = p->next) {
        if (p->type != PLIST_PKGDEP)
            continue;
        if (Verbose)
            printf("Attempting to remove dependency on package `%s'\n", p->name);
        if (!Fake)
            undepend(p, pkg);
    }

To line 225, following the call to delete_package().

This will ensure that the package dependencies are up to date
when the post-deinstall script is called.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: eik 
State-Changed-When: Tue Jun 29 21:31:51 CEST 2004 
State-Changed-Why:  
awaiting MFC 


Responsible-Changed-From-To: freebsd-bugs->eik 
Responsible-Changed-By: eik 
Responsible-Changed-When: Tue Jun 29 21:31:51 CEST 2004 
Responsible-Changed-Why:  
Handle 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26468 
State-Changed-From-To: patched->closed 
State-Changed-By: eik 
State-Changed-When: Fri Aug 13 19:09:05 CEST 2004 
State-Changed-Why:  
MFC finished, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26468 
>Unformatted:
