From nobody@FreeBSD.org  Wed Mar 21 01:13:25 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 5B73237B719
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Mar 2001 01:13:25 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2L9DPR26693;
	Wed, 21 Mar 2001 01:13:25 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200103210913.f2L9DPR26693@freefall.freebsd.org>
Date: Wed, 21 Mar 2001 01:13:25 -0800 (PST)
From: dan@freebsddiary.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: rmuser is not case sensitive
X-Send-Pr-Version: www-1.0

>Number:         25961
>Category:       bin
>Synopsis:       [MFC] rmuser is not case sensitive
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 21 01:20:00 PST 2001
>Closed-Date:    Sun Apr 22 23:53:13 PDT 2001
>Last-Modified:  Sun Apr 22 23:53:30 PDT 2001
>Originator:     Dan Langille
>Release:        FreeBSD 4.3-beta
>Organization:
The FreeBSD Diary
>Environment:
FreeBSD [suppressed].net.au 4.3-BETA FreeBSD 4.3-BETA #0: Mon Mar 12 08:58:20 CST 2001     
root@[suppressed].net.au:/usr/src/sys/compile/PENOLA  i386
>Description:
rmuser is not case sensitive.  It will confirm the user you wish to 
delete, but then it deletes more than one user.
>How-To-Repeat:
adduser JOHN, adduser john, them rmuser john, both users 
are removed.
>Fix:
Linh Pham <lplist@closedsrc.org> reported this in response to my 
post in -questions (200103192332.f2JNWXb68437@ns1.unixathome.org):

In the rmuser script, there is a Search/Replace call that has /io, which
searches in non-case sensitive mode.

Below is a clip of what I have under 4.2-STABLE:

while (<MASTER_PW>) {
	if (not /^\Q$login_name:/io) {
		print NEW_PW;
	} else {
		print STDERR "Dropped entry for $login_name\n" if \
		$debug;

		$skipped = 1;
	}
}

Removing the i would probably resolve the non-case sensitive issue of
rmuser.

>Release-Note:
>Audit-Trail:

From: dan@freebsddiary.org
To: freebsd-gnats-submit@FreeBSD.ORG
Cc:  
Subject: bin/25961: rmuser is not case sensitive
Date: Wed, 21 Mar 2001 01:13:25 -0800 (PST)

 >Number:         25961
 >Category:       bin
 >Synopsis:       rmuser is not case sensitive
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          closed
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Wed Mar 21 01:20:00 PST 2001
 >Closed-Date:
 >Last-Modified:
 >Originator:     Dan Langille
 >Release:        FreeBSD 4.3-beta
 >Organization:
 The FreeBSD Diary
 >Environment:
 FreeBSD [suppressed].net.au 4.3-BETA FreeBSD 4.3-BETA #0: Mon Mar 12 08:58:20 CST 2001     
 root@[suppressed].net.au:/usr/src/sys/compile/PENOLA  i386
 >Description:
 rmuser is not case sensitive.  It will confirm the user you wish to 
 delete, but then it deletes more than one user.
 >How-To-Repeat:
 adduser JOHN, adduser john, them rmuser john, both users 
 are removed.
 >Fix:
 Linh Pham <lplist@closedsrc.org> reported this in response to my 
 post in -questions (200103192332.f2JNWXb68437@ns1.unixathome.org):
 
 In the rmuser script, there is a Search/Replace call that has /io, which
 searches in non-case sensitive mode.
 
 Below is a clip of what I have under 4.2-STABLE:
 
 while (<MASTER_PW>) {
 	if (not /^\Q$login_name:/io) {
 		print NEW_PW;
 	} else {
 		print STDERR "Dropped entry for $login_name\n" if \
 		$debug;
 
 		$skipped = 1;
 	}
 }
 
 Removing the i would probably resolve the non-case sensitive issue of
 rmuser.
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message

From: Linh Pham <lplist@closedsrc.org>
To: <freebsd-gnats-submit@freebsd.org>, <dan@freebsddiary.org>
Cc:  
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Wed, 11 Apr 2001 15:12:26 -0700 (PDT)

 I just wanted to clarify my post to -questions:
 
 There is a line in the rmuser script that has:
 
 if (not /^\Q$login_name:/io) {
 
 which should be
 
 if (not /^\Q$login_name:/o) {
 
 since /io does the search in a case-insensitive manner and scans through
 the variable only once. /o would make the search case-sensitive... as it
 should.
 
 Sorry if this wasn't really clear in my original post.
 
 -- 
 Linh Pham
 [lplist@closedsrc.org]
 
 // 404b - Brain not found
 

From: "Dan Langille" <dan@langille.org>
To: <freebsd-gnats-submit@freebsd.org>
Cc: Linh Pham <lplist@closedsrc.org>
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Wed, 11 Apr 2001 18:21:50 -0400

 On 11 Apr 2001, at 15:12, Linh Pham wrote:
 
 > I just wanted to clarify my post to -questions:
 > 
 > There is a line in the rmuser script that has:
 > 
 > if (not /^\Q$login_name:/io) {
 > 
 > which should be
 > 
 > if (not /^\Q$login_name:/o) {
 > 
 > since /io does the search in a case-insensitive manner and scans through
 > the variable only once. /o would make the search case-sensitive... as it
 > should.
 > 
 > Sorry if this wasn't really clear in my original post.
 
 What you've written above makes sense to me.  Thank you.
 
 -- 
 Dan Langille
 pgpkey - finger dan@unixathome.org | http://unixathome.org/finger.php
 got any work?  I'm looking for some.
State-Changed-From-To: open->feedback 
State-Changed-By: dougb 
State-Changed-When: Sat Apr 14 18:44:45 PDT 2001 
State-Changed-Why:  

What benefit is obtained from having two users on the system with the 
same username, differing only by case? Even if it was a benefit of 
some sort, it would likely cause all kinds of other problems. 


Responsible-Changed-From-To: freebsd-bugs->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sat Apr 14 18:44:45 PDT 2001 
Responsible-Changed-Why:  

I am familiar with the code in question 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 

From: "Dan Langille" <dan@langille.org>
To: dougb@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Sun, 15 Apr 2001 01:13:57 -0400

 On 14 Apr 2001, at 18:46, dougb@FreeBSD.org wrote:
 
 > Synopsis: rmuser is not case sensitive
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dougb
 > State-Changed-When: Sat Apr 14 18:44:45 PDT 2001
 > State-Changed-Why: 
 > 
 > What benefit is obtained from having two users on the system with the
 > same username, differing only by case? Even if it was a benefit of
 > some sort, it would likely cause all kinds of other problems.
 
 The point of the PR is not to make it easier to have two users.  The 
 point of the PR is to remove the unexpected behaviour in the case 
 where you DO have two users.  I'm not setting administrative policy, 
 which is beyond the scope of this PR (i.e. tools not policy).  The script 
 asks you if you want to remove a particular user (i.e. the one you 
 specified).  You confirm.  Then the script removes both users.  This 
 violates POLA.
 
 I think the script is case sensitive for the confirmation but case 
 insensitive for the delete.  For consistency, it should use one or the 
 other, but not both.  I think case sensitive makes the most sense.  If 
 you do wind up with two users with the same name, different case, then 
 at least rmuser can be used to remove the one you don't want.
 
 -- 
 Dan Langille
 pgpkey - finger dan@unixathome.org | http://unixathome.org/finger.php
 got any work?  I'm looking for some.
State-Changed-From-To: feedback->closed 
State-Changed-By: dougb 
State-Changed-When: Sun Apr 15 12:23:01 PDT 2001 
State-Changed-Why:  

Installations that have two users with the same characters capitalized 
differently should not be using the standard tools, since their situation 
is highly non-standard, and likely to break things. Given that it's hard 
to place POLA on one side or the other of this argument, let's err on 
the side that is most likely to produce working systems for the majority 
of users. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 

From: "Dan Langille" <dan@langille.org>
To: <dougb@FreeBSD.org>
Cc: freebsd-bugs@FreeBSD.org, <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Sun, 15 Apr 2001 15:46:46 -0400

 Would someone please reopen this PR?  I don't think we're quite 
 finished with the feedback yet.
 
 On 15 Apr 2001, at 12:25, dougb@FreeBSD.org wrote:
 
 > Synopsis: rmuser is not case sensitive
 > 
 > State-Changed-From-To: feedback->closed
 
 *sigh*
 
 > State-Changed-By: dougb
 > State-Changed-When: Sun Apr 15 12:23:01 PDT 2001
 > State-Changed-Why: 
 > 
 > Installations that have two users with the same characters capitalized
 > differently should not be using the standard tools, since their situation
 > is highly non-standard, and likely to break things. 
 
 You have completely missed my points.  I am not saying that we should 
 cater for such installations.  I'm talking about a situation where two 
 where two users with the same characters have been created, perhaps 
 by accident.  Then they go to delete one.  But rmuser deletes both. 
 
 > Given that it's hard to
 > place POLA on one side or the other of this argument, 
 
 It's not hard to place POLA at all.  Look at rmuser alone.  In one section 
 of remuser, it is case sensitive ("is this the user do you wish to 
 delete?".  In another, it's case insensitive ("OK, I'll delete both users 
 now").  This is a bug.  Plain and simple.  It asks if you to delete steve.  
 And it deletes both Steve and steve.  That's not right.
 
 > let's err on the side
 > that is most likely to produce working systems for the majority of users.
 
 How is fixing this bug going to break anything?
 
 -- 
 Dan Langille
 pgpkey - finger dan@unixathome.org | http://unixathome.org/finger.php
 got any work?  I'm looking for some.

From: Poul-Henning Kamp <phk@critter.freebsd.dk>
To: dan@langille.org
Cc: dougb@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG,
	freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/25961: rmuser is not case sensitive 
Date: Sun, 15 Apr 2001 21:49:45 +0200

 I agree with Dan here,  rmuser breaks POLA by being inconsistent.
 
 In message <200104151946.f3FJkme33474@ns1.unixathome.org>, "Dan Langille" write
 s:
 >Would someone please reopen this PR?  I don't think we're quite 
 >finished with the feedback yet.
 >
 >On 15 Apr 2001, at 12:25, dougb@FreeBSD.org wrote:
 >
 >> Synopsis: rmuser is not case sensitive
 >> 
 >> State-Changed-From-To: feedback->closed
 >
 >*sigh*
 >
 >> State-Changed-By: dougb
 >> State-Changed-When: Sun Apr 15 12:23:01 PDT 2001
 >> State-Changed-Why: 
 >> 
 >> Installations that have two users with the same characters capitalized
 >> differently should not be using the standard tools, since their situation
 >> is highly non-standard, and likely to break things. 
 >
 >You have completely missed my points.  I am not saying that we should 
 >cater for such installations.  I'm talking about a situation where two 
 >where two users with the same characters have been created, perhaps 
 >by accident.  Then they go to delete one.  But rmuser deletes both. 
 >
 >> Given that it's hard to
 >> place POLA on one side or the other of this argument, 
 >
 >It's not hard to place POLA at all.  Look at rmuser alone.  In one section 
 >of remuser, it is case sensitive ("is this the user do you wish to 
 >delete?".  In another, it's case insensitive ("OK, I'll delete both users 
 >now").  This is a bug.  Plain and simple.  It asks if you to delete steve.  
 >And it deletes both Steve and steve.  That's not right.
 >
 >> let's err on the side
 >> that is most likely to produce working systems for the majority of users.
 >
 >How is fixing this bug going to break anything?
 >
 >-- 
 >Dan Langille
 >pgpkey - finger dan@unixathome.org | http://unixathome.org/finger.php
 >got any work?  I'm looking for some.
 >
 >To Unsubscribe: send mail to majordomo@FreeBSD.org
 >with "unsubscribe freebsd-bugs" in the body of the message
 >
 
 --
 Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 phk@FreeBSD.ORG         | TCP/IP since RFC 956
 FreeBSD committer       | BSD since 4.3-tahoe    
 Never attribute to malice what can adequately be explained by incompetence.
State-Changed-From-To: closed->analyzed 
State-Changed-By: dougb 
State-Changed-When: Sun Apr 15 12:51:08 PDT 2001 
State-Changed-Why:  

There is disagreement as to the right thing to do 


Responsible-Changed-From-To: dougb->phk 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sun Apr 15 12:51:08 PDT 2001 
Responsible-Changed-Why:  

phk volunteered to head this up by virtue of comments from the peanut gallery 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 
Responsible-Changed-From-To: phk->alfred 
Responsible-Changed-By: alfred 
Responsible-Changed-When: Sun Apr 15 13:01:15 PDT 2001 
Responsible-Changed-Why:  
Because this wasn't all the much of a big deal in the first place. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 
State-Changed-From-To: analyzed->closed 
State-Changed-By: obrien 
State-Changed-When: Sun Apr 15 13:03:50 PDT 2001 
State-Changed-Why:  
fixed.  Geez! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 

From: Doug Barton <DougB@DougBarton.net>
To: dan@langille.org
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Sun, 15 Apr 2001 13:04:50 -0700

 Dan Langille wrote:
 
 > You have completely missed my points. 
 
 	Don't make the mistake of thinking that becuase I don't agree with you I
 couldn't possibly have understood what you said. I do understand exactly
 what you're saying, and I think that you are wrong. However, the mass of
 public opinion is on the side of maintaining case sensitivity. Go figure.
 
State-Changed-From-To: closed->analyzed 
State-Changed-By: dougb 
State-Changed-When: Sun Apr 15 13:44:33 PDT 2001 
State-Changed-Why:  

I committed a better fix, and will MFC it after the freeze. 


Responsible-Changed-From-To: alfred->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Sun Apr 15 13:44:33 PDT 2001 
Responsible-Changed-Why:  

There was a time, not too long ago, when people on this project knew 
how to take a joke. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 

From: "Dan Langille" <dan@langille.org>
To: Doug Barton <DougB@DougBarton.net>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: bin/25961: rmuser is not case sensitive
Date: Sun, 15 Apr 2001 17:39:24 -0400

 On 15 Apr 2001, at 13:04, Doug Barton wrote:
 
 > Dan Langille wrote:
 > 
 > > You have completely missed my points. 
 > 
 >  Don't make the mistake of thinking that becuase I don't agree with you I
 > couldn't possibly have understood what you said. I do understand exactly
 > what you're saying, and I think that you are wrong.
 
 That's not why I thought you didn't understand.
 
 > However, the mass of
 > public opinion is on the side of maintaining case sensitivity. Go figure.
 
 Don't get me wrong.  I don't create mixed case users.  I inherited a 
 system such a system.  I removed one.  I lost two.
 
 cheers.
 
 -- 
 Dan Langille
 pgpkey - finger dan@unixathome.org | http://unixathome.org/finger.php
 got any work?  I'm looking for some.
State-Changed-From-To: analyzed->closed 
State-Changed-By: dougb 
State-Changed-When: Sun Apr 22 23:53:13 PDT 2001 
State-Changed-Why:  

Fix MFC'ed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25961 
>Unformatted:
