From Jim.Pirzyk@disney.com  Mon Mar 12 17:35:32 2001
Return-Path: <Jim.Pirzyk@disney.com>
Received: from mail.disney.com (mail.disney.com [204.128.192.15])
	by hub.freebsd.org (Postfix) with ESMTP id F0C3637B719
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Mar 2001 17:35:31 -0800 (PST)
	(envelope-from Jim.Pirzyk@disney.com)
Received: from pain10.corp.disney.com (root@pain10.corp.disney.com [153.7.110.100])
	by mail.disney.com (Switch-2.0.1/Switch-2.0.1) with SMTP id f2D1Z2c13346
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Mar 2001 17:35:02 -0800 (PST)
Received: from louie.fa.disney.com by pain.corp.disney.com with ESMTP for FreeBSD-gnats-submit@freebsd.org; Mon, 12 Mar 2001 17:36:10 -0800
Received: from plio.fan.fa.disney.com (plio.fan.fa.disney.com [153.7.118.2])
	by louie.fa.disney.com (8.9.2/8.9.2) with ESMTP id RAA04685
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Mar 2001 17:35:30 -0800 (PST)
	(envelope-from Jim.Pirzyk@fa.disney.com)
Received: from snoopy.fan.fa.disney.com (snoopy.fan.fa.disney.com [153.7.117.170])
	by plio.fan.fa.disney.com (8.9.2/8.9.2) with ESMTP id RAA09362
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Mar 2001 17:35:29 -0800 (PST)
	(envelope-from Jim.Pirzyk@fa.disney.com)
Received: (from Jim.Pirzyk@localhost)
	by snoopy.fan.fa.disney.com (8.11.1/8.9.3) id f2D1ZTH06033;
	Mon, 12 Mar 2001 17:35:29 -0800 (PST)
	(envelope-from Jim.Pirzyk@fa.disney.com)
Message-Id: <200103130135.f2D1ZTH06033@snoopy.fan.fa.disney.com>
Date: Mon, 12 Mar 2001 17:35:29 -0800 (PST)
From: Jim.Pirzyk@disney.com
Reply-To: Jim.Pirzyk@disney.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: rcp does not handle logins with a '.' in them
X-Send-Pr-Version: 3.2

>Number:         25757
>Category:       bin
>Synopsis:       rcp does not handle logins with a '.' in it
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pirzyk
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 12 17:40:01 PST 2001
>Closed-Date:    Wed May 30 09:19:23 PDT 2001
>Last-Modified:  Wed May 30 09:19:51 PDT 2001
>Originator:     Jim Pirzyk
>Release:        FreeBSD 4.2-RELEASE i386
>Organization:
>Environment:

	FreeBSD 4.2-RELEASE

>Description:

	If you use rcp with a login name, that login name has a '.' in it, rcp
	will fail, but returns a 0 error code.

>How-To-Repeat:

	touch /tmp/junk
	rcp Jim.Pirzyk@localhost:/tmp/junk /tmp/junk2

>Fix:

	The following fix handles both problems,
		a) returns non zero when the login name is bad.
		b) allows a '.' in the login name

*** ./bin/rcp/rcp.c.orig	Thu Feb 24 13:21:15 2000
--- ./bin/rcp/rcp.c	Mon Mar 12 17:28:50 2001
***************
*** 308,315 ****
  				suser = argv[i];
  				if (*suser == '\0')
  					suser = pwd->pw_name;
! 				else if (!okname(suser))
  					continue;
  				(void)snprintf(bp, len,
  				    "%s %s -l %s -n %s %s '%s%s%s:%s'",
  				    _PATH_RSH, host, suser, cmd, src,
--- 308,317 ----
  				suser = argv[i];
  				if (*suser == '\0')
  					suser = pwd->pw_name;
! 				else if (!okname(suser)) {
! 					++errs;
  					continue;
+ 				}
  				(void)snprintf(bp, len,
  				    "%s %s -l %s -n %s %s '%s%s%s:%s'",
  				    _PATH_RSH, host, suser, cmd, src,
***************
*** 389,396 ****
  			suser = argv[i];
  			if (*suser == '\0')
  				suser = pwd->pw_name;
! 			else if (!okname(suser))
  				continue;
  		}
  		len = strlen(src) + CMDNEEDS + 20;
  		if ((bp = malloc(len)) == NULL)
--- 391,400 ----
  			suser = argv[i];
  			if (*suser == '\0')
  				suser = pwd->pw_name;
! 			else if (!okname(suser)) {
! 				++errs;
  				continue;
+ 			}
  		}
  		len = strlen(src) + CMDNEEDS + 20;
  		if ((bp = malloc(len)) == NULL)
*** ./bin/rcp/util.c.orig	Mon Mar 12 17:14:08 2001
--- ./bin/rcp/util.c	Mon Mar 12 17:29:38 2001
***************
*** 98,104 ****
  		c = *cp;
  		if (c & 0200)
  			goto bad;
! 		if (!isalpha(c) && !isdigit(c) && c != '_' && c != '-')
  			goto bad;
  	} while (*++cp);
  	return (1);
--- 98,104 ----
  		c = *cp;
  		if (c & 0200)
  			goto bad;
! 		if (!isalpha(c) && !isdigit(c) && c != '_' && c != '-' &&  c != '.')
  			goto bad;
  	} while (*++cp);
  	return (1);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->pirzyk 
Responsible-Changed-By: pirzyk 
Responsible-Changed-When: Tue May 29 08:59:14 PDT 2001 
Responsible-Changed-Why:  
Took ownership of my own bug report. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=25757 
State-Changed-From-To: open->closed 
State-Changed-By: pirzyk 
State-Changed-When: Wed May 30 09:19:23 PDT 2001 
State-Changed-Why:  
Fixed in -current, will be MFC'ed in 3 weeks. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=25757 
>Unformatted:
