From andrew@ugh.net.au  Thu Feb 22 04:34:46 2001
Return-Path: <andrew@ugh.net.au>
Received: from starbug.ugh.net.au (starbug.ugh.net.au [203.31.238.37])
	by hub.freebsd.org (Postfix) with ESMTP id 1982A37B65D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Feb 2001 04:34:45 -0800 (PST)
	(envelope-from andrew@ugh.net.au)
Received: by starbug.ugh.net.au (Postfix, from userid 1000)
	id 91DF5A86C; Thu, 22 Feb 2001 23:34:44 +1100 (EST)
Message-Id: <20010222123444.91DF5A86C@starbug.ugh.net.au>
Date: Thu, 22 Feb 2001 23:34:44 +1100 (EST)
From: andrew@ugh.net.au
Reply-To: andrew@ugh.net.au
To: FreeBSD-gnats-submit@freebsd.org
Subject: bs accepts -s -c but not -sc
X-Send-Pr-Version: 3.2

>Number:         25278
>Category:       bin
>Synopsis:       [patch] bs accepts -s -c but not -sc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 22 04:40:01 PST 2001
>Closed-Date:    Wed May 21 18:10:02 UTC 2008
>Last-Modified:  Wed May 21 18:10:02 UTC 2008
>Originator:     Andrew
>Release:        FreeBSD 4.2-STABLE i386
>Organization:
UgH!
>Environment:

4.2-STABLE as of a week ago.

>Description:

The bs program accepts -s and -c as arguments but not -sc. bs was using its own
argument passing routines so I changed it over to getopt. While I was at it I
added a usage function, changed the program name in the usage message from
battle to bs (as that is what it is installed as nowdays), changed the exit
value from 1 to EX_USAGE when exiting because of invalid arguments, sorted the
included header files as per style(9) and added -Wall to the makefile.

I've tried to keep the same programming style as the existing code.

>How-To-Repeat:

bs -sc (it runs but the c is ignored)

>Fix:

--- /usr/src/games/bs/Makefile	Sat Aug 28 09:28:57 1999
+++ Makefile	Thu Feb 22 22:17:20 2001
@@ -2,6 +2,7 @@
 
 PROG=   bs
 MAN6=   bs.6
+CFLAGS+=-Wall
 DPADD=  ${LIBNCURSES} ${LIBMYTINFO}
 LDADD=  -lncurses -lmytinfo
 HIDEGAME=hidegame


--- /usr/src/games/bs/bs.c	Mon Feb 21 13:07:31 2000
+++ bs.c	Thu Feb 22 22:25:08 2001
@@ -9,14 +9,15 @@
  * $FreeBSD: src/games/bs/bs.c,v 1.9 2000/02/21 03:07:31 billf Exp $
  */
 
+#include <assert.h>
+#include <ctype.h>
 #include <ncurses.h>
 #include <signal.h>
-#include <ctype.h>
-#include <assert.h>
 #include <stdlib.h>
-#include <unistd.h>
-#include <time.h>
 #include <string.h>
+#include <sysexits.h>
+#include <time.h>
+#include <unistd.h>
 
 #ifndef A_UNDERLINE	/* BSD curses */
 #define	beep()	write(1,"\007",1);
@@ -1110,58 +1111,50 @@
     return(sgetc("YN") == 'Y');
 }
 
-static void do_options(c,op)
-int c;
-char *op[];
+static void usage()
 {
-    int i;
 
-    if (c > 1)
-    {
-	for (i=1; i<c; i++)
-	{
-	    switch(op[i][0])
-	    {
-	    default:
-	    case '?':
-		(void) fprintf(stderr, "Usage: battle [-s | -b] [-c]\n");
-		(void) fprintf(stderr, "\tWhere the options are:\n");
-		(void) fprintf(stderr, "\t-s : play a salvo game\n");
-		(void) fprintf(stderr, "\t-b : play a blitz game\n");
-		(void) fprintf(stderr, "\t-c : ships may be adjacent\n");
-		exit(1);
-		break;
-	    case '-':
-		switch(op[i][1])
-		{
-		case 'b':
+    (void) fprintf(stderr, "Usage: bs [-s | -b] [-c]\n"
+			   "\tWhere the options are:\n"
+			   "\t-s : play a salvo game\n"
+			   "\t-b : play a blitz game\n"
+			   "\t-c : ships may be adjacent\n");
+    exit(EX_USAGE);
+}
+
+static void do_options(argc,argv)
+int argc;
+char *argv[];
+{
+    int c;
+
+    while ((c = getopt(argc, argv, "bcs")) != -1) {
+	switch (c) {
+	case 'b':
+		if (salvo == 1) {
+		    (void) fprintf(stderr,
+			    "Bad Arg: -b and -s are mutually exclusive\n");
+		    exit(EX_USAGE);
+		} else {
 		    blitz = 1;
-		    if (salvo == 1)
-		    {
-			(void) fprintf(stderr,
-				"Bad Arg: -b and -s are mutually exclusive\n");
-			exit(1);
-		    }
-		    break;
-		case 's':
-		    salvo = 1;
-		    if (blitz == 1)
-		    {
-			(void) fprintf(stderr,
-				"Bad Arg: -s and -b are mutually exclusive\n");
-			exit(1);
-		    }
-		    break;
-		case 'c':
-		    closepack = 1;
-		    break;
-		default:
+		}
+                break;
+        case 'c':
+		closepack = 1;
+                break;
+        case 's':
+		if (blitz == 1) {
 		    (void) fprintf(stderr,
-			    "Bad arg: type \"%s ?\" for usage message\n", op[0]);
-		    exit(1);
+			    "Bad Arg: -s and -b are mutually exclusive\n");
+		    exit(EX_USAGE);
+		} else {
+		    salvo = 1;
 		}
-	    }
-	}
+                break;
+        case '?':
+        default:
+                usage();
+        }
     }
 }
 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: dd 
State-Changed-When: Mon Jun 18 18:11:46 PDT 2001 
State-Changed-Why:  
The patch looks good, except it's difficult to review because you 
chose to do #include reorganization, style fixes, or play function 
games (I can't tell which) along side functional changes.  Please 
submit this as two different patches. 

Thanks. 


Responsible-Changed-From-To: freebsd-bugs->dd 
Responsible-Changed-By: dd 
Responsible-Changed-When: Mon Jun 18 18:11:46 PDT 2001 
Responsible-Changed-Why:  
I'll take care of this provided that the originator can split this up 
into managable chunks. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=25278 

From: <andrew@ugh.net.au>
To: <freebsd-gnats-submit@freebsd.org>
Cc: <freebsd-bugs@FreeBSD.org>, <dd@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc
Date: Tue, 19 Jun 2001 20:50:17 +1000 (EST)

 On Mon, 18 Jun 2001 dd@FreeBSD.org wrote:
 
 > The patch looks good, except it's difficult to review because you
 > chose to do #include reorganization, style fixes, or play function
 > games (I can't tell which) along side functional changes.  Please
 > submit this as two different patches.
 
 OK here's a patch to just add a usage function and convert bs to using
 getopt.
 
 Thanks,
 
 Andrew
 

From: <andrew@ugh.net.au>
To: <freebsd-gnats-submit@freebsd.org>
Cc: <freebsd-bugs@FreeBSD.org>, <dd@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc
Date: Tue, 19 Jun 2001 20:59:50 +1000 (EST)

 Here's a patch to sort the headers. It assumes the previous patch has been
 applied.
 
 Thanks,
 
 Andrew
 
 --- bs.usage/bs.c	Tue Jun 19 20:38:38 2001
 +++ bs.headers/bs.c	Tue Jun 19 20:54:12 2001
 @@ -9,15 +9,15 @@
   * $FreeBSD: src/games/bs/bs.c,v 1.9 2000/02/21 03:07:31 billf Exp $
   */
 
 +#include <assert.h>
 +#include <ctype.h>
  #include <ncurses.h>
  #include <signal.h>
 -#include <ctype.h>
 -#include <assert.h>
  #include <stdlib.h>
 -#include <unistd.h>
 -#include <time.h>
  #include <string.h>
  #include <sysexits.h>
 +#include <time.h>
 +#include <unistd.h>
 
  #ifndef A_UNDERLINE	/* BSD curses */
  #define	beep()	write(1,"\007",1);
 

From: <andrew@ugh.net.au>
To: <freebsd-gnats-submit@freebsd.org>
Cc: <freebsd-bugs@FreeBSD.org>, <dd@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc
Date: Tue, 19 Jun 2001 21:02:55 +1000 (EST)

 OK, here is a patch to add -Wall to the Makefile.
 
 --- Makefile.orig	Tue Jun 19 21:00:39 2001
 +++ Makefile	Tue Jun 19 20:52:18 2001
 @@ -2,6 +2,7 @@
 
  PROG=   bs
  MAN=   bs.6
 +CFLAGS+=-Wall
  DPADD=  ${LIBNCURSES} ${LIBMYTINFO}
  LDADD=  -lncurses -lmytinfo
  HIDEGAME=hidegame
 
 

From: Dima Dorfman <dima@unixfreak.org>
To: andrew@ugh.net.au
Cc: freebsd-gnats-submit@freebsd.org, freebsd-bugs@FreeBSD.org
Subject: Re: bin/25278: bs accepts -s -c but not -sc 
Date: Tue, 19 Jun 2001 17:17:39 -0700

 <andrew@ugh.net.au> writes:
 > 
 > 
 > On Mon, 18 Jun 2001 dd@FreeBSD.org wrote:
 > 
 > > The patch looks good, except it's difficult to review because you
 > > chose to do #include reorganization, style fixes, or play function
 > > games (I can't tell which) along side functional changes.  Please
 > > submit this as two different patches.
 > 
 > OK here's a patch to just add a usage function and convert bs to using
 > getopt.
 
 Did you forget to attach something? :-)
 
 > 
 > Thanks,
 > 
 > Andrew
 > 

From: Dima Dorfman <dima@unixfreak.org>
To: andrew@ugh.net.au
Cc: freebsd-gnats-submit@freebsd.org, freebsd-bugs@FreeBSD.org
Subject: Re: bin/25278: bs accepts -s -c but not -sc 
Date: Tue, 19 Jun 2001 17:18:39 -0700

 <andrew@ugh.net.au> writes:
 > OK, here is a patch to add -Wall to the Makefile.
 > 
 > --- Makefile.orig	Tue Jun 19 21:00:39 2001
 > +++ Makefile	Tue Jun 19 20:52:18 2001
 > @@ -2,6 +2,7 @@
 > 
 >  PROG=   bs
 >  MAN=   bs.6
 > +CFLAGS+=-Wall
 
 I don't know if you're using -currnet, but the new WARNS= stuff is
 preferred to specifying warning flags in CFLAGS.
 
 >  DPADD=  ${LIBNCURSES} ${LIBMYTINFO}
 >  LDADD=  -lncurses -lmytinfo
 >  HIDEGAME=hidegame
 > 
 > 

From: <andrew@ugh.net.au>
To: Dima Dorfman <dima@unixfreak.org>
Cc: <freebsd-gnats-submit@freebsd.org>, <freebsd-bugs@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc 
Date: Wed, 20 Jun 2001 10:24:00 +1000 (EST)

 On Tue, 19 Jun 2001, Dima Dorfman wrote:
 
 > > OK here's a patch to just add a usage function and convert bs to using
 > > getopt.
 >
 > Did you forget to attach something? :-)
 
 Ooops. Lets try again...
 
 --- bs/bs.c	Tue Jun 19 20:09:29 2001
 +++ bs.usage/bs.c	Tue Jun 19 20:38:38 2001
 @@ -17,6 +17,7 @@
  #include <unistd.h>
  #include <time.h>
  #include <string.h>
 +#include <sysexits.h>
 
  #ifndef A_UNDERLINE	/* BSD curses */
  #define	beep()	write(1,"\007",1);
 @@ -1110,59 +1111,53 @@
      return(sgetc("YN") == 'Y');
  }
 
 -static void do_options(c,op)
 -int c;
 -char *op[];
 +static void usage()
  {
 -    int i;
 
 -    if (c > 1)
 -    {
 -	for (i=1; i<c; i++)
 -	{
 -	    switch(op[i][0])
 -	    {
 -	    default:
 -	    case '?':
 -		(void) fprintf(stderr, "Usage: battle [-s | -b] [-c]\n");
 -		(void) fprintf(stderr, "\tWhere the options are:\n");
 -		(void) fprintf(stderr, "\t-s : play a salvo game\n");
 -		(void) fprintf(stderr, "\t-b : play a blitz game\n");
 -		(void) fprintf(stderr, "\t-c : ships may be adjacent\n");
 -		exit(1);
 -		break;
 -	    case '-':
 -		switch(op[i][1])
 -		{
 +	(void) fprintf(stderr, "Usage: bs [-s | -b] [-c]\n"
 +						  "\tWhere the options are:\n"
 +						  "\t-s : play a salvo game\n"
 +						  "\t-b : play a blitz game\n"
 +						  "\t-c : ships may be adjacent\n");
 +	exit(EX_USAGE);
 +}
 +
 +static void do_options(argc,argv)
 +int argc;
 +char *argv[];
 +{
 +    int c;
 +
 +	while ((c = getopt(argc, argv, "bcs")) != -1) {
 +		switch (c) {
  		case 'b':
 -		    blitz = 1;
 -		    if (salvo == 1)
 -		    {
 -			(void) fprintf(stderr,
 -				"Bad Arg: -b and -s are mutually exclusive\n");
 -			exit(1);
 -		    }
 -		    break;
 -		case 's':
 -		    salvo = 1;
 -		    if (blitz == 1)
 -		    {
 -			(void) fprintf(stderr,
 -				"Bad Arg: -s and -b are mutually exclusive\n");
 -			exit(1);
 -		    }
 -		    break;
 +			if (salvo == 1)
 +			{
 +				(void) fprintf(stderr,
 +						"Bad arg: -b and -s are mutually exclusive\n");
 +				exit(EX_USAGE);
 +			} else {
 +				blitz = 1;
 +			}
 +			break;
  		case 'c':
 -		    closepack = 1;
 -		    break;
 +			closepack = 1;
 +			break;
 +		case 's':
 +			if (blitz == 1)
 +			{
 +				(void) fprintf(stderr,
 +						"Bad arg: -s and -b are mutually exclusive\n");
 +				exit(EX_USAGE);
 +			} else {
 +				salvo = 1;
 +			}
 +			break;
 +		case '?':
  		default:
 -		    (void) fprintf(stderr,
 -			    "Bad arg: type \"%s ?\" for usage message\n", op[0]);
 -		    exit(1);
 +			usage();
  		}
 -	    }
  	}
 -    }
  }
 
  static int scount(who)
 
 
 Thanks,
 
 Andrew
 

From: <andrew@ugh.net.au>
To: Dima Dorfman <dima@unixfreak.org>
Cc: <freebsd-gnats-submit@freebsd.org>, <freebsd-bugs@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc 
Date: Wed, 20 Jun 2001 10:25:43 +1000 (EST)

 On Tue, 19 Jun 2001, Dima Dorfman wrote:
 
 > I don't know if you're using -currnet, but the new WARNS= stuff is
 > preferred to specifying warning flags in CFLAGS.
 
 No, only stable. If someone running current wants to change this I'm quite
 happy. Thanks for pointing it out,
 
 Andrew
 
 

From: Andrew <andrew@ugh.net.au>
To: freebsd-gnats-submit@FreeBSD.org
Cc: dima@unixfreak.org, <freebsd-bugs@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc
Date: Mon, 10 Jun 2002 02:22:07 +1000 (EST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
   Send mail to mime@docserver.cac.washington.edu for more info.
 
 --0-1850879848-1023639727=:94582
 Content-Type: TEXT/PLAIN; charset=US-ASCII
 
 Well I've rewritten the changes to try and minise the diffs...not too
 successfuly however but hopefully enough to see them committed.
 
 Here is a patch to split usage off into a seperate function.
 
 (other patches to follow)
 
 Thanks,
 
 Andrew
 
 --0-1850879848-1023639727=:94582
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="bs.1.usage.patch"
 Content-Transfer-Encoding: BASE64
 Content-ID: <20020610022207.M94582@starbug.ugh.net.au>
 Content-Description: make usage a seperate function
 Content-Disposition: attachment; filename="bs.1.usage.patch"
 
 LS0tIC91c3Ivc3JjL2dhbWVzL2JzL2JzLmMJTW9uIEZlYiAyMSAxNDowNzoz
 MSAyMDAwDQorKysgYnMuYwlNb24gSnVuIDEwIDAxOjI2OjIwIDIwMDINCkBA
 IC0xMTEwLDYgKzExMTAsMTcgQEANCiAgICAgcmV0dXJuKHNnZXRjKCJZTiIp
 ID09ICdZJyk7DQogfQ0KIA0KK3N0YXRpYyB2b2lkIHVzYWdlKHZvaWQpIHsN
 CisNCisgICAgKHZvaWQpIGZwcmludGYoc3RkZXJyLCAiVXNhZ2U6IGJzIFst
 cyB8IC1iXSBbLWNdXG4iDQorCQkJICAgICAgICJcdFdoZXJlIHRoZSBvcHRp
 b25zIGFyZTpcbiINCisJCQkgICAgICAgIlx0LXMgOiBwbGF5IGEgc2Fsdm8g
 Z2FtZVxuIg0KKwkJCSAgICAgICAiXHQtYiA6IHBsYXkgYSBibGl0eiBnYW1l
 XG4iDQorCQkJICAgICAgICJcdC1jIDogc2hpcHMgbWF5IGJlIGFkamFjZW50
 XG4iKTsNCisgICAgZXhpdCgxKTsNCit9DQorDQorDQogc3RhdGljIHZvaWQg
 ZG9fb3B0aW9ucyhjLG9wKQ0KIGludCBjOw0KIGNoYXIgKm9wW107DQpAQCAt
 MTEyNCwxMiArMTEzNSw3IEBADQogCSAgICB7DQogCSAgICBkZWZhdWx0Og0K
 IAkgICAgY2FzZSAnPyc6DQotCQkodm9pZCkgZnByaW50ZihzdGRlcnIsICJV
 c2FnZTogYmF0dGxlIFstcyB8IC1iXSBbLWNdXG4iKTsNCi0JCSh2b2lkKSBm
 cHJpbnRmKHN0ZGVyciwgIlx0V2hlcmUgdGhlIG9wdGlvbnMgYXJlOlxuIik7
 DQotCQkodm9pZCkgZnByaW50ZihzdGRlcnIsICJcdC1zIDogcGxheSBhIHNh
 bHZvIGdhbWVcbiIpOw0KLQkJKHZvaWQpIGZwcmludGYoc3RkZXJyLCAiXHQt
 YiA6IHBsYXkgYSBibGl0eiBnYW1lXG4iKTsNCi0JCSh2b2lkKSBmcHJpbnRm
 KHN0ZGVyciwgIlx0LWMgOiBzaGlwcyBtYXkgYmUgYWRqYWNlbnRcbiIpOw0K
 LQkJZXhpdCgxKTsNCisJCXVzYWdlKCk7DQogCQlicmVhazsNCiAJICAgIGNh
 c2UgJy0nOg0KIAkJc3dpdGNoKG9wW2ldWzFdKQ0K
 --0-1850879848-1023639727=:94582--

From: Andrew <andrew@ugh.net.au>
To: freebsd-gnats-submit@FreeBSD.org
Cc: dima@unixfreak.org, <freebsd-bugs@FreeBSD.org>
Subject: Re: bin/25278: bs accepts -s -c but not -sc
Date: Mon, 10 Jun 2002 02:28:03 +1000 (EST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
   Send mail to mime@docserver.cac.washington.edu for more info.
 
 --0-1524894074-1023640083=:94582
 Content-Type: TEXT/PLAIN; charset=US-ASCII
 
 
 
 On Mon, 10 Jun 2002, Andrew wrote:
 
 > (other patches to follow)
 
 Ok here is a patch to get bs to use getopt. The diff looks messy but it
 basically changes the guts of do_options from parsing command line options
 itself to calling getopt. If you apply the patch then compare the
 functions manually you can see what it happening.
 
 This patch actually fixes the problem I was having.
 
 Thanks,
 
 Andrew
 
 --0-1524894074-1023640083=:94582
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="bs.2.getopt.patch"
 Content-Transfer-Encoding: BASE64
 Content-ID: <20020610022803.P94582@starbug.ugh.net.au>
 Content-Description: use getopt
 Content-Disposition: attachment; filename="bs.2.getopt.patch"
 
 LS0tIGJzLnVzYWdlL2JzLmMJTW9uIEp1biAxMCAwMToyNjoyMCAyMDAyDQor
 KysgYnMuZ2V0b3B0L2JzLmMJTW9uIEp1biAxMCAwMjowODoyMiAyMDAyDQpA
 QCAtMTEyMSw1MiArMTEyMSw0MSBAQA0KIH0NCiANCiANCi1zdGF0aWMgdm9p
 ZCBkb19vcHRpb25zKGMsb3ApDQotaW50IGM7DQotY2hhciAqb3BbXTsNCitz
 dGF0aWMgdm9pZCBkb19vcHRpb25zKGFyZ2MsYXJndikNCitpbnQgYXJnYzsN
 CitjaGFyICphcmd2W107DQogew0KLSAgICBpbnQgaTsNCisgICAgaW50IGM7
 DQogDQotICAgIGlmIChjID4gMSkNCi0gICAgew0KLQlmb3IgKGk9MTsgaTxj
 OyBpKyspDQotCXsNCi0JICAgIHN3aXRjaChvcFtpXVswXSkNCi0JICAgIHsN
 Ci0JICAgIGRlZmF1bHQ6DQotCSAgICBjYXNlICc/JzoNCi0JCXVzYWdlKCk7
 DQotCQlicmVhazsNCi0JICAgIGNhc2UgJy0nOg0KLQkJc3dpdGNoKG9wW2ld
 WzFdKQ0KKyAgICB3aGlsZSAoKGMgPSBnZXRvcHQoYXJnYywgYXJndiwgImJj
 cyIpKSAhPSAtMSkgew0KKwlzd2l0Y2ggKGMpIHsNCisJICAgIGNhc2UgJ2In
 Og0KKwkJaWYgKHNhbHZvID09IDEpDQogCQl7DQotCQljYXNlICdiJzoNCisJ
 CSAgICAodm9pZCkgZnByaW50ZihzdGRlcnIsDQorCQkJICAgICJCYWQgQXJn
 OiAtYiBhbmQgLXMgYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZVxuIik7DQorCQkg
 ICAgZXhpdCgxKTsNCisJCX0NCisJCWVsc2UNCiAJCSAgICBibGl0eiA9IDE7
 DQotCQkgICAgaWYgKHNhbHZvID09IDEpDQotCQkgICAgew0KLQkJCSh2b2lk
 KSBmcHJpbnRmKHN0ZGVyciwNCi0JCQkJIkJhZCBBcmc6IC1iIGFuZCAtcyBh
 cmUgbXV0dWFsbHkgZXhjbHVzaXZlXG4iKTsNCi0JCQlleGl0KDEpOw0KLQkJ
 ICAgIH0NCi0JCSAgICBicmVhazsNCi0JCWNhc2UgJ3MnOg0KLQkJICAgIHNh
 bHZvID0gMTsNCi0JCSAgICBpZiAoYmxpdHogPT0gMSkNCi0JCSAgICB7DQot
 CQkJKHZvaWQpIGZwcmludGYoc3RkZXJyLA0KLQkJCQkiQmFkIEFyZzogLXMg
 YW5kIC1iIGFyZSBtdXR1YWxseSBleGNsdXNpdmVcbiIpOw0KLQkJCWV4aXQo
 MSk7DQotCQkgICAgfQ0KLQkJICAgIGJyZWFrOw0KLQkJY2FzZSAnYyc6DQot
 CQkgICAgY2xvc2VwYWNrID0gMTsNCi0JCSAgICBicmVhazsNCi0JCWRlZmF1
 bHQ6DQorCQlicmVhazsNCisJICAgIGNhc2UgJ3MnOg0KKwkJaWYgKGJsaXR6
 ID09IDEpDQorCQl7DQogCQkgICAgKHZvaWQpIGZwcmludGYoc3RkZXJyLA0K
 LQkJCSAgICAiQmFkIGFyZzogdHlwZSBcIiVzID9cIiBmb3IgdXNhZ2UgbWVz
 c2FnZVxuIiwgb3BbMF0pOw0KKwkJCSAgICAiQmFkIEFyZzogLXMgYW5kIC1i
 IGFyZSBtdXR1YWxseSBleGNsdXNpdmVcbiIpOw0KIAkJICAgIGV4aXQoMSk7
 DQogCQl9DQotCSAgICB9DQorCQllbHNlDQorCQkgICAgc2Fsdm8gPSAxOw0K
 KwkJYnJlYWs7DQorCSAgICBjYXNlICdjJzoNCisJCWNsb3NlcGFjayA9IDE7
 DQorCQlicmVhazsNCisJICAgIGNhc2UgJz8nOg0KKwkgICAgZGVmYXVsdDoN
 CisJCXVzYWdlKCk7DQorCQlicmVhazsNCiAJfQ0KICAgICB9DQogfQ0K
 --0-1524894074-1023640083=:94582--
Responsible-Changed-From-To: dd->freebsd-bugs 
Responsible-Changed-By: dd 
Responsible-Changed-When: Tue Jun 14 10:19:35 UTC 2005 
Responsible-Changed-Why:  
Sorry, I don't have time to do this right now. If you (the submitter) 
are still interested, perhaps sending an updated patch to a mailing 
list would stir some activity. 

My apologies for dropping the ball on this for so long. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25278 
State-Changed-From-To: feedback->suspended 
State-Changed-By: linimon 
State-Changed-When: Sat Mar 1 19:43:14 UTC 2008 
State-Changed-Why:  
It does not look like anyone is working on this right now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25278 
State-Changed-From-To: suspended->closed 
State-Changed-By: antoine 
State-Changed-When: Wed May 21 18:08:55 UTC 2008 
State-Changed-Why:  
Change state from suspended to closed: games/bs has been 
removed from FreeBSD 5 years ago. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25278 
>Unformatted:
