From hal.IN-Berlin.DE!dirk@methan.chemie.fu-berlin.de  Sun Jan 12 17:00:55 1997
Received: from methan.chemie.fu-berlin.de (methan.chemie.fu-berlin.de [160.45.22.81])
          by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id RAA07769
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Jan 1997 17:00:37 -0800 (PST)
Received: by methan.chemie.fu-berlin.de (Smail3.1.29.1)
	  id <m0vjakt-0009w6C>; Mon, 13 Jan 97 02:00 MET
Received: (from dirk@localhost)
          by hal.IN-Berlin.DE (8.8.4/8.8.4)
	  id BAA15568; Mon, 13 Jan 1997 01:58:17 +0100 (MET)
Message-Id: <199701130058.BAA15568@hal.IN-Berlin.DE>
Date: Mon, 13 Jan 1997 01:58:17 +0100 (MET)
From: dirk@hal.in-berlin.de (Dirk Froemberg)
To: FreeBSD-gnats-submit@freebsd.org
Subject: too much wtmp entries with pppd
X-Send-Pr-Version: 3.2

>Number:         2474
>Category:       bin
>Synopsis:       too much wtmp entries with pppd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 12 17:10:01 PST 1997
>Closed-Date:    Fri Jan 17 23:52:11 MET 1997
>Last-Modified:  Fri Jan 17 23:52:36 MET 1997
>Originator:     Dirk Froemberg
>Release:        FreeBSD 2.2-RELEASE i386
>Organization:
>Environment:

	FreeBSD-2.2, pppd-2.2

>Description:

	When using pppd with the option 'login' (use system passwd database
	for authentication) two wtmp-entries are written for each login.
	(Another is written when logging out, of course. Thus three entries
	are added to the wtmp file.)

>How-To-Repeat:

	see above

>Fix:
	
	The following patch seems to be sufficient for the pppd. Another
	fix would be not to write a wtmp entry with login(3). BTW:
	login(3) und logout(3) behave inconsistently somehow, because
	logout(3) just clears the utmp entry...

*** /usr/src/usr.sbin/pppd/auth.c.dist	Tue Dec 31 00:36:23 1996
--- /usr/src/usr.sbin/pppd/auth.c	Mon Jan 13 01:50:04 1997
***************
*** 524,530 ****
      if (strncmp(tty, "/dev/", 5) == 0)
  	tty += 5;
  
!     logwtmp(tty, user, ":PPP");		/* Add wtmp login entry */
      logged_in = TRUE;
  
      /* Log in utmp too */
--- 524,530 ----
      if (strncmp(tty, "/dev/", 5) == 0)
  	tty += 5;
  
!     /* logwtmp(tty, user, ":PPP");		/* Add wtmp login entry */
      logged_in = TRUE;
  
      /* Log in utmp too */

>Release-Note:
>Audit-Trail:

From: j@uriah.heep.sax.de (J Wunsch)
To: dirk@hal.in-berlin.de (Dirk Froemberg)
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/2474: too much wtmp entries with pppd
Date: Mon, 13 Jan 1997 09:56:33 +0100

 As Dirk Froemberg wrote:
 
 > 	When using pppd with the option 'login' (use system passwd database
 > 	for authentication) two wtmp-entries are written for each login.
 
 Already fixed.
 -- 
 cheers, J"org
 
 joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
 Never trust an operating system you don't have sources for. ;-)
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Fri Jan 17 23:52:11 MET 1997 
State-Changed-Why:  
Already fixed in -current and 2.2. 

>Unformatted:
