From petef@electron.databits.net  Mon Jan 22 10:21:48 2001
Return-Path: <petef@electron.databits.net>
Received: from electron.databits.net (dialup1.databits.net [207.29.204.16])
	by hub.freebsd.org (Postfix) with ESMTP id 7E90D37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Jan 2001 10:21:46 -0800 (PST)
Received: (from petef@localhost)
	by electron.databits.net (8.11.1/8.9.3) id f0MIL8250925;
	Mon, 22 Jan 2001 13:21:08 -0500 (EST)
	(envelope-from petef)
Message-Id: <200101221821.f0MIL8250925@electron.databits.net>
Date: Mon, 22 Jan 2001 13:21:08 -0500 (EST)
From: petef@databits.net
Reply-To: petef@databits.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: add '-c' flag to src/bin/domainname to clear domainname
X-Send-Pr-Version: 3.2

>Number:         24540
>Category:       bin
>Synopsis:       add '-c' flag to src/bin/domainname to clear domainname
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 22 10:30:00 PST 2001
>Closed-Date:    Mon Jun 18 17:52:43 PDT 2001
>Last-Modified:  Mon Jun 18 17:52:54 PDT 2001
>Originator:     Pete Fritchman
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Databits Network Services, Inc.
>Environment:

FreeBSD 5.0-CURRENT

>Description:

Add the "-c" flag to domainname to allow clearing of the current YP/NIS
domain.

>How-To-Repeat:

Set a domainname with domainname(1) and try to clear it using domainname(1).

>Fix:


Index: domainname.1
===================================================================
RCS file: /home/ncvs/src/bin/domainname/domainname.1,v
retrieving revision 1.11
diff -u -r1.11 domainname.1
--- domainname.1	2000/12/14 11:39:33	1.11
+++ domainname.1	2001/01/22 18:17:47
@@ -40,6 +40,7 @@
 .Nd set or print name of current YP/NIS domain
 .Sh SYNOPSIS
 .Nm
+.Op Fl c
 .Op Ar ypdomain
 .Sh DESCRIPTION
 .Nm Domainname
@@ -49,6 +50,13 @@
 .Pa /etc/rc.network ,
 normally run at boot
 time.
+.Pp
+The following options are available:
+.Bl -tag -width indent
+.It Fl c
+Clear the current YP/NIS domain.  Note that programs accessing 
+the password database cache the domain, and will need to be 
+restarted to see the change.
 .Sh NOTA BENE
 The YP/NIS (formerly ``Yellow Pages'' but renamed for legal reasons)
 domain name does not necessarily have anything to do with the Domain

Index: domainname.c
===================================================================
RCS file: /home/ncvs/src/bin/domainname/domainname.c,v
retrieving revision 1.12
diff -u -r1.12 domainname.c
--- domainname.c	1999/08/27 23:14:08	1.12
+++ domainname.c	2001/01/22 18:17:49
@@ -63,8 +63,13 @@
 	int ch;
 	char domainname[MAXHOSTNAMELEN];
 
-	while ((ch = getopt(argc, argv, "")) != -1)
+	while ((ch = getopt(argc, argv, "c")) != -1)
 		switch (ch) {
+		case 'c':
+			if (setdomainname("", 1))
+				err(1, "setdomainname");
+			exit(0);
+			break;
 		default:
 			usage();
 		}
@@ -88,6 +93,6 @@
 void
 usage()
 {
-	(void)fprintf(stderr, "usage: domainname [ypdomain]\n");
+	(void)fprintf(stderr, "usage: domainname [-c] [ypdomain]\n");
 	exit(1);
 }

>Release-Note:
>Audit-Trail:

From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To: petef@databits.net
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: bin/24540: add '-c' flag to src/bin/domainname to clear domainname
Date: Mon, 22 Jan 2001 13:34:39 -0500 (EST)

 <<On Mon, 22 Jan 2001 13:21:08 -0500 (EST), petef@databits.net said:
 
 > Set a domainname with domainname(1) and try to clear it using domainname(1).
 
 "domainname ''" doesn't do it for you?
 
 -GAWollman
 
 

From: Pete Fritchman <petef@databits.net>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/24540: add '-c' flag to src/bin/domainname to clear domainname
Date: Mon, 22 Jan 2001 14:05:17 -0500

 ++ 22/01/01 13:34 -0500 - Garrett Wollman:
 >[...]
 >> Set a domainname with domainname(1) and try to clear it using domainname(1).
 >
 >"domainname ''" doesn't do it for you?
 >
 
 Nope.
 
 electron# ./domainname -c
 electron# ./domainname
 
 electron# ./domainname foo.bar
 electron# ./domainname ''
 electron# ./domainname
 foo.bar
 electron# ./domainname -c
 electron# ./domainname
 
 electron#
 
 >-GAWollman
 
 -pete
 
 --
 Pete Fritchman <petef@databits.net>
 Databits Network Services, Inc. <http://databits.net>
 
 

From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To: Pete Fritchman <petef@databits.net>
Cc: freebsd-gnats-submit@FreeBSD.ORG, phk@FreeBSD.ORG
Subject: Re: bin/24540: add '-c' flag to src/bin/domainname to clear domainname
Date: Mon, 22 Jan 2001 15:02:57 -0500 (EST)

 <<On Mon, 22 Jan 2001 11:10:02 -0800 (PST), Pete Fritchman <petef@databits.net> said:
 
 >  electron# ./domainname foo.bar
 >  electron# ./domainname ''
 >  electron# ./domainname
 >  foo.bar
 
 I think this is a bug in sysctl.  Note the following:
 
 root@khavrinen(6)# sysctl -w kern.domainname=''
 kern.domainname: foo.bar -> foo.bar
 
 What is happening is that the sysctl() system call is interpreting the
 request to set the MIB variable to a zero-length object as if it were
 an indication that setting is not requested.  Here is an (untested)
 fix (beware cut&paste has bogotified whitespace):
 
 
 
 --- kern_sysctl.c       2000/07/28 22:40:04     1.100
 +++ kern_sysctl.c       2001/01/22 20:01:38
 @@ -862,7 +862,7 @@
                 req.oldptr= old;
         }
  
 -       if (newlen) {
 +       if (new) {
                 req.newlen = newlen;
                 req.newptr = new;
         }
 @@ -1101,7 +1101,7 @@
                 req.oldptr= old;
         }
  
 -       if (newlen) {
 +       if (new) {
                 if (!useracc(new, req.newlen, VM_PROT_READ))
                         return (EFAULT);
                 req.newlen = newlen;
 
 -GAWollman
 
 
State-Changed-From-To: open->closed 
State-Changed-By: dd 
State-Changed-When: Mon Jun 18 17:52:43 PDT 2001 
State-Changed-Why:  
`domainname ''` works now. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=24540 
>Unformatted:
